From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0079.outbound.protection.outlook.com [157.56.112.79]) by dpdk.org (Postfix) with ESMTP id 8B3D62C72 for ; Tue, 9 Feb 2016 22:15:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ezchip.onmicrosoft.com; s=selector1-ezchip-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IXeL32aaXOWXozYctgpIx28KJ6raFblSkihSqqdX9lk=; b=rCo+ukR9yfMt0t33Thv0qhRhxl5e5d/Aec+qEqRv7MfacRSPUGrJQOFSg6YCmegKv+YUmdCpiixcy3VdOrppZOkMRs1hq0xej975CQIyB8NC9jfIKHAwMsehFJwHuJ4aj3TIwC0+FladyQ9LWwyReh+wT/tsVjFB0HqRHQcoy/c= Received: from DB5PR02MB1015.eurprd02.prod.outlook.com (10.162.162.21) by DB5PR02MB1016.eurprd02.prod.outlook.com (10.162.162.22) with Microsoft SMTP Server (TLS) id 15.1.403.16; Tue, 9 Feb 2016 21:15:27 +0000 Received: from DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) by DB5PR02MB1015.eurprd02.prod.outlook.com ([10.162.162.21]) with mapi id 15.01.0403.017; Tue, 9 Feb 2016 21:15:27 +0000 From: Liming Sun To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. Thread-Index: AQHRY1Vn+a74pPFqfUCX5YGQVbZIXp8j5L8wgABG/ICAAAnOVw== Date: Tue, 9 Feb 2016 21:15:27 +0000 Message-ID: References: <1450193851-9100-4-git-send-email-lsun@ezchip.com> <1642628.fgbdceb2p5@xps13> , <1753191.PlZlSmjA8r@xps13> In-Reply-To: <1753191.PlZlSmjA8r@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=ezchip.com; x-originating-ip: [73.253.58.137] x-microsoft-exchange-diagnostics: 1; DB5PR02MB1016; 5:gkEO1ks42m8cUeurfmKR8n2Iqsf0GRN0/kkjKzCt8g1IgmJi2ShZOp2REp8cc4D/k1btUuLT2ko85IeW8ObWheRRMBC2GXXmCbRyN2eTMCV9HfHZLLgljus/Cuw+Rau8P1LFpYRcrz1us6yuuLoHrw==; 24:VtSjM+SreF1gR7z4KgGB1RA0mOzocAnyqpo+Qm9YDKlNHDN/DMMtbAV2W3sYzuZ8OD6tWbQCtZpPr94PWjKRi+kdlOQ1UAjLz4HWT+wOZZ4= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1016; x-ms-office365-filtering-correlation-id: 91bbe95c-2c4e-41f8-b090-08d33196221f x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:DB5PR02MB1016; BCL:0; PCL:0; RULEID:; SRVR:DB5PR02MB1016; x-forefront-prvs: 08476BC6EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(377454003)(377424004)(3846002)(586003)(6116002)(1220700001)(102836003)(76576001)(1096002)(77096005)(2950100001)(15975445007)(87936001)(92566002)(2900100001)(76176999)(5004730100002)(86362001)(19580405001)(66066001)(50986999)(74316001)(54356999)(33656002)(40100003)(19580395003)(93886004)(3280700002)(5008740100001)(122556002)(4326007)(2906002)(5003600100002)(3660700001)(11100500001)(5001960100002)(110136002)(189998001)(3900700001)(5002640100001)(10400500002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR02MB1016; H:DB5PR02MB1015.eurprd02.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2016 21:15:27.1416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB1016 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2016 21:15:28 -0000 Looks like this patch serie has been merged into dpdk-next-net/rel_16_04. What would be the usual way to submit changes for new comments? Would it be= incremental changes (new commit) based on previous one? Thanks. ________________________________________ From: Thomas Monjalon Sent: Tuesday, February 9, 2016 3:33 PM To: Liming Sun Cc: dev@dpdk.org; bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native bui= ld on tilegx platform. 2016-02-09 18:37, Liming Sun: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > A comment about the TILE-Mx would be welcome. > Is it supported currently? > Isn't it an ARM arch? > > [lsun] Yes, it's ARM arch, but with similar mpipe driver. > It's not fully supported yet. I'll remove this change and add it in a dif= ferent serie when it's ready. OK So we'll discuss how to integrate it later. > > +# Compile combined lib by default. > > +CONFIG_RTE_BUILD_COMBINE_LIBS=3Dy > > Why forcing this option in the defconfig file? > > [lsun] It's just trying to make it handy for other applications like OVS = or ODP on top of DPDK. However we could remove this change if it's not the = recommended way. Yes please remove it. > > ARCH ?=3D tile > > + > > +HOST_ARCH :=3D ${shell uname -m} > > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS =3D else > > CROSS ?=3D tile- > > +endif > > I don't think the CROSS variable should have a default value. > It really depends on the toolchain. > > [lsun] Make sense. The current code (before the change) has default value= 'CROSS ?=3D tile-' defined, which cause some issue when doing native build= . Another way is to define it as "CROSS ?=3D" just like other platforms. So= when doing cross-compile, we could pass " CROSS=3Dtile-" . No need to keep a "CROSS ?=3D" line. The variables defined in the command line get the priority. > Talking about the toolchain, is it possible to build DPDK with the provid= ed binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ? > This is the Tilera Open Source page: http://www.tilera.com/scm/ > > [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of= some header files and libraries to compile DPDK. Yes that's what I've experienced. > We're looking into it to see whether it can be easily fixed. Please keep us informed when the toolchain is ready. Thanks=