From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0051.outbound.protection.outlook.com [104.47.0.51]) by dpdk.org (Postfix) with ESMTP id CBF872934 for ; Wed, 7 Dec 2016 12:44:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Mb6YVrPHZZHzrY0lG0Lzcam2WW/KOWKJSvxN31FpruM=; b=LtqyXbHVuoJ81SHdju2Jm6L7k5nky6jirr43kRvBBBa28PwuPOJnNu9rM0GE9YHhwMHzivHqQLg9f7bYRdYJR1uBczEN3D6pq2crLrahYFKuwGkm1Wj+uQV9UCUV2Te68DXY10zxb8ELQAfaEIH6+OYUQQ3cRh4DbP0dumL9AAs= Received: from DB5PR0401MB1768.eurprd04.prod.outlook.com (10.165.5.146) by DB4PR04MB0848.eurprd04.prod.outlook.com (10.242.193.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.9; Wed, 7 Dec 2016 11:44:01 +0000 Received: from DB5PR0401MB1768.eurprd04.prod.outlook.com ([10.165.5.146]) by DB5PR0401MB1768.eurprd04.prod.outlook.com ([10.165.5.146]) with mapi id 15.01.0761.017; Wed, 7 Dec 2016 11:44:00 +0000 From: Akhil Goyal To: Thomas Monjalon CC: "dev@dpdk.org" , "declan.doherty@intel.com" , "pablo.de.lara.guarch@intel.com" , Hemant Agrawal , =?iso-8859-2?Q?Horia_Geant=E3?= Thread-Topic: [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation Thread-Index: AQHSTsk+b1tiuELqNESvyc7oJ1iIA6D7X5yAgAClQFCAACavgIAANB/w Date: Wed, 7 Dec 2016 11:44:00 +0000 Message-ID: References: <20161205125540.6419-1-akhil.goyal@nxp.com> <5589636.gHNnFhEcxp@xps13> <13107823.ZnI407z9cY@xps13> In-Reply-To: <13107823.ZnI407z9cY@xps13> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [192.88.169.1] x-microsoft-exchange-diagnostics: 1; DB4PR04MB0848; 7:V0ihxeFfcksXT3OISUqv5BLKppdMI1EEzRRTGgEdigjKr1RfxUPo2mDX4Pj3IJYsXkhQRBqUvvAZu1/nEgFREEhVFeEojfTM4VO2nj0neUMGZbw2lPpofaAjdJNpuOhNqeLKlBpSx2nzglYYlI3ihOVzkJmfQe59AUXCrGZJT4vXCwDSMWvAmpMmP3nEN8N49Y1b6K99U/FwvSJgXhMNFBH+4c6jF35sL9PY5plJ9eGWqKsRm3cxM9tN2o8pVtjk7Z7xHp4OQTUt03BDP1K2T+2NBAQQcnVF+2QNWkPzKzP1VO2LmGyHxEj760Sxzu2KZBeKOHJ7Fp6Pmn51PFkMeQhgPTiKbY+69B32/nS2CcYAP+qS7EyroFBQSxzCD9Aq8oDr61BUV+3CRWWNYRfjrxR4DM3DiAdaSpeg+cvx0lSHZJ/tKMEYK2B4x8dinr94L2IS0hTtsHait/Mh8CQWkw== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(35754003)(13464003)(377454003)(199003)(377424004)(189002)(9686002)(229853002)(6116002)(6506006)(68736007)(54356999)(106356001)(106116001)(105586002)(76176999)(3846002)(2906002)(50986999)(102836003)(8676002)(39450400002)(5660300001)(81156014)(81166006)(33656002)(39410400001)(189998001)(77096006)(4326007)(38730400001)(8936002)(101416001)(7736002)(122556002)(7846002)(74316002)(76576001)(2900100001)(66066001)(305945005)(97736004)(3280700002)(3660700001)(93886004)(92566002)(6916009)(2950100002)(7696004)(86362001)(39840400001)(39850400001)(39860400001)(110136003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR04MB0848; H:DB5PR0401MB1768.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-correlation-id: fe6e1dc8-89ff-41da-6619-08d41e965662 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB4PR04MB0848; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6047074)(6072148); SRVR:DB4PR04MB0848; BCL:0; PCL:0; RULEID:; SRVR:DB4PR04MB0848; x-forefront-prvs: 01494FA7F7 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2016 11:44:00.8268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0848 Subject: Re: [dpdk-dev] [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 11:44:03 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Wednesday, December 07, 2016 2:03 PM To: Akhil Goyal Cc: dev@dpdk.org; declan.doherty@intel.com; pablo.de.lara.guarch@intel.com;= Hemant Agrawal ; Horia Geant=E3 Subject: Re: [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descr= iptor formation 2016-12-07 06:24, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-12-05 18:25, Akhil Goyal: > > FLib is a library which helps in making the descriptors which is=20 > > understood by NXP's SEC hardware. > > This patch provides header files for command words which can be used=20 > > for descritptor formation. >=20 > It seems this code is old. Does it exist as a standalone library somewher= e? [Akhil] Let me correct here. This is not a library. This is a set of header= files. Yes this is an old code. This is generally shipped with NXP SDK. > Where was it hosted before duplicating it in DPDK? [Akhil] This is part of NXP SDK and also available at git.freescale.com. >=20 > Why do you want to have a common directory drivers/common/dpaa2/flib inst= ead of a sub-directory in the crypto driver? [Akhil] I agree with your suggestion. This can be maintained within drivers= /crypto as a common header files set for different NXP Architecture crypto = drivers. >=20 > [Akhil] This is not really a library. This is a set of header files which= is required for compilation. We have 2 other cypto drivers (for different = platforms viz: Non-DPAA and DPAA1_QORIQ) which uses the same flib. So we pu= t it in common directory. We plan to send patches for other drivers in the = upcoming releases.=20 Please Akhil, could you answer to the three questions?