From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40058.outbound.protection.outlook.com [40.107.4.58]) by dpdk.org (Postfix) with ESMTP id 6C35558D8 for ; Fri, 16 Sep 2016 08:15:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=34Bss8Brgv49ihSqBz/Y+FY53GiRro3ac6Hl5pk3mzk=; b=qM/86L7Q9j0Bz1FlU4NDYANIMe3eTzQ4FbM2UkCvhkY1OkoJNQSSuC5ZDPgC8kIn+B+nFGSvOvAzCyxOiNKGMSlfTj0GgdEA9081IuafLFemtTE2vYldOQ71yNHceSCvgcesI/I9chD/ab00z/S8MJv3oDQvlB/zhJYZaXDBOME= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by HE1PR04MB1610.eurprd04.prod.outlook.com (10.164.48.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.2; Fri, 16 Sep 2016 06:15:27 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0639.002; Fri, 16 Sep 2016 06:15:27 +0000 From: Shreyansh Jain To: "Hunt, David" , "dev@dpdk.org" CC: "viktorin@rehivetech.com" , Hemant Agrawal Thread-Topic: [dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL Thread-Index: AQHSCnZNxJZzrlWxxE6uHFQuEInTR6B6jCSAgAEhYsA= Date: Fri, 16 Sep 2016 06:14:58 +0000 Deferred-Delivery: Fri, 16 Sep 2016 06:14:21 +0000 Message-ID: References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com> <1473410639-10367-1-git-send-email-shreyansh.jain@nxp.com> <48c575c5-c876-7a83-4016-f90779144a65@intel.com> In-Reply-To: <48c575c5-c876-7a83-4016-f90779144a65@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: cd519f75-e6aa-4ecf-0d63-08d3ddf8da38 x-microsoft-exchange-diagnostics: 1; HE1PR04MB1610; 6:A4OcA6K4m2SKyKSgduNMTTXJypoUS4f6l7+oG/BmlpLIQcJX/JRo7ftLxp5QeqxKkLoRdwuv1TTQkRGvojft+H1ifXQxRnzbiYPN8IFeVQdaqBfoqlMWUK3a9a9ls0lCqlE8JyDjueDTwPfvkxnK2CBTpno2gCUSzehXyzYGYGft6ROp5uNtrzh84opPi63FRXsPEBLp0D3o6mP7zjz75vc8jPA0kJL9klM5Jqfwjl7+UWOVQ8SN2zQ5ca6eWJAhMDGoCTxLiNZt6DpTS6WN9l6Rt2o8yxE//fh8LoL4GGR1sMtHYAbDA1kUpcfidBjbK9IPp5zA85/mcv7Ioe573A==; 5:IRlCXXHXrFkuYU+22F7N+d0xuP04Lql6P8wPEFhxCkjxgmMQ5ne8HabM7xIPk1Cz9XTF08ilC7npV7NumBp05yACqQR5pzS6SiMquo9ZLMQOy5L8MnprGuskWlEFb/AcWcXoiSrVJ2xVdptR2QtVKw==; 24:ZojWAElMZcclq0h5ReXbrLDqyWhGGRh3IPMKmONmv+BD4K8L2ahZBtscFPwa2uQDzvNzRSKi6EIaRBbOE/SF2n4RybhV04ZEflOmETX/y6c=; 7:QDeo1urln44Xfg0yhqUrJ3WYZant8fJxBPgtScjuN95kQfnrCJpaHG0CuIhTgOigAPTFKsIoAXD4uB2OQFo/wThSZ4+34KRrris/D/CYYROa4Z6jRnA8w5Ngl+MgKZWaCt8y+SthBbhxxWnNlALmZDmby6HmlqcYj/8Ir7xE8c2OJ5i9tHKb6B4qyj6a1h91hwyvoUAc9e9daPmNIyxdfzadCO8boBobLL0hkPAaUWdxMrZytHAVi+9S1Fi/5shN x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1610; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:HE1PR04MB1610; BCL:0; PCL:0; RULEID:; SRVR:HE1PR04MB1610; x-forefront-prvs: 0067A8BA2A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(199003)(69234005)(377454003)(189002)(24454002)(13464003)(9686002)(97736004)(19580405001)(92566002)(5660300001)(68736007)(3846002)(87936001)(33656002)(2906002)(11100500001)(8936002)(6116002)(102836003)(5001770100001)(8676002)(4326007)(586003)(81156014)(81166006)(2501003)(189998001)(76576001)(77096005)(122556002)(106116001)(106356001)(2900100001)(2950100001)(7846002)(7736002)(305945005)(76176999)(10400500002)(54356999)(50986999)(66066001)(105586002)(7696004)(19580395003)(101416001)(3660700001)(3280700002)(5002640100001)(74316002)(86362001)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR04MB1610; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2016 06:15:26.9483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1610 Subject: Re: [dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver framework for EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 06:15:29 -0000 Hi David, > -----Original Message----- > From: Hunt, David [mailto:david.hunt@intel.com] > Sent: Thursday, September 15, 2016 6:26 PM > To: Shreyansh Jain ; dev@dpdk.org > Cc: viktorin@rehivetech.com; Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH v3 00/15] Introduce SoC device/driver > framework for EAL >=20 > Shreyansh, Jan, Hemant, >=20 > On 9/9/2016 9:43 AM, Shreyansh Jain wrote: > > Introduction: > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > This patch set is direct derivative of Jan's original series [1],[2]. > > > > - As this deviates substantially from original series, if need be I c= an > > post it as a separate patch rather than v2. Please suggest. > > - Also, there are comments on original v1 ([4]) which are _not_ > > incorporated in this series as they refer to section no more in new > > version. > > - This v3 version is based on the rte_driver/device patchset v9 [10]. > > That series introduced device structures (rte_driver/rte_device) > > generalizing devices into PCI, VDEV, XXX. For the purpose of this > > patchset, XXX=3D>SOC. > > > > > ---snip--- >=20 > FYI, I've reviewed this patch set, and it looks to me like there's > some very good work here. Each patch in the set builds nicely on the one > before, and logically introduces the changes one by one. Great. Thank you so much for reviewing this series. It would really help us= move it ahead and introduce other series which are based on it. >=20 > I've no functional suggestions as the implementation looks clean, > but I've one or two tiny suggestions on headers and error messages. I'll > add a reply to the relevant patches in the set. I will have a look at those and fix them soon (v4).=20 >=20 > Also, there's one or two issues thrown up by checkpatch, but I suspect > they're false positives, as I'm using the 4.6 kernel version. Thanks for headup - I will see/fix those in v4, if any.=20 >=20 > Regards, > Dave >=20 - Shreyansh