From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by dpdk.org (Postfix) with ESMTP id ED0C3FAD4 for ; Tue, 20 Dec 2016 05:41:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MFBxv3/s7UKfGvaCpt/zuSC7T+cOg+mRBgyRC//Ba60=; b=MvB1Jet7K2CdEt8jdHpKyXxonvdrmOH7AdvbK5jmfyFOc2td2sXHyK+/E/bLTT6sHzAMt0wk1SWg/1CutlAiEcxLiCPqMXppeJfwH9muhjHtO4LdR4p5xIPTQ+JghqJUe/SK5VuFnBefZ+3042T4QmvkMyJF4+gEGXTUsEkweyQ= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by VI1PR04MB1614.eurprd04.prod.outlook.com (10.164.84.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Tue, 20 Dec 2016 04:41:37 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0771.020; Tue, 20 Dec 2016 04:41:36 +0000 From: Shreyansh Jain To: Stephen Hemminger , Hemant Agrawal CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "bruce.richardson@intel.com" , "john.mcnamara@intel.com" , "ferruh.yigit@intel.com" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCHv2 01/34] lib/ether: add rte_device in rte_eth_dev Thread-Index: AQHSWgtzuUv9UEugIUmibUhpMOlGGKEPcoWAgADO6aA= Date: Tue, 20 Dec 2016 04:41:27 +0000 Deferred-Delivery: Tue, 20 Dec 2016 04:41:13 +0000 Message-ID: References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-2-git-send-email-hemant.agrawal@nxp.com> <20161219081651.6482f6b1@xeon-e3> In-Reply-To: <20161219081651.6482f6b1@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [122.177.147.47] x-microsoft-exchange-diagnostics: 1; VI1PR04MB1614; 7:yWfKqUq2fV42wMXNWkVJd6oodexel49GXoUE3AvU5xrw3k1zJ1JPqgVYalBATRBP616jBVaWTiIJRgRde5pKa3HXUUknf36T39mkp/t0N0v5CZByUEYdBnKV0gtOpUKmwmMAFRFgFhJJ6HG/quiX4WvvGA/XESMkULasKZVVHamrTWz3hJ6gNDtW8Y9vdksHF71/COdpLabgB9yKSgiSQo+e7JGn+E0dlmRfh5zJz7/fgatL6chYQVzL/O+jHoC30A3iROnXe3ZArqG9HCncC5W49DI1lmCFR+WtisKU5rktEag3nHXcGZEy4jygGgmcjyZRfHiQiJWQFqiBeIHslVyxLZM8+KXxZABPoNqUdRe9G4+ybGX0X7C6N8ukDoxAxvk8oaJp7+ODVxy6CXM1OHCVd2wgWPiPHn7heTheODYs4XyEi7you2N6SaV8siVp8FCIkxJnPf/C8/FUEcjoLQ== x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39850400002)(39860400002)(39450400003)(39410400002)(39840400002)(24454002)(189002)(13464003)(377454003)(199003)(76576001)(189998001)(305945005)(102836003)(8936002)(5660300001)(74316002)(6636002)(2950100002)(6666003)(4326007)(68736007)(122556002)(2906002)(76176999)(25786008)(106356001)(81166006)(86362001)(106116001)(229853002)(81156014)(77096006)(5001770100001)(2900100001)(38730400001)(97736004)(6506006)(6116002)(101416001)(3846002)(3660700001)(6436002)(33656002)(54356999)(9686002)(7736002)(66066001)(92566002)(93886004)(7696004)(105586002)(3280700002)(50986999)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1614; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: 5bd42597-578f-416d-4459-08d428927b38 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR04MB1614; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(788757137089)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148)(6047074); SRVR:VI1PR04MB1614; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1614; x-forefront-prvs: 0162ACCC24 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2016 04:41:36.2222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1614 Subject: Re: [dpdk-dev] [PATCHv2 01/34] lib/ether: add rte_device in rte_eth_dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 04:41:40 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, December 19, 2016 9:47 PM > To: Hemant Agrawal > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; bruce.richardson@intel.com; > Shreyansh Jain ; john.mcnamara@intel.com; > ferruh.yigit@intel.com; jerin.jacob@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCHv2 01/34] lib/ether: add rte_device in > rte_eth_dev >=20 > On Tue, 20 Dec 2016 02:23:40 +0530 > Hemant Agrawal wrote: >=20 > > Signed-off-by: Hemant Agrawal > > --- > > lib/librte_ether/rte_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethde= v.h > > index 9678179..0b601e9 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -1626,6 +1626,7 @@ struct rte_eth_dev { > > eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. */ > > eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. *= / > > struct rte_eth_dev_data *data; /**< Pointer to device data */ > > + struct rte_device *device; > > const struct eth_driver *driver;/**< Driver for this device */ > > const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ > > struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ >=20 > NAK > I would rather that rte_pci_device be eliminated from rte_eth_dev_data an= d > replace by more generic rte_device. I am working on a patch set to do thi= s, > it is not fundamentally hard. That's interesting. I am already working on it (removing pci_dev from rte_e= th_dev and pci_drv from eth_driver). Anyways, I will focus on something dif= ferent if you are already working on it. (Do let me know if you are working on eth_driver change as well - replacing= rte_pci_driver with rte_driver or complete removal of eth_driver all toget= her as discussed on ML). - Shreyansh