From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shreyansh.jain@nxp.com> Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30041.outbound.protection.outlook.com [40.107.3.41]) by dpdk.org (Postfix) with ESMTP id 65A952BB1 for <dev@dpdk.org>; Wed, 19 Oct 2016 13:14:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KzH7lj2rIe42JIXWw7TE0AToxyXcIeGBRqGwjil5dDY=; b=hYSRE6R1mHUfS/1X7rEvxsFXxUc5xArAXYZNS99ZEokmFZ2+mo8yNY/H+tkp4iL/eCLqTojCLyypGUPC6HoUoVlj2OMzpaQtgSB2p0pLsRly6Vyd4mWxjtlT+eWBurSkVueRaGuvUu23deV2iUQXOkBPTcIcDnteXeRxIKgn3Ho= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by HE1PR04MB1611.eurprd04.prod.outlook.com (10.164.48.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.8; Wed, 19 Oct 2016 11:13:58 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0669.018; Wed, 19 Oct 2016 11:13:58 +0000 From: Shreyansh Jain <shreyansh.jain@nxp.com> To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "viktorin@rehivetech.com" <viktorin@rehivetech.com>, David Marchand <david.marchand@6wind.com>, "Hemant Agrawal" <hemant.agrawal@nxp.com> Thread-Topic: [dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization Thread-Index: AQHSEzxMPRkfkXdASkeGCCfzFTmFBKCW3jeAgAEg/xSAFNM1ToAAO9+QgAENxICAAbCNEA== Date: Wed, 19 Oct 2016 11:13:42 +0000 Deferred-Delivery: Wed, 19 Oct 2016 11:13:16 +0000 Message-ID: <DB5PR0401MB2054433AEC6605C6A367F50A90D20@DB5PR0401MB2054.eurprd04.prod.outlook.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <3582057.BR181DtlIn@xps13> <629b0e70-5bd1-d376-4fb9-e7c7a102d79f@nxp.com> <1978706.bfODzZLsTC@xps13> <de7b3b3b-7a29-f2a8-bc56-df4e4ec0717d@nxp.com> <1e1ac980-d857-877b-d629-8a6e9fd0a4c1@intel.com> <DB5PR0401MB20542677779F3ACDA49F07D990D00@DB5PR0401MB2054.eurprd04.prod.outlook.com> <197a12fd-863a-b79a-f4b4-738636da7625@intel.com> In-Reply-To: <197a12fd-863a-b79a-f4b4-738636da7625@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 29eb8b0b-1e61-4f5b-97c6-08d3f81105f6 x-microsoft-exchange-diagnostics: 1; HE1PR04MB1611; 7:Zw7D7RfQ0az8HgcuAheaYwm6v1e8e86LVLLeVY76yEpCs2CmoLNaldOqV43FiJyz8gyrXMC925Ru7rp8WqazWHP5t2CCF3geXZSr9NQ8s8+CKhO+ryIStZb5rtzG/MG6A+HKbt27hV3UqplEZ+bggje3pRdIOOCNJ4o4KWPJobkbwR3K034E32vpUNryPomjUq1Aphx4HZSFQRzIM10B1zRjAkWQsREDWcGy1pspj1F4LvCr/XlUvcGP1IGQFG0zV87cAXL+nCdCpcGOtXWm1sdKKdz6vyGdqpE32kx7PUdzSKyd1R9EEAIwuZc5GuBGEDPE++HFTA6EWq+n1xgyObOS3LjrWHOGBmBtUpO+lU8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1611; x-microsoft-antispam-prvs: <HE1PR04MB1611F3E9EE0A402789BFDB8290D20@HE1PR04MB1611.eurprd04.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(278428928389397)(185117386973197)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:HE1PR04MB1611; BCL:0; PCL:0; RULEID:; SRVR:HE1PR04MB1611; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(24454002)(189002)(199003)(13464003)(377424004)(377454003)(5660300001)(5002640100001)(7696004)(66066001)(8936002)(2900100001)(33656002)(189998001)(19580405001)(15395725005)(15975445007)(7736002)(76176999)(81166006)(7846002)(50986999)(74316002)(122556002)(8676002)(92566002)(2906002)(81156014)(102836003)(2950100002)(77096005)(6666003)(93886004)(87936001)(6116002)(5001770100001)(4326007)(9686002)(305945005)(101416001)(19580395003)(586003)(76576001)(3660700001)(106116001)(3280700002)(106356001)(3846002)(19273905006)(97736004)(68736007)(54356999)(105586002)(11100500001)(86362001)(10400500002)(563064011); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR04MB1611; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2016 11:13:58.5809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1611 Subject: Re: [dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 19 Oct 2016 11:14:02 -0000 Hi Ferruh, > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Tuesday, October 18, 2016 2:53 PM > To: Shreyansh Jain <shreyansh.jain@nxp.com>; Thomas Monjalon > <thomas.monjalon@6wind.com> > Cc: dev@dpdk.org; viktorin@rehivetech.com; David Marchand > <david.marchand@6wind.com>; Hemant Agrawal <hemant.agrawal@nxp.com> > Subject: Re: [dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_devi= ce > generalization >=20 > On 10/17/2016 6:29 PM, Shreyansh Jain wrote: > > Hi Ferruh, > > > >> -----Original Message----- > >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > >> Sent: Monday, October 17, 2016 7:13 PM > >> To: Shreyansh Jain <shreyansh.jain@nxp.com>; Thomas Monjalon > >> <thomas.monjalon@6wind.com> > >> Cc: dev@dpdk.org; viktorin@rehivetech.com; David Marchand > >> <david.marchand@6wind.com>; Hemant Agrawal <hemant.agrawal@nxp.com> > >> Subject: Re: [dpdk-dev] [PATCH v11 00/24] Introducing > rte_driver/rte_device > >> generalization > >> > >> On 10/5/2016 12:57 PM, Shreyansh Jain wrote: > >>> Hi Thomas, > >>> > >>> On Tuesday 04 October 2016 01:12 PM, Thomas Monjalon wrote: > >>>> 2016-10-04 12:21, Shreyansh Jain: > >>>>> Hi Thomas, > >>>>> > >>>>> On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote: > >>>>>> Applied, thanks everybody for the great (re)work! > >>>>> > >>>>> Thanks! > >>>>> > >>> [...] > >>> [...] > >>>>> > >>>>> It can be merged with changes for: > >>>>> - drv_name > >>>>> - EAL_ before _REGISTER_ macros > >>>>> - eth_driver =3D> rte_driver naming > >>>> > >>>> Good. > >>>> Could you make it this week, please? > >>>> > >>> > >>> Certainly. At least some of those I can send within this week :) > >>> > >> > >> > >> I caught while running ABI validation script today, I think this patch > >> should increase LIBABIVER of: > >> - lib/librte_cryptodev > >> - lib/librte_eal > >> - lib/librte_ether > > > > Should I be referring to [1] for understanding how/when to change the > LIBABIVER? > > > > [1] http://dpdk.org/doc/guides/contributing/versioning.html >=20 > Yes, this is the document. >=20 > Briefly, if library becomes incompatible with existing applications, > LIBABIVER needs to be increased to indicate this. >=20 > Increasing LIBABIVER changes dynamic library name and so_name, and this > cause existing application do not work with this new library. Not > increasing the LIBABIVER, app may start running but can have segfault or > can generate wrong values. So increasing LIBABIVER is to inform user and > prevent surprises. Thanks for explanation. I understand. I will send across another patch for this. - Shreyansh