From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
(mail-db5eur01on0088.outbound.protection.outlook.com [104.47.2.88])
by dpdk.org (Postfix) with ESMTP id 56991106A
for <dev@dpdk.org>; Fri, 9 Dec 2016 06:00:02 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=VQaWpO+jGmWC11mmKugd7y0y2kGs9x6lWFQaTzp+1x4=;
b=sKmGatsXJzcOBBfoRBjRcBhcr9odRgoSfoG2wxMRHq3by8HP5qIIINuyvOhWjPackMSLAImngFOgfmJwGKbrsYJmuXkgT7G22ovy3OnceaYL+Ev4XKvEJLmaUk/x7RwPksY1t86tP3//1LgvGz39Tym0HXsERyWSVAcnCtNF8k8=
Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by
DB5PR0401MB2056.eurprd04.prod.outlook.com (10.166.11.139) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
15.1.761.9; Fri, 9 Dec 2016 05:00:00 +0000
Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by
DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with
mapi id 15.01.0761.018; Fri, 9 Dec 2016 05:00:00 +0000
From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"david.marchand@6wind.com" <david.marchand@6wind.com>, Adrien Mazarguil
<adrien.mazarguil@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 07/13] pci: replace probe and remove handlers
with rte_driver
Thread-Index: AQHSThZ7yWljXOtGHE6B+AN8DrrsbqD+WvQAgAC6B2A=
Date: Fri, 9 Dec 2016 04:59:40 +0000
Deferred-Delivery: Fri, 9 Dec 2016 04:59:22 +0000
Message-ID: <DB5PR0401MB20544947AEF52C6F20532B8290870@DB5PR0401MB2054.eurprd04.prod.outlook.com>
References: <1480846288-2517-1-git-send-email-shreyansh.jain@nxp.com>
<1480846288-2517-8-git-send-email-shreyansh.jain@nxp.com>
<74db5496-6348-1f18-d4b8-457260cd6e97@intel.com>
In-Reply-To: <74db5496-6348-1f18-d4b8-457260cd6e97@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is )
smtp.mailfrom=shreyansh.jain@nxp.com;
x-originating-ip: [192.88.169.1]
x-ms-office365-filtering-correlation-id: 9fd99fb1-8b80-4333-870b-08d41ff03af0
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001);
SRVR:DB5PR0401MB2056;
x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2056;
7:QuXK0YAwLuGzgyW5AwOlqkNJROVbvfOkPqM5+xXPFZSvHVX+H6goMpwzlPS3U0pzfhJFCbbphm5WvyzQxHoSZebsFFHekjjwtnrd9OfImJ8npVk8OyS5G9ttaFNdQ2s/M40syG3eiEqJAzTY04OLnfyskGuDv4olrx9Vzpb02eTGI4ITQHqYCQ1qBasyva3I0bw7HDHIyK1E+pTpju0Ex8FD4fTznFgtii1qMTuoV+17p4Ng4KdBYfG3Dwtf8YmFElamkWwAiLLOR8gkEt+tBofMzFjLHUCWe56b0xlVoVdqwbWlp0+dyMYvmabQIW4Lb/oJJ70VLd5BV2s0bugXZr0qNX8fkfDIIi2DvMTqA4wyMWhsBSHNZhxn7X/wSCBu1gk6CJP9zMqVnjAf5BvdIFP5K/Tv7Wxtzri0avKfBM756H+7Ix4zzesTVXkfqmJzXgc9QojUvYUzbmN3lk8C7Q==
x-microsoft-antispam-prvs: <DB5PR0401MB20569BCB86E0EEFBCC91432590870@DB5PR0401MB2056.eurprd04.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(185117386973197)(788757137089)(228905959029699);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6072148)(6047074);
SRVR:DB5PR0401MB2056; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2056;
x-forefront-prvs: 015114592F
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(6009001)(7916002)(39850400002)(39840400002)(39860400002)(39450400003)(39410400002)(189002)(377454003)(199003)(24454002)(13464003)(97736004)(5001770100001)(76176999)(106116001)(77096006)(229853002)(101416001)(6506006)(54356999)(122556002)(189998001)(38730400001)(50986999)(105586002)(66066001)(92566002)(106356001)(2900100001)(76576001)(3660700001)(74316002)(2501003)(3846002)(102836003)(6116002)(33656002)(3280700002)(81156014)(9686002)(7696004)(5660300001)(305945005)(68736007)(6666003)(8676002)(81166006)(2906002)(7736002)(2950100002)(86362001)(6436002)(4326007)(8936002);
DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2056;
H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords;
MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: nxp.com does not designate
permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2016 05:00:00.5895 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2056
Subject: Re: [dpdk-dev] [PATCH 07/13] pci: replace probe and remove handlers
with rte_driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Dec 2016 05:00:02 -0000
Hello Ferruh,
As always, thanks for your checks.
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, December 08, 2016 11:21 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; david.marchand@6wind.com; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>
> Subject: Re: [dpdk-dev] [PATCH 07/13] pci: replace probe and remove handl=
ers
> with rte_driver
>=20
> Hi Shreyansh,
>=20
> On 12/4/2016 10:11 AM, Shreyansh Jain wrote:
> > rte_pci_driver probe/remove callback are replaced with the rte_driver
> > based probe/remove. This patch changes all the PCI drivers which refere=
nce
> > rte_pci_driver->probe/remove.
> >
> > rte_pci_driver continues to have probe/remove callback which would be u=
sed
> > once eth_driver is removed in later patches.
> >
> > Only changes to PCI are done. VDEV changes require a different
> > model because of arguments being passed to vdev->probe/remove.
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > ---
> > drivers/net/bnx2x/bnx2x_ethdev.c | 12 ++++++++----
> > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++--
> > drivers/net/cxgbe/cxgbe_ethdev.c | 6 ++++--
> > drivers/net/e1000/em_ethdev.c | 6 ++++--
> > drivers/net/e1000/igb_ethdev.c | 12 ++++++++----
> > drivers/net/ena/ena_ethdev.c | 6 ++++--
> > drivers/net/enic/enic_ethdev.c | 6 ++++--
> > drivers/net/fm10k/fm10k_ethdev.c | 6 ++++--
> > drivers/net/i40e/i40e_ethdev.c | 6 ++++--
> > drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++--
> > drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++++++++----
> > drivers/net/mlx4/mlx4.c | 6 ++++--
>=20
> Generating compile error:
> .../net/mlx4/mlx4.c:5913:13: error: subobject initialization overrides
> initialization of other fields within its enclosing subobject
> [-Werror,-Winitializer-overrides]
> .driver =3D {
> ^
> .../net/mlx4/mlx4.c:5909:13: note: previous initialization is here
> .driver =3D {
> ^
>=20
>=20
> > drivers/net/mlx5/mlx5.c | 4 +++-
>=20
> .../net/mlx5/mlx5.c:736:13: error: subobject initialization overrides
> initialization of other fields within its enclosing subobject
> [-Werror,-Winitializer-overrides]
> .driver =3D {
> ^
> .../net/mlx5/mlx5.c:732:13: note: previous initialization is here
> .driver =3D {
> ^
>=20
Yes, David Marchand also highlighted this another comment. Somehow I messed=
up the MLX changes. And just like the last time, I forgot to change my env=
ironment configuration to enable it before sending the patches.
=20
>=20
> > drivers/net/nfp/nfp_net.c | 6 ++++--
> > drivers/net/qede/qede_ethdev.c | 16 ++++++++++------
> > drivers/net/szedata2/rte_eth_szedata2.c | 6 ++++--
> > drivers/net/virtio/virtio_ethdev.c | 4 ++--
> > drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++--
>=20
> Following drivers seems missing:
> drivers/net/thunderx/nicvf_ethdev.c
I will fix this as well in v2.=20
>=20
> Also new added drivers/net/sfc/sfc_ethdev.c, but since sfc is not merged
> to main branch yet, perhaps fix may wait your patches to be applied first=
.
>=20
> > lib/librte_eal/common/eal_common_pci.c | 10 ++++++++--
> > lib/librte_eal/common/include/rte_dev.h | 12 ++++++++++++
> > lib/librte_ether/rte_ethdev.c | 16 ++++++++++++----
> > lib/librte_ether/rte_ethdev.h | 6 +++---
> > 22 files changed, 122 insertions(+), 54 deletions(-)
> >
>=20
> Also getting following with mlx5:
>=20
> In file included from
> .../x86_64-native-linuxapp-gcc/include/rte_mbuf.h:57:0,
> from .../x86_64-native-linuxapp-gcc/include/rte_ether.h:=
52,
> from .../drivers/net/mlx5/mlx5_trigger.c:38:
> /usr/include/infiniband/verbs.h: In function 'verbs_get_device':
> .../x86_64-native-linuxapp-gcc/include/rte_common.h:350:40: error:
> initialization discards 'const' qualifier from pointer target type
> [-Werror=3Ddiscarded-qualifiers]
> typeof(((type *)0)->member) *_ptr =3D (ptr); \
>=20
>=20
> <...>
I will check MLX* again.
Thanks for your inputs.
-
Shreyansh