From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0064.outbound.protection.outlook.com [157.56.112.64]) by dpdk.org (Postfix) with ESMTP id BC3AFC458 for ; Thu, 16 Jun 2016 08:32:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5xdZfjnrsx9HkN7xu7R8Wfl2rF9lHQTUdVc/e6rH4Jw=; b=Jx8sL088KTuUHDLwfwWj1laYVgEczB3tKPjf3pq6ih5d6phI7iP0A/6G5NDTDR2lIfZWRUp99TGoSE22B1WqSJQP55ePtZk4jKglz+0fkAIfEhz82Kwjse+nevzIEQ+PpD7SrYiepS1bPcv9dfq+2qGxByFLl18N0vcudoWveDI= Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com (10.166.11.137) by DB5PR0401MB2053.eurprd04.prod.outlook.com (10.166.11.136) with Microsoft SMTP Server (TLS) id 15.1.517.8; Thu, 16 Jun 2016 06:32:52 +0000 Received: from DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) by DB5PR0401MB2054.eurprd04.prod.outlook.com ([10.166.11.137]) with mapi id 15.01.0517.014; Thu, 16 Jun 2016 06:32:53 +0000 From: Shreyansh Jain To: David Marchand CC: "thomas.monjalon@6wind.com" , "viktorin@rehivetech.com" , "dev@dpdk.org" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver Thread-Index: AQHRmvoLG6QTjDF9VkSwV+mL7okW6p/MzU3wgB8uKqA= Date: Thu, 16 Jun 2016 06:32:29 +0000 Deferred-Delivery: Thu, 16 Jun 2016 06:32:26 +0000 Message-ID: References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1461152657-19969-1-git-send-email-david.marchand@6wind.com> <8CEF83825BEC744B83065625E567D7C21A010557@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A010557@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: d7a2e8d7-e6ea-4f18-5f7a-08d395b00b8e x-microsoft-exchange-diagnostics: 1; DB5PR0401MB2053; 6:Q7YH8DPO1oumHZCyVxl+W+1sgDBuAzcF8k1ys1849y8r512RUM+spwJd6M1eYa8bO+of8oe9DXK85I4SfWuBFhpkNDphnc1Dn9jxn9P6+O4RWxXejwAzcvkRNFOKjSVul5LJXK25W9/VwqdrCt/Sc/CaaBVgJFCE+ZQodUpHJR4myWwF0F6zgXYQhhLSCObBsQu/fTF5edYp+RA5dm057Y3ADFAUxVP1pXr8z8fsDKA7bkWLkcQuBqevQLBrgXiDz+YL+h0UbpGuaz/DXkIVovOUmY5ZoSWYnsVAwVGbe9p0QDD0Za4bTMLvFU8yHzv1; 5:zjFV758ClENOK4UiwLdh38hUR4IbacGAGc7i4OEm766KDFEQVPO7Vv5hYAd/0shanRKSliIyRIyoTo86ZRKfUAgxuzjlIGeUUo9JHRNtcGRAfGGtn7dgzxiffZDu4mdyI4GABvXk+I87Q5VxIyW2jQ==; 24:UiM+ROqGO/IE1JRy4izkN5+QRbR0gI/jx7j1QbDoZ730Pn0rrQ0hjhSV5raexFl5cP78PuJb1AgHYOhMXu4MqH+v0j3p3sD89X2X/0lDrxw=; 7:0ISt+sMXUtRYqdoPz2tB8Bvv8l726vTdCF4BG02iBuS7GRK6wx7ED6qwR36ceLaSWDJG/ze5ROeK1j/qeyeSBNhLbQ8YYJ4uOTd0xWXAlY/9s4d/vFF4mMO0KsK8DBXb5lEwEbiTvHMj0Q5vEjfVS+dW3A6p38kEI3lxJlyX2uNPG7+nwJFoSdgk9x39IN3tlbGL5MxykqR5gxX3l0B8jg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB2053; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(244540007438412); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:DB5PR0401MB2053; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB2053; x-forefront-prvs: 09752BC779 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(189002)(199003)(51694002)(13464003)(101416001)(2900100001)(81156014)(2950100001)(3280700002)(10400500002)(8936002)(81166006)(8676002)(2906002)(5004730100002)(15975445007)(77096005)(4326007)(5008740100001)(102836003)(68736007)(33656002)(87936001)(97736004)(3846002)(19580405001)(74316001)(19580395003)(586003)(5003600100002)(106356001)(50986999)(76176999)(54356999)(122556002)(189998001)(106116001)(76576001)(105586002)(86362001)(3660700001)(5890100001)(15395725005)(6116002)(92566002)(9686002)(5002640100001)(110136002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB2053; H:DB5PR0401MB2054.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; CAT:NONE; LANG:en; CAT:NONE; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2016 06:32:52.8473 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB2053 Subject: Re: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 06:32:55 -0000 Hi David, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Friday, May 27, 2016 3:54 PM > To: David Marchand ; dev@dpdk.org > Cc: thomas.monjalon@6wind.com; viktorin@rehivetech.com > Subject: Re: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_dri= ver >=20 > Hi David, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > > Sent: Wednesday, April 20, 2016 12:44 PM > > To: dev@dpdk.org > > Cc: thomas.monjalon@6wind.com; viktorin@rehivetech.com > > Subject: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_drive= r > > > > Following discussions with Jan [1] and some cleanup I started on pci co= de, > > here is a patchset that reworks pdev drivers registration and hotplug a= pi. > > > > The structures changes mentioned in [1] are still to be done, but at le= ast, > I > > think we are one step closer to it. > > > > Before this patchset, rte_driver .init semantics differed whether it > concerned > > a pdev or a vdev driver: > > - for vdev, it actually meant that a devargs is given to the driver so > > that it creates ethdev / crypto objects, so it was a probing action > > - for pdev, it only registered the driver triggering no ethdev / crypto > > objects > > > > From my pov, eal hotplug api introduced in this patchset still needs mo= re > > work so that it does not need to know about devargs. So a new devargs a= pi > is > > needed. > > > > Changes since v1: > > - rebased on HEAD, new drivers should be okay > > - patches have been split into smaller pieces > > - RTE_INIT macro has been added, but in the end, I am not sure it is us= eful > > - device type has been removed from ethdev, as it was used only by hotp= lug > > - getting rid of pmd type in eal patch (patch 5 of initial series) has = been > > dropped for now, we can do this once vdev drivers have been converted > > > > [1] http://dpdk.org/ml/archives/dev/2016-January/031390.html > > > > Regards, > > -- > > David Marchand > > > > David Marchand (17): > > pci: no need for dynamic tailq init > > crypto: no need for a crypto pmd type > > drivers: align pci driver definitions > > eal: remove duplicate function declaration > > eal: introduce init macros > > crypto: export init/uninit common wrappers for pci drivers > > ethdev: export init/uninit common wrappers for pci drivers > > drivers: convert all pdev drivers as pci drivers > > crypto: get rid of crypto driver register callback > > ethdev: get rid of eth driver register callback > > eal/linux: move back interrupt thread init before setting affinity > > pci: add a helper for device name > > pci: add a helper to update a device > > ethdev: do not scan all pci devices on attach > > eal: add hotplug operations for pci and vdev > > ethdev: convert to eal hotplug > > ethdev: get rid of device type > > > > app/test/virtual_pmd.c | 2 +- > > drivers/crypto/qat/rte_qat_cryptodev.c | 18 +- > > drivers/net/af_packet/rte_eth_af_packet.c | 2 +- > > drivers/net/bnx2x/bnx2x_ethdev.c | 35 +-- > > drivers/net/bonding/rte_eth_bond_api.c | 2 +- > > drivers/net/cxgbe/cxgbe_ethdev.c | 24 +- > > drivers/net/cxgbe/cxgbe_main.c | 2 +- > > drivers/net/e1000/em_ethdev.c | 16 +- > > drivers/net/e1000/igb_ethdev.c | 40 +-- > > drivers/net/ena/ena_ethdev.c | 20 +- > > drivers/net/enic/enic_ethdev.c | 23 +- > > drivers/net/fm10k/fm10k_ethdev.c | 23 +- > > drivers/net/i40e/i40e_ethdev.c | 26 +- > > drivers/net/i40e/i40e_ethdev_vf.c | 25 +- > > drivers/net/ixgbe/ixgbe_ethdev.c | 47 +--- > > drivers/net/mlx4/mlx4.c | 22 +- > > drivers/net/mlx5/mlx5.c | 21 +- > > drivers/net/mpipe/mpipe_tilegx.c | 2 +- > > drivers/net/nfp/nfp_net.c | 23 +- > > drivers/net/null/rte_eth_null.c | 2 +- > > drivers/net/pcap/rte_eth_pcap.c | 2 +- > > drivers/net/ring/rte_eth_ring.c | 2 +- > > drivers/net/szedata2/rte_eth_szedata2.c | 25 +- > > drivers/net/vhost/rte_eth_vhost.c | 2 +- > > drivers/net/virtio/virtio_ethdev.c | 26 +- > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 +- > > drivers/net/xenvirt/rte_eth_xenvirt.c | 2 +- > > examples/ip_pipeline/init.c | 22 -- > > lib/librte_cryptodev/rte_cryptodev.c | 67 +---- > > lib/librte_cryptodev/rte_cryptodev.h | 2 - > > lib/librte_cryptodev/rte_cryptodev_pmd.h | 45 +--- > > lib/librte_cryptodev/rte_cryptodev_version.map | 9 +- > > lib/librte_eal/bsdapp/eal/eal_pci.c | 52 +++- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 8 + > > lib/librte_eal/common/eal_common_dev.c | 39 +++ > > lib/librte_eal/common/eal_common_pci.c | 17 +- > > lib/librte_eal/common/eal_private.h | 20 +- > > lib/librte_eal/common/include/rte_dev.h | 29 ++- > > lib/librte_eal/common/include/rte_eal.h | 3 + > > lib/librte_eal/common/include/rte_pci.h | 32 +++ > > lib/librte_eal/common/include/rte_tailq.h | 4 +- > > lib/librte_eal/linuxapp/eal/eal.c | 7 +- > > lib/librte_eal/linuxapp/eal/eal_pci.c | 16 +- > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 8 + > > lib/librte_ether/rte_ethdev.c | 316 ++++------------= ---- > ---- > > lib/librte_ether/rte_ethdev.h | 40 ++- > > lib/librte_ether/rte_ether_version.map | 9 +- > > 47 files changed, 392 insertions(+), 810 deletions(-) > > > > -- > > 1.9.1 >=20 > Patches 3,8,16 and 17 no longer apply to the latest master branch. > A rebase is needed. >=20 [...] With the recent most head (04920e6): 01, 03, 08, 15, 16 and 17 are failing. Just wanted to check if there is a rebase of this series anytime soon? I was looking at Jan's non-PCI patchset [1] and they are based on this seri= es. [1] http://thread.gmane.org/gmane.comp.networking.dpdk.devel/30913/focus=3D= 38486 - Shreyansh