From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10071.outbound.protection.outlook.com [40.107.1.71]) by dpdk.org (Postfix) with ESMTP id 246011B6C8 for ; Wed, 10 Oct 2018 16:39:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o8nKsNlCRRlZjqG2P/aCrco2PfyvNUllF854nTEbA58=; b=G1+FhqhTE93ke7zy/47i1oE90L6i7W/b05KrnCqZ3LYv3k++ODs9cWYA7LoXNqCCZWPWFHLaSq+JHIM3otTlLDTlKGn3hhlEe6oS7kFPiKCWdxrbfs9scsuAP+4sD034f7F1pp3OOse39Lclsg7m+SxWLZcQ1nunXiQ6gNx7q1g= Received: from DB5PR05MB1254.eurprd05.prod.outlook.com (10.162.157.140) by DB5PR05MB1381.eurprd05.prod.outlook.com (10.162.157.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.23; Wed, 10 Oct 2018 14:39:46 +0000 Received: from DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5]) by DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::3516:b329:5c35:51a5%2]) with mapi id 15.20.1207.029; Wed, 10 Oct 2018 14:39:46 +0000 From: Raslan Darawsheh To: "Wiles, Keith" CC: Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , Ori Kam , "Yigit, Ferruh" Thread-Topic: [PATCH v5 3/3] net/tap: add queues when attaching from secondary process Thread-Index: AQHUYGdVjg5G5Plj80K1ylRergQzaqUYbhYAgAAfL8A= Date: Wed, 10 Oct 2018 14:39:46 +0000 Message-ID: References: <1539154988-20652-1-git-send-email-rasland@mellanox.com> <1539154988-20652-3-git-send-email-rasland@mellanox.com> <53E19DB1-1266-4588-8EB2-04062A5DEBB1@intel.com> In-Reply-To: <53E19DB1-1266-4588-8EB2-04062A5DEBB1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR05MB1381; 6:fCHfcp4/QHd9hoJ/FPRj/B+1LAdYk9i7nF7+3qOnHb/I36DrAjKUVsNVEpozU8oJZe+IeMy85VH8zvz9BYYpKOeYkR+FbR9GsPY1pSlKZKJ5D0m4oMkpGZUSKXndOnJ2VbhoepO/Jcnc9xpkTdyUCiC6Kd+RLihnMRUT7r8n9wTT2jwST1Kg4xiS8hZooCjlNkYIpmtapHRFacRzI3WiJIq5H/PQWDmrbW5k5nuPhL6lSAx8/bzdeY9C5pUmR6klP9dgk6PsV1a1MRn98k3ETiiI03TXN9QpL4RSlcsxw/u+kfCpJrlvjqZpOB0jFBJSxG8iV3lJOYYbzSFAbYiWe/DHqgLMC+UMuccF5IDHQ1UGBeNmwe+oUiXedFGOBavvIE6Yn6KjWEa0gLL20rs2u5TKn7wf7QQhL2ZvLXP8dhcrUCdimdFyAecOwEReLfG6n1IXFcRxRn0UkDaP6xJsAA==; 5:XidzSH29EGNGjuC5PGEZq3vBXzJzuhfPE/nZA8FoKIg8H3ABdCuWEnUudtOw9eKiiWzB9EA71Gel7hK6tDcogE0JLuz9NS6Bf2qPs8+d8p5BofeQ4VoFPXccES3LYR5hpDpnupKzoI46UE/Y7k1eiRW9RpBYP9voY6HMS+PKFkg=; 7:DTpbKgWKJtBXxc4Kj+bOGtLUvfzSBp4HLmMGezbxmsRbjr0zCLGpiMPbiGzvIGEiKhW/Lki282mORX2Cg596MgRv/zJOMkq/zYITxqnHalVok67bMncBGnTbD8d2UbYkfv8q++Z9goKxCCMKEGZpAtwUAZ+y7r80pbQDwRM81b8YpgcDVt1CXGaX5doEGT/HBr/1n44TMw7NGOjxWmiMLjKnR/W5UPc7sf1OVaooEr/QVm5N2JGBKd5cXNGImpdJ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 021f471c-e689-4fc4-5ddd-08d62ebe39aa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB5PR05MB1381; x-ms-traffictypediagnostic: DB5PR05MB1381: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(45079756050767)(189930954265078)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(4982022)(52105095)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051); SRVR:DB5PR05MB1381; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1381; x-forefront-prvs: 08213D42D3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(39860400002)(346002)(136003)(199004)(189003)(13464003)(14444005)(5024004)(446003)(478600001)(99286004)(4326008)(6306002)(76176011)(2900100001)(68736007)(53546011)(256004)(6246003)(9686003)(6506007)(7736002)(53936002)(5250100002)(74316002)(6436002)(54906003)(26005)(476003)(7696005)(25786009)(11346002)(97736004)(45080400002)(186003)(486006)(102836004)(305945005)(229853002)(55016002)(5660300001)(66066001)(6916009)(8676002)(105586002)(86362001)(106356001)(966005)(81166006)(8936002)(2906002)(14454004)(3846002)(6116002)(316002)(71200400001)(71190400001)(33656002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1381; H:DB5PR05MB1254.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ItaGChsRdT/IlW6s0ZgRbypwh0+eU7gl232mg1Yb53Cx3oT/onGAcfbm4HR1HvxUXgROwqAZgdZgdoBTeO0Jk/THQrlNua/+lH60a0jIyR/isNIP9m0SRglZm75UhhkPmg4kZTiVEearOwQGYzpmz1k486s0dQvCdjWJhfbsXwPH0urdX6BeZV0X/jIOKLS98qrAwtgTjWu4SidIe6J4zKJXrhsz9M6W1lWV86zlO4r3E/eA8HOe2siDHhnkJiUpJYwmteGT12UkPy7FEgH0mpYQ/ijnIXU7KqZs9p5RZYq6fBc1mu2sor2dRR8ms7EZXC7m5dWA+siFs5CZKO0QzRaORtcZv+tB80QrSaqbNZk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 021f471c-e689-4fc4-5ddd-08d62ebe39aa X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2018 14:39:46.4383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1381 Subject: Re: [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 14:39:49 -0000 Just sent a new Version with the commit log reworded as mentioned.=20 Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Wiles, Keith > Sent: Wednesday, October 10, 2018 3:48 PM > To: Raslan Darawsheh > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler ; Ori Kam ; Yigit, > Ferruh > Subject: Re: [PATCH v5 3/3] net/tap: add queues when attaching from > secondary process >=20 >=20 >=20 > > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh > wrote: > > > > In the case the device is created by the primary process, the > > secondary must request some file descriptors to attach the queues. > > The file descriptors are shared via IPC Unix socket. > > > > Thanks to the IPC synchronization, the secondary process is now able > > to do Rx/Tx on a TAP created by the primary process. > > > > Signed-off-by: Raslan Darawsheh > > Signed-off-by: Thomas Monjalon > > > > --- > > v2: > > - translate file descriptors via IPC API > > - add documentation > > v3: > > - rabse the commit > > - use private static array for fd's to be local for each process > > > > v4: > > - removed TODO and FIXME tags > > - used strlcpy instead of strcpy > > > > v5: rebase the commit on top of Alejandro Lucero patch for secondary > > process private pointer. > > > > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatc > > > hes.dpdk.org%2Fpatch%2F46185%2F&data=3D02%7C01%7Crasland%40me > llanox. > > > com%7Ccfacb17302174d9f4d4608d62eae9952%7Ca652971c7d2e4d9ba6a4d14 > 9256f4 > > > 61b%7C0%7C0%7C636747724769870635&sdata=3Dascg78Cv3PhUY1blcdUi > QHh1mmJ > > JZ2rD5pFUnoEzH9Q%3D&reserved=3D0 > > > Maybe the patch title could be better, >=20 > net/tap: allow secondary process to access primary TAP device queues >=20 > Maybe we can just have the title changed at apply time and not require a > new patch. >=20 > Regards, > Keith