From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30085.outbound.protection.outlook.com [40.107.3.85]) by dpdk.org (Postfix) with ESMTP id 9E17A1B05E for ; Mon, 17 Sep 2018 16:18:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZGoDpVje0Q7ws88PJpBTOFtBZgzS4yrLLRpRUQANBco=; b=oDQ7g4kQLoWNpPVpzUtvO5FiXmmXtEQFMMhWxOTzC7FwGUhEt/UEOgyHLc9AgD+uFPdSBQVBOlizZ/oWFdFtiX+87cPHGV74p+mfdXgaAcGguzvE1hTeQFB6MMVsBb8Cg+teXPSK9y+Ioye4rEONCnarz1obho0/S06FAnb26UY= Received: from DB5PR05MB1254.eurprd05.prod.outlook.com (10.162.157.140) by DB5PR05MB1655.eurprd05.prod.outlook.com (10.165.6.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Mon, 17 Sep 2018 14:18:57 +0000 Received: from DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::4c58:1a64:b828:8737]) by DB5PR05MB1254.eurprd05.prod.outlook.com ([fe80::4c58:1a64:b828:8737%5]) with mapi id 15.20.1143.014; Mon, 17 Sep 2018 14:18:57 +0000 From: Raslan Darawsheh To: Jerin Jacob , David Marchand CC: "Wu, Jingjing" , Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , "Xueming(Steven) Li" Thread-Topic: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets Thread-Index: AQHUSm+G/c/zuZiJU0O/tWWRp0WYpqTubM0AgADogICABThCUA== Date: Mon, 17 Sep 2018 14:18:56 +0000 Message-ID: References: <1536739583-29166-1-git-send-email-rasland@mellanox.com> <1536739583-29166-2-git-send-email-rasland@mellanox.com> <20180914063509.GA8298@jerin> In-Reply-To: <20180914063509.GA8298@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [82.213.2.186] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5PR05MB1655; 6:uCWVmCbfEqW4Ue2/bYpk/kSJ7gFF/R4Jcc+kO0Vy+unzMttbRKuK5XeUXA20j0Cg/W4gGOahopLxCxGaIqTtd+Qa9cic/6kts6HdJJUIq13/SfdhbNefeXZChUo3m4yEWCOCbwBBFRbhQ/UUWtvID4NXjNlGfmljv6RmH/0A7DsJoijNJ0UQxpKYCxlHYS3PThMtMrRj7EiHp39Df04PL82YbaUTrqTVmomoaxdcx/mMLZ/t0sol0nbJNAir3va44RwIvrUGeKbWYAut3vCwphFzyMhjSFSf2fv1Ub9IXv1NUxpxUG0oknWDQH/Sbw87GRjzIyTKPBOj2OArsL0uLgScUpwxIpYM2B9m/XKTYeX89XGDyJY6zTtnUBtOp/G0rw1hzRPv9zGAxXR3QBZhIOMKAjoWgVoBcq2xa7abQ0qaTuPtd3LEyjmapZThJsO+1yrLW/pe/YALcPb+prSQoA==; 5:U+PzE1PKTqtGb0HQJYB+Rcok0U5/6PXj4IA7hRhyNNFNSbxaS9ZsB37u3sRKau4oQ3oqCeA4a6WJao6G7a7OxcYWIuK3LRm3wWrfIjstMptu+eTbY0RhjT0n3wnPGEj3Fniy127W8gJfYYX3tCDeSraBanKjtcFQCYeKlxV/RoE=; 7:91xXC5IJsX6rWd5hGmqv9N0KFhGkubacK7IczZEKWQIp6m6GVUCFBeIECzhjm+e4ZUuYWQeA/vi17FgjcjZQPPKMGLWV4G9BcZHmOVgHW72wZmJxQm5qBjpjt3joexgHKGgwDbfySuj52UorOZ/16pGpUTpgGIXazDLhWdcN/RqpC0nlPCzNvejhXc3oS73iiUCJ5OQHrPpuH5uYs0L7g/XVg/ND0w8p8XSxXyQgNpTB4NJrasBBe1X9W79jdDOn x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: ea67d4d6-cb3e-4b0f-e5d2-08d61ca8816f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB5PR05MB1655; x-ms-traffictypediagnostic: DB5PR05MB1655: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201708071742011)(7699050); SRVR:DB5PR05MB1655; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1655; x-forefront-prvs: 0798146F16 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(136003)(346002)(366004)(13464003)(189003)(199004)(478600001)(7696005)(575784001)(93886005)(2900100001)(6436002)(6306002)(33656002)(9686003)(53936002)(5250100002)(53546011)(102836004)(6506007)(45080400002)(11346002)(6116002)(86362001)(55016002)(3846002)(97736004)(486006)(476003)(26005)(256004)(446003)(99286004)(186003)(76176011)(110136005)(81156014)(81166006)(8676002)(68736007)(8936002)(14454004)(2906002)(25786009)(6246003)(107886003)(54906003)(66066001)(7736002)(966005)(4326008)(305945005)(229853002)(74316002)(106356001)(105586002)(316002)(5660300001)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1655; H:DB5PR05MB1254.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: g3SDi37Mzlk0mEc2H2lvgJqOzPd23ztx3WB48skDRmd5W0MYDqC/bknRW3ixuNDx9n1ndcivfZnEylo7EBaCOTa8XJNuibtLiJghwrZZ7syOZINtLbfbCjuJBAQceT/YfoJXGSOrTJZmjUtvLY2vG2wwgKN2CtGEOwuym97PopDTIeDWLdSzvS+eJKDL9qSKdYrtlRJwxPMY0wRBIneJ2qQsvAqPCoX4q0+GTjXzkhGu904yg/ewkKHIl5t/R49EbFf3IJuFtCdBwy2FMV3wovDDgvdWVaA/bxfpGiQqvAxBBNl9zoROtneCW4j7jHIeO8oi8TKbpr7JUpztrMODYdgztc+RM6ewLPJ0ogQYYuw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea67d4d6-cb3e-4b0f-e5d2-08d61ca8816f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2018 14:18:57.0591 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1655 Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 14:18:58 -0000 Hi David,=20 Thx for this feedback I'll be sending a new version with your suggestion.=20 Kindest regards, Raslan Darawsheh -----Original Message----- From: Jerin Jacob =20 Sent: Friday, September 14, 2018 9:35 AM To: David Marchand Cc: Raslan Darawsheh ; Wu, Jingjing ; Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler = ; Xueming(Steven) Li Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function t= o dump packets -----Original Message----- > Date: Thu, 13 Sep 2018 18:43:02 +0200 > From: David Marchand > To: Raslan Darawsheh > Cc: "Wu, Jingjing" , Thomas Monjalon =20 > , dev@dpdk.org, Shahaf Shuler=20 > , xuemingl@mellanox.com > Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic=20 > function to dump packets >=20 >=20 > On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh = wrote: > > use the generic function to dump packets for several forwarding=20 > > engines. >=20 > Rather than patching some engines, how about putting this in rx/tx callba= cks ? +1 to have zero performance impact on forward engines. > A bit like something I sent earlier ? >=20 > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatc > hes.dpdk.org%2Fpatch%2F44465%2F&data=3D02%7C01%7Crasland%40mellanox. > com%7C9bbd72a1f31b4555b0be08d61a0c4402%7Ca652971c7d2e4d9ba6a4d149256f4 > 61b%7C0%7C0%7C636725037336863883&sdata=3DbWeN5Rsi0vrX5oPZYI5%2FChCZ4 > VogpRAiY6doOkT0Q8s%3D&reserved=3D0 >=20 >=20 > -- > David Marchand