From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 55630A05D3 for ; Thu, 23 May 2019 19:54:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2EEA1B94C; Thu, 23 May 2019 19:54:41 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30072.outbound.protection.outlook.com [40.107.3.72]) by dpdk.org (Postfix) with ESMTP id 44AF81B94B for ; Thu, 23 May 2019 19:54:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CNTaMPUsHAv5mKM/lANBojC1YoPMG3ZG4XHPDErVjCo=; b=KjnmMwey/2i6CcJET35cJzM0/lRraErTkNwESlWkJAOW/2D8MMs7ZJgUD5GC0eIOBTfQ9kL5RvILuQKe/br7n8uZsqEiRnuLRl3tPaWblXNu/4aQS2CY2pN4H1mEdrxQVlfHkruT5KS51hvJbCB6T1F90cRVyTQDmYppHCeYNnA= Received: from DB6PR0501MB2167.eurprd05.prod.outlook.com (10.168.58.144) by DB6PR0501MB2182.eurprd05.prod.outlook.com (10.168.55.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.18; Thu, 23 May 2019 17:54:38 +0000 Received: from DB6PR0501MB2167.eurprd05.prod.outlook.com ([fe80::d1d3:3729:f74d:2f7b]) by DB6PR0501MB2167.eurprd05.prod.outlook.com ([fe80::d1d3:3729:f74d:2f7b%4]) with mapi id 15.20.1922.013; Thu, 23 May 2019 17:54:38 +0000 From: Ali Alnubani To: Bruce Richardson CC: "dev@dpdk.org" , "bluca@debian.org" Thread-Topic: [PATCH 2/2] examples: enable building multiprocess applications Thread-Index: AQHVEXdichc16B2s4UWudh/McCZi76Z41pqAgAAll5A= Date: Thu, 23 May 2019 17:54:38 +0000 Message-ID: References: <20190523145358.1492-1-alialnu@mellanox.com> <20190523145358.1492-2-alialnu@mellanox.com> <20190523153245.GA1388@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190523153245.GA1388@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=alialnu@mellanox.com; x-originating-ip: [178.214.83.145] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd83b2d5-6a6c-4d5d-347f-08d6dfa7b98f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB6PR0501MB2182; x-ms-traffictypediagnostic: DB6PR0501MB2182: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 00462943DE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(39860400002)(136003)(366004)(13464003)(189003)(199004)(53546011)(55016002)(7736002)(74316002)(54906003)(99286004)(305945005)(7696005)(316002)(76176011)(5660300002)(102836004)(186003)(26005)(6506007)(68736007)(52536014)(66946007)(73956011)(64756008)(76116006)(66476007)(66446008)(66556008)(25786009)(6916009)(66066001)(14454004)(486006)(4326008)(478600001)(2906002)(86362001)(6116002)(6246003)(966005)(3846002)(33656002)(8676002)(476003)(8936002)(53936002)(9686003)(6436002)(11346002)(229853002)(446003)(81156014)(81166006)(6306002)(256004)(71190400001)(71200400001)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2182; H:DB6PR0501MB2167.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YiQSbI7czAw7TsgWle5eIj0NdpgKkw6fB2nPAKOzYxKeeNQsIaHei31qJhY7dXqIFww+4cjoczWDEQw471TeADZ8debJFt2UcI3lhBh9oy81vrZasJZyILImzzokDHFO+s1miuN+IoFY6rhC1+Fq1neHfge/czUMBk4JCnodfv8IeFP3UKCWEnmtwXJrMPI2xp9xV5ku7tFlb67rcUVrxU6Fjay6a4Ho7B7VjV6f1dNkWCXXy3TlnkyAirehbhOXOBzxvRnhFSyXriD+ZnytJA/U4Yt8TE56gwrSnolPCfjl5ej1TmpKfgRsmE7+YbT0B5dyF2d4hhRjrJykUdTJT3wXV+bKvx3i/4M9sa9vJNR9/f2wvVMeatKrBEHuGYV03bmQfqPN9+RC+hBxeE8WYEir35ACUeoPORQ49/wMZs0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd83b2d5-6a6c-4d5d-347f-08d6dfa7b98f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2019 17:54:38.3795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: alialnu@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2182 Subject: Re: [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, Comments are inline. > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, May 23, 2019 6:33 PM > To: Ali Alnubani > Cc: dev@dpdk.org; bluca@debian.org > Subject: Re: [PATCH 2/2] examples: enable building multiprocess applicati= ons >=20 > On Thu, May 23, 2019 at 02:54:13PM +0000, Ali Alnubani wrote: > > This enables building the example multiprocess applications in the > > subdirectory multi_process. > > > > Signed-off-by: Ali Alnubani > > --- > > examples/meson.build | 8 +++++++- > > .../client_server_mp/mp_client/meson.build | 14 ++++++++++++++ > > .../client_server_mp/mp_server/meson.build | 14 ++++++++++++++ > > examples/multi_process/hotplug_mp/meson.build | 12 ++++++++++++ > > examples/multi_process/simple_mp/meson.build | 12 ++++++++++++ > > .../multi_process/{ =3D> symmetric_mp}/meson.build | 8 +++++--- > > 6 files changed, 64 insertions(+), 4 deletions(-) create mode 100644 > > examples/multi_process/client_server_mp/mp_client/meson.build > > create mode 100644 > > examples/multi_process/client_server_mp/mp_server/meson.build > > create mode 100644 examples/multi_process/hotplug_mp/meson.build > > create mode 100644 examples/multi_process/simple_mp/meson.build > > rename examples/multi_process/{ =3D> symmetric_mp}/meson.build (68%) > > > > diff --git a/examples/meson.build b/examples/meson.build index > > 53a786eb4..647114c23 100644 > > --- a/examples/meson.build > > +++ b/examples/meson.build > > @@ -24,7 +24,7 @@ all_examples =3D [ > > 'l2fwd-keepalive', 'l3fwd', > > 'l3fwd-acl', 'l3fwd-power', > > 'l3fwd-vf', 'link_status_interrupt', > > - 'load_balancer', 'multi_process', > > + 'load_balancer', > > 'netmap_compat', 'packet_ordering', > > 'performance-thread', 'ptpclient', > > 'qos_meter', 'qos_sched', > > @@ -35,6 +35,12 @@ all_examples =3D [ > > 'vhost', 'vhost_crypto', > > 'vhost_scsi', 'vm_power_manager', > > 'vmdq', 'vmdq_dcb', > > + 'multi_process/simple_mp', > > + 'multi_process/hotplug_mp', > > + 'multi_process/symmetric_mp', > > + 'multi_process/client_server_mp/mp_server', > > + 'multi_process/client_server_mp/mp_client', > > + > > ] >=20 > Since these are in alphabetical order, I think we should keep the multi- > process apps in the list in the correct order, rather than at the end. Corrected in v2. >=20 > > # install all example code on install - irrespective of whether the > > example in # question is to be built as part of this build or not. > > diff --git > > a/examples/multi_process/client_server_mp/mp_client/meson.build > > b/examples/multi_process/client_server_mp/mp_client/meson.build > > new file mode 100644 > > index 000000000..196c39fc5 > > --- /dev/null > > +++ b/examples/multi_process/client_server_mp/mp_client/meson.build > > @@ -0,0 +1,14 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2019 Mellanox > > +Technologies, Ltd > > + > > +# meson file, for building this example as part of a main DPDK build. > > +# > > +# To build this example as a standalone application with an > > +already-installed # DPDK instance, use 'make' > > + > > +includes +=3D include_directories('../shared') > > + > > +name =3D 'mp_client' >=20 > I believe your previous patch in this set already set up the names correc= tly > for these apps, so I think you should remove this and the other name > assignment lines in the other files. I'd like to try and enforce consiste= ncy in > naming, and not having overrides of the name value in the individual app > meson.build files is key to enforcing that consistency. I left those assignments from a previous version of the patchset, my bad. Also corrected in v2. >=20 > Otherwise, thanks for doing this, and the rest of the patch looks fine to= me. >=20 > /Bruce I sent a v2, but realized I forgot to tag it. Sorry. http://patches.dpdk.org/project/dpdk/list/?series=3D4761 Thanks, Ali