From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Phil Yang <Phil.Yang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove redundant code
Date: Wed, 8 Jul 2020 05:14:46 +0000 [thread overview]
Message-ID: <DB6PR0802MB221644078CBED31FDF0E3F2B98670@DB6PR0802MB2216.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1591871065-12461-1-git-send-email-phil.yang@arm.com>
<snip>
> Subject: [PATCH 1/2] eal: remove redundant code
>
> The event status has been cleaned up by the CAS operation when we free
> the event data, so there is no need to set it to invalid after that.
>
> Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt")
> Cc: shahafs@mellanox.com
> Cc: stable@dpdk.org
This is not a bug fix. I think it is not worth backporting, suggest removing this.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Otherwise
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/librte_eal/linux/eal_interrupts.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal_interrupts.c
> b/lib/librte_eal/linux/eal_interrupts.c
> index 16e7a7d..2f369dc 100644
> --- a/lib/librte_eal/linux/eal_interrupts.c
> +++ b/lib/librte_eal/linux/eal_interrupts.c
> @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle
> *intr_handle)
> if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) {
> /* force free if the entry valid */
> eal_epoll_data_safe_free(rev);
> - rev->status = RTE_EPOLL_INVALID;
> }
> }
> }
> --
> 2.7.4
next prev parent reply other threads:[~2020-07-08 5:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:24 Phil Yang
2020-06-11 10:24 ` [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status Phil Yang
2020-07-08 5:24 ` Honnappa Nagarahalli
2020-07-08 11:41 ` Harman Kalra
2020-07-09 5:17 ` Phil Yang
2020-07-08 12:29 ` David Marchand
2020-07-08 13:43 ` Aaron Conole
2020-07-08 13:59 ` David Marchand
2020-07-08 20:48 ` Aaron Conole
2020-07-08 15:04 ` Kinsella, Ray
2020-07-09 5:21 ` Phil Yang
2020-07-08 5:14 ` Honnappa Nagarahalli [this message]
2020-07-08 5:20 ` [dpdk-dev] [PATCH 1/2] eal: remove redundant code Phil Yang
2020-07-09 6:46 ` [dpdk-dev] [PATCH v2] eal: use c11 atomic built-ins for interrupt status Phil Yang
2020-07-09 8:02 ` Stefan Puiu
2020-07-09 8:07 ` Phil Yang
2020-07-09 8:34 ` [dpdk-dev] [PATCH v3] " Phil Yang
2020-07-09 10:30 ` David Marchand
2020-07-10 7:18 ` Dodji Seketeli
2020-07-10 6:32 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0802MB221644078CBED31FDF0E3F2B98670@DB6PR0802MB2216.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=nd@arm.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).