From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 658B0A00BE; Wed, 8 Jul 2020 07:14:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C340E1DE0B; Wed, 8 Jul 2020 07:14:58 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) by dpdk.org (Postfix) with ESMTP id 18D461DE05; Wed, 8 Jul 2020 07:14:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qoKxdwaLiNdviEzMq2gEa+KJtvVJEzqRt0eYf7Qc12Y=; b=gZ9QLReCrhcselIAmzR9yl5u8aHcM6C0YSFvrc4wwcNSF6f5m5F3MWlNFPID7vqBkPxUJQg6tWAR516+uCdNkyNjxA2eBnVJCWDZVae/g8OQg0mo57MwIE2d8YkKbjX+TcceSNVPebQv292hTto4Xa4yg6JK8vNxpAVk2NDPFU4= Received: from AM5PR1001CA0006.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::19) by AM5PR0802MB2578.eurprd08.prod.outlook.com (2603:10a6:203:9e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Wed, 8 Jul 2020 05:14:55 +0000 Received: from VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::a9) by AM5PR1001CA0006.outlook.office365.com (2603:10a6:206:2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23 via Frontend Transport; Wed, 8 Jul 2020 05:14:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT038.mail.protection.outlook.com (10.152.19.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Wed, 8 Jul 2020 05:14:55 +0000 Received: ("Tessian outbound b8ad5ab47c8c:v62"); Wed, 08 Jul 2020 05:14:54 +0000 X-CR-MTA-TID: 64aa7808 Received: from 53ae1ea0ce60.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EEF9AC50-B241-4A7B-960F-0EC80E1D79ED.1; Wed, 08 Jul 2020 05:14:49 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 53ae1ea0ce60.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Jul 2020 05:14:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dm/SIKsE0+Ja1zVI7DQ4G8sN8/W0vBhBvdkzgz1hA6eJLBrKOGXY9bvJ+CzUMUyLZmyb0g3u6dAIvzhYOHOtfdihK3nD7MvcB6EGupvHy2q6DyRcm4ILRX8kdo3RiCvTYb+XwL9++nT82BZrpCXRn12FqNynvObFDF4A9R4B+j3s2SzeSGbdeSN36g0UVhxSktLuns7uWByex715RFB6BdBe+euZLKwG2jMeloIdxsOOIVZpq3bspI0OuBZIaB2zcJq3QgUhivq+TmG/vHWXmyL8MMevu2WqPmcjiM/9ZOJPvBiMKyKXbs/dPOQHYJl6dJGdymzD4Rw2SaMAyqbD0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qoKxdwaLiNdviEzMq2gEa+KJtvVJEzqRt0eYf7Qc12Y=; b=GUkje6mGKqHzAs18D2nwVxNW8R73b7QSOtC0NPeZu05n3++InK5tUFD8jSdioFgx26eyUqTaxZVLJtwPvDK8G/pR0xdwWnjfLhf1OTBpNP2E4W3bAcTWaHNcOMVgav3HfqWjYIeahM/K3s/4F3SufV74c4Fhk3B5SPWgIkQUtRm/1gX+HnvVUx/1cKDBR0xUVBOg5yDJ8b30f+KpkMzhj29Wpc9GtrR6MNQ9p+GwJ7ktGSvsy33tlcvDE6Wkan75+pOH6zPXZsksEFiMYE3EZnE8X8ZtszMMjXR9OfxxmyST1PGyg02ocSHKcfqFUwUcWDRKU8LGGZjSfOn681dNjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qoKxdwaLiNdviEzMq2gEa+KJtvVJEzqRt0eYf7Qc12Y=; b=gZ9QLReCrhcselIAmzR9yl5u8aHcM6C0YSFvrc4wwcNSF6f5m5F3MWlNFPID7vqBkPxUJQg6tWAR516+uCdNkyNjxA2eBnVJCWDZVae/g8OQg0mo57MwIE2d8YkKbjX+TcceSNVPebQv292hTto4Xa4yg6JK8vNxpAVk2NDPFU4= Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9) by DB8PR08MB5290.eurprd08.prod.outlook.com (2603:10a6:10:a5::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Wed, 8 Jul 2020 05:14:47 +0000 Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3153.030; Wed, 8 Jul 2020 05:14:47 +0000 From: Honnappa Nagarahalli To: Phil Yang , "dev@dpdk.org" CC: "drc@linux.vnet.ibm.com" , Ruifeng Wang , nd , "shahafs@mellanox.com" , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH 1/2] eal: remove redundant code Thread-Index: AQHWP9qTCNUWMfFdVUWFZNs5nUltMqj9TLqQ Date: Wed, 8 Jul 2020 05:14:46 +0000 Message-ID: References: <1591871065-12461-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1591871065-12461-1-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 91f6e2b9-e08e-4ac5-9373-b78c571c8de4.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 92f5ac35-5f79-408c-5a52-08d822fdda24 x-ms-traffictypediagnostic: DB8PR08MB5290:|AM5PR0802MB2578: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4941;OLM:4941; x-forefront-prvs: 04583CED1A X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KwSsZA2PCC5T6pD6EBhQ5ZnS9t/jAX44CO3NBo3BCT7uzNF4PCJU2COXDf3BcnyHvarCY1BN6qVbcjixnQRFq+tLyxhNWQiIc99CvFZQHpaCymvpduz5NJAiSaPGJ27Hvhx1genf01zxvQwbPikpa7gVrx2EXEXCJhg5vzagXz/otgJC2o5x0k+vNaQI+xfs2e8DwwhOvvPrzcwtHHZKyJw8vN91hjSsD93mBm0XZz5XI13U0f17yq7IMQrTQyBf4WkmoOTxtDamqxwdKn9e9tXUGOGqBaqQbsuQSpU3cAdNGhorN0IFRr15jZyqhuYY X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(366004)(39850400004)(396003)(5660300002)(8676002)(55016002)(33656002)(83380400001)(9686003)(52536014)(76116006)(2906002)(66556008)(64756008)(66446008)(66946007)(66476007)(8936002)(186003)(26005)(4326008)(6506007)(7696005)(86362001)(478600001)(71200400001)(110136005)(54906003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DmM162UhR0cXro+tFMOunxaNiJ2MohjMi1NfCUNDC+q2VkbsaMEvHeqCUcatjKEW5KIBOhzvFU5opssuky+9Vsm7wPmu0MbNzcBvraAaqshgIcrXdRnKVtiiREkwf6VWow0nrHFihPd0LPeNEwSTe5fU8UCE02gOlQoWAjH4C9/TkorWxrGRWiDkPlWKDNf3M9gxsZRnYI4u7FOmC/hdIKXm58vGzsbXbVTqdSCV4sKQdTs1VmngAKpyOATph69Q74m8p3WuXkTGkY/rJZe5as/mLGOCjtkVPwf3pekP4qKdpYiwgMA4nDo+dfXwZ3QzvXo/ul+ff9+obys18vnWV00MgD3LmsdDVhoPUzeEWa7wd+q3YvSEBodkuWs3MmB4SsKRHlJjKZtEB97LR/4mnoKyB1P9XjyZ5uw9/ySgbcd7Mkc7A+kEVbvZNZqsstDX14J0J5IadC9CYGO0FCGgdniSCGhopBs7Y16HzCOwPs18DrgDjk6SCqrKpyDu/XV1 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5290 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(346002)(396003)(136003)(376002)(46966005)(26005)(478600001)(6506007)(82310400002)(186003)(7696005)(9686003)(55016002)(356005)(316002)(86362001)(54906003)(8936002)(47076004)(36906005)(82740400003)(8676002)(110136005)(2906002)(81166007)(336012)(4326008)(83380400001)(52536014)(33656002)(5660300002)(70206006)(70586007)(450100002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: aa7a3801-8c89-400f-bd80-08d822fdd526 X-Forefront-PRVS: 04583CED1A X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ndpi+ePaEKWhWJuJnpaAhakprEn5mQHbU4kUNWSezDyQIe3faYkV007Z/GQ+ee6DYZMLPoociR+6zBgZp8oZTQDkaNN8mYC1ZbZkMs7xZgCad15MQHLLas7vsXLfFUpLzNlgOSr1nqzPr8ae9t/FRmnCwVVY59ocUL5tSl6WCT21SoYESzmOKVvvBSSTkcH4xHJUQVrBMXqQCojgHfkp2QoV6oL0/wHpHBpWkWnCJQL00bRicJ/SLONO+pPfHcb1YnyLHYSahDvOaFS5LXvxamZEUASit6VV5eP5lXPwtB1cig59XMArAbmOG7m4t3T4d1PNYQ6XsKDBNJC4OA33NrdSPVC/NIJSwt5iRyJMIouy2cdp8Lvdxrdlf6w4ri6uz5/97VCTbGeBSemplFUoRA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2020 05:14:55.3251 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92f5ac35-5f79-408c-5a52-08d822fdda24 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2578 Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove redundant code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH 1/2] eal: remove redundant code >=20 > The event status has been cleaned up by the CAS operation when we free > the event data, so there is no need to set it to invalid after that. >=20 > Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt") > Cc: shahafs@mellanox.com > Cc: stable@dpdk.org This is not a bug fix. I think it is not worth backporting, suggest removin= g this. >=20 > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang Otherwise Reviewed-by: Honnappa Nagarahalli > --- > lib/librte_eal/linux/eal_interrupts.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/lib/librte_eal/linux/eal_interrupts.c > b/lib/librte_eal/linux/eal_interrupts.c > index 16e7a7d..2f369dc 100644 > --- a/lib/librte_eal/linux/eal_interrupts.c > +++ b/lib/librte_eal/linux/eal_interrupts.c > @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle > *intr_handle) > if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) { > /* force free if the entry valid */ > eal_epoll_data_safe_free(rev); > - rev->status =3D RTE_EPOLL_INVALID; > } > } > } > -- > 2.7.4