From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D67F6A0524; Sat, 4 Jul 2020 17:07:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D60891DB9E; Sat, 4 Jul 2020 17:07:05 +0200 (CEST) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-eopbgr90088.outbound.protection.outlook.com [40.107.9.88]) by dpdk.org (Postfix) with ESMTP id 26CBD1DB9C; Sat, 4 Jul 2020 17:07:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snLIZQ9grxDDopXJIbzHa07M6MdZd2pbOiQfp+nZkjk=; b=ewVE0SS5vDh5CuW0EzMzqBU5KtFuuQ+PfvE6XdWmkEIJmd0WMaGuE6GsVZmnF7UYUIFACyQnJr2gyxYcaylaIltUobSMSjiYFS55/3LNIiW5GPDCSmMwUl2xoIjCMronrcaPL/3VsjEuhd4lAX0aFTci5MhXFauIMUyoCy3a2J0= Received: from MR2P264CA0014.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::26) by PR2PR08MB5226.eurprd08.prod.outlook.com (2603:10a6:101:24::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Sat, 4 Jul 2020 15:07:02 +0000 Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:1:cafe::9) by MR2P264CA0014.outlook.office365.com (2603:10a6:500:1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21 via Frontend Transport; Sat, 4 Jul 2020 15:07:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24 via Frontend Transport; Sat, 4 Jul 2020 15:07:02 +0000 Received: ("Tessian outbound f7489b7e84a7:v62"); Sat, 04 Jul 2020 15:07:02 +0000 X-CR-MTA-TID: 64aa7808 Received: from f76c3e5d1fae.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 289597AA-A8A8-4710-964B-16CA857486AD.1; Sat, 04 Jul 2020 15:06:56 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f76c3e5d1fae.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 04 Jul 2020 15:06:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kFi8JuMcForEvXQ6jVwm8C6q6LVbNJ6T/+lnIrgBv67pYnKvKKTlcAcEgcwU5Uye5ZcZp3CY3N/rFjpewnQ2QGC+QL6pPOBfLFVDcHF+t+lYJgaRytvhfMqjBMUS/wr22eKeROwkBKByQfmObKR/wbf3Fkq0AwRQG42+JPcsspDA3BrUDSC1KgMiW2FfiPSSBSMzxfe2yPj3h9Gg7siL9+7F3yQ06PvargjptcW1ywndjLzeT7JBpctZ0pN1txqdtQIOKz/PJSUnPd1PAO73bqpRauWO8F6K4bKV8UWg1ePXwVWQgxO9SRo6DXbe82R6GwPPNYBtE2SA5B8vMUpQMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snLIZQ9grxDDopXJIbzHa07M6MdZd2pbOiQfp+nZkjk=; b=C9rYQWjd16Qs4y7NWBFfemTU3FL2t+4qFTS+AEk5ZxnWhZGrnXM17kaBZFQ8e+I3TDLc/efXLsPZjeNbVi9oySD5nbcJQmOp8FvCnCZYcaSlXJukWcWxgW5VlWpEhLbO+dd5xkzHUEXv9sfRqms3cQn+nOqk/cmgv/77qCqIJwxXcaIpJ1bbhs4xunVMXxV/hH9YI5Jf63zulUUileyVtZdP4MElyMt4jSFmvZ0VARRACbAf4Du3NGz4JOSnbWk8fAErJkQlYmtou3tJDXn+3zTSwMLpkSrb0tKiIBySGnbC1izOis14AQB0n5USRZ8lkryCtEemgkxSXq6kc3m+Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snLIZQ9grxDDopXJIbzHa07M6MdZd2pbOiQfp+nZkjk=; b=ewVE0SS5vDh5CuW0EzMzqBU5KtFuuQ+PfvE6XdWmkEIJmd0WMaGuE6GsVZmnF7UYUIFACyQnJr2gyxYcaylaIltUobSMSjiYFS55/3LNIiW5GPDCSmMwUl2xoIjCMronrcaPL/3VsjEuhd4lAX0aFTci5MhXFauIMUyoCy3a2J0= Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9) by DBBPR08MB4741.eurprd08.prod.outlook.com (2603:10a6:10:d8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.24; Sat, 4 Jul 2020 15:06:56 +0000 Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3153.029; Sat, 4 Jul 2020 15:06:56 +0000 From: Honnappa Nagarahalli To: Andrew Rybchenko , "dev@dpdk.org" CC: Igor Romanov , "stable@dpdk.org" , Harry van Haaren , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH] service: fix wrong lcore indexes Thread-Index: AQHWUhB9JlhLUoifZ0e8qmC1EIm0DKj3hOpg Date: Sat, 4 Jul 2020 15:06:56 +0000 Message-ID: References: <1593873347-13686-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1593873347-13686-1-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0ae9a86d-2517-4aba-b5cb-ab2c65049ea6.0 x-checkrecipientchecked: true Authentication-Results-Original: solarflare.com; dkim=none (message not signed) header.d=none;solarflare.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ab4ea675-0f96-4128-f8d1-08d8202be846 x-ms-traffictypediagnostic: DBBPR08MB4741:|PR2PR08MB5226: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3826;OLM:3826; x-forefront-prvs: 0454444834 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FLOK1BtdHwvhebYsFDfOy1KBnLFIOO8Q6MMO/9kV4t5bSSoYGrCUnzJGLqUH8wQC+tEYcWpGHkYeTA3Pk0Chwzkevsiqwduu7M4N0gLAQ/tmHn5oTQGxjhwxBsCeqEytKdHxKFQIrOX1kQ9sJZ/3koypJQPbG4AkxfWP18ok4jmsunGxAPyHrS0IWX1jcY9+igtWvQOGF8bwyDqa0rk0Kah7Z5OCsomKS/niyDrzObNlTzff6N90zFCq3CeSGEvxDSQI606uSYbGrwRwdMuVLJ87kBtz5qpARcvdwuNjybXW/2YXW+wrAy8CMfpiY26P8Fhu9J4AmbB1FcnYmsqMFw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(366004)(39850400004)(136003)(396003)(76116006)(26005)(66446008)(66946007)(66556008)(64756008)(66476007)(86362001)(83380400001)(8936002)(8676002)(5660300002)(52536014)(55016002)(33656002)(4326008)(6506007)(53546011)(316002)(9686003)(478600001)(110136005)(54906003)(186003)(2906002)(71200400001)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: p9yjEh9+sMzTYP0+YH5XSKe7OIQ+999TbAPDX54nslYlCq2klR3TX4dcQUt/q5s58Tcc5S9mjrG08m7YodRuRVawyt689uVic9yDhAOyxz4mfU8gj1r6aGiPQ61s5mzLHr1+10KGAy0NIKjb3DMZ9+imV/N0CHyrgKtCclIgsC0MHkF7bkugmziZQ8gE3KpOd0XvF1tpIw5fpC03vreuk68V7Wod16L070tHm647hX/UtkBMrB4kAtPLqVgoLpgpSe9Kat4NhMNiDxeSVBDbTA1tpPiPwE7x7XXW+qKMtMCAov2Qn6fJqXcKOdWD2v2RcKvSQUhEWt9u76PIwTvhLRGDGMw2c3DBiJnfMYsb6JGCq20BDXvX+/9lPVAXKm7Is7mrN7rvmW7b4QLewIei4ubL7uqo6B9/q01ggN/Wo8/mcvnziNIpXNd8n1Fh4fqflPvMJB/gHeGjb2+vOnKpRFU9M5c6ej7nMAaPMdzwKUeC3FzAG5Roig1qtfRhAofF Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4741 Original-Authentication-Results: solarflare.com; dkim=none (message not signed) header.d=none; solarflare.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(346002)(396003)(376002)(136003)(46966005)(83380400001)(8676002)(7696005)(6506007)(5660300002)(70206006)(8936002)(53546011)(54906003)(55016002)(52536014)(478600001)(26005)(82740400003)(356005)(110136005)(70586007)(36906005)(316002)(4326008)(186003)(9686003)(2906002)(336012)(33656002)(450100002)(81166007)(82310400002)(47076004)(86362001); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 23a4ec2e-78ea-4fb4-9ae7-08d8202be48a X-Forefront-PRVS: 0454444834 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qfJr+WtthaIsOdB+Arfk22XyRYD4wkKINY3igMuI7QYk19sceAbK4DHScPacwkTS8W0SM0fm+eaEs/LCmuOaMc3i7QP911O4C2ZuGucODf3gqKsLGEZKZ1mMkCvJdDCQ3KU/2BTsMM2EXOUl27c8t5k3Sl4KUrQClhVtbpSDygZDVY6t2zPUU9tGvEd0k940G1wVu6jmaD3NajQ+TtyMgGyVR5BhnGrPofQ12sB5VS06p9xTa3OOWsRGubTvNv/pLyJ7IVLy23hjOgSsCdf+PLb3MGMyvn77a53ETyBOt2mz5jV+Ci/SQhhW4q4vuGNOYocgVAfUojs/bjP7AZYG4r9rz9P7OKGDpOpxaIZnHvCLfW4GxN8QPB482bsRRq4JRybcBl7m//li+FYD17Mz2Q== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2020 15:07:02.4015 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab4ea675-0f96-4128-f8d1-08d8202be846 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB5226 Subject: Re: [dpdk-dev] [PATCH] service: fix wrong lcore indexes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew/Igor, A effective test case is missing for this, can you please add a test case?= Otherwise it looks good. > -----Original Message----- > From: dev On Behalf Of Andrew Rybchenko > Sent: Saturday, July 4, 2020 9:36 AM > To: dev@dpdk.org > Cc: Igor Romanov ; stable@dpdk.org; Harry van > Haaren > Subject: [dpdk-dev] [PATCH] service: fix wrong lcore indexes Nit, 'indices' would be better? ^= ^^^^^^ >=20 > From: Igor Romanov >=20 > The service core list is populated, but not used. Incorrect lcore states = are > examined for a service. >=20 > Use the populated list to iterate over service cores. >=20 > Fixes: e30dd31847d2 ("service: add mechanism for quiescing") > Cc: stable@dpdk.org >=20 > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko > --- > lib/librte_eal/common/rte_service.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/common/rte_service.c > b/lib/librte_eal/common/rte_service.c > index 6123a2124d..e2795f857e 100644 > --- a/lib/librte_eal/common/rte_service.c > +++ b/lib/librte_eal/common/rte_service.c > @@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id) > return -EINVAL; >=20 > for (i =3D 0; i < lcore_count; i++) { > - if (lcore_states[i].service_active_on_lcore[id]) > + if (lcore_states[ids[i]].service_active_on_lcore[id]) > return 1; > } >=20 > -- > 2.17.1