DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>,
	Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time
Date: Thu, 2 Jul 2020 20:42:02 +0000	[thread overview]
Message-ID: <DB6PR0802MB221681F99725D0EE04E7122D986D0@DB6PR0802MB2216.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB33017126DD0E53568C8903209A920@BYAPR11MB3301.namprd11.prod.outlook.com>

<snip>

> 
> Hi everyone,
> 
> > >
> > > Konstantin, Honnappa,
> > > Any update about a fix for compilation time please?
> >
> > +1
> > A good amount of time waiting for builds is on this code.
> >
> 
> Between 69567 and 69559:
> http://patches.dpdk.org/patch/69567/
> http://patches.dpdk.org/patch/69559/
> my preference is still 69559, as it compiles faster and doesn't reduce test
> coverage.
> But as I said before - I can live with both.
> As I remember Honnappa had some concerns regarding 69559.
> If that is still the case, then to unblock the situation I am ok to go ahead with
> 69567.
> Konstantin
Apologies for missing these emails.

Thanks Konstantin.
I ran the tests with both the patches and I see that both of them are showing the same exact numbers on Arm platform.
I liked your patch because I think it is better for future additions of test cases.
With my patch, I am concerned that we might hit the issue in the future again. I will add my acked-by to your patch and mark my patch rejected.

> 


  reply	other threads:[~2020-07-02 20:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30  1:56 Honnappa Nagarahalli
2020-04-30 10:23 ` Thomas Monjalon
2020-06-16 12:47   ` Thomas Monjalon
2020-06-25  8:19     ` David Marchand
2020-06-25 11:05       ` Ananyev, Konstantin
2020-07-02 20:42         ` Honnappa Nagarahalli [this message]
2020-04-30 12:55 ` Aaron Conole
2020-04-30 16:03   ` Honnappa Nagarahalli
2020-04-30 17:01     ` Aaron Conole
2020-04-30 19:51       ` Honnappa Nagarahalli
2020-05-01 12:56   ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0802MB221681F99725D0EE04E7122D986D0@DB6PR0802MB2216.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).