From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DAACA0546; Thu, 16 Jul 2020 18:59:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FC1B1BEA9; Thu, 16 Jul 2020 18:59:22 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by dpdk.org (Postfix) with ESMTP id 72E031BEA3 for ; Thu, 16 Jul 2020 18:59:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zcGN9S1MbYiaaDKtsNRFgd0iBtFw7gjR1US3CZZHCvc=; b=lup2ULcSFlPzv87bs98dvhOfqsTwbFT4CKP1a21npmQ1NKovcCn+Wi3Y3/FK1CnuRQFz9dNv+k4ApGDXHwGgrPk+osr+j46Wva9/njW3oag6dFVi5WDQBbITZrINmZp25NaLFA04Y/uZFAxtcjz6HwYxoWBr3cxBIJOG82Uoh6U= Received: from MR2P264CA0148.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::11) by DB7PR08MB4220.eurprd08.prod.outlook.com (2603:10a6:10:7f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Thu, 16 Jul 2020 16:59:18 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:1:cafe::ff) by MR2P264CA0148.outlook.office365.com (2603:10a6:501:1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Thu, 16 Jul 2020 16:59:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Thu, 16 Jul 2020 16:59:18 +0000 Received: ("Tessian outbound 2ae7cfbcc26c:v62"); Thu, 16 Jul 2020 16:59:18 +0000 X-CR-MTA-TID: 64aa7808 Received: from 12381147caf3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FC7670D9-4EA5-42BC-BAE8-C3F03634088E.1; Thu, 16 Jul 2020 16:59:13 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 12381147caf3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Jul 2020 16:59:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KAkKP7Skl4h6fDYTqqPxjoFvQgOFFpAoUSb3XUfYMFmiJ+VosQk5aMaLglZU0Jg6UwxQDHqZoQCYMF3p72sA8pL6m/XbA4d08PpA4lXJOg4TTrnG7gRMBnjuLnIZi+6CI5KfTgYMxkCdBWQ1rvbh5aeOJ8nNGL6JKTQRqzhU2gHIklCXYu5oDojKo2yewKVUnIFiDu7Ga5m1j4+QlYrGBz/G1lQWzAC/Nwo47boBv9WhSG0GrIC9oGrggcFfitiz66vSGPwp7SsKMWLL6TAp/vKYb+3pOqSPdU2z02s16PSJeiD++E0uqMw4xXCIALOHymfHUS/QWtxTYeq4xjMfCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zcGN9S1MbYiaaDKtsNRFgd0iBtFw7gjR1US3CZZHCvc=; b=UtUuFidcXPrOAXrOQ6L/H4wWLzd6vW1M1ncsxu1/sgrXfHfxi8TyBEWaJA9W1QKEG7qnte1BuNTUG0d3uXSy5l0rPUeuJkmTb9X34uiTWE0NhBe3MHsmDl4fzW4GjnnsTtHPF8IINE4HZ4Yg/2vhrMOZlSRq25a36zFu21/xA5bc+VMhKbRL70icxF1RAKsKH8cvf0BDlOjQeHTqBH9pTQzhpQhiYNJ6fMGJKEMoaCbAU9eUSt1CwcCB13wIsswVVPanhTCZnbNZaumZoiLyN3qOWqFrpoyIOjd6lYW5WgrG5POGDvE0aG3PspWfPHvZVSRYVk9XIZHeDTXWhH+Erw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zcGN9S1MbYiaaDKtsNRFgd0iBtFw7gjR1US3CZZHCvc=; b=lup2ULcSFlPzv87bs98dvhOfqsTwbFT4CKP1a21npmQ1NKovcCn+Wi3Y3/FK1CnuRQFz9dNv+k4ApGDXHwGgrPk+osr+j46Wva9/njW3oag6dFVi5WDQBbITZrINmZp25NaLFA04Y/uZFAxtcjz6HwYxoWBr3cxBIJOG82Uoh6U= Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9) by DB7PR08MB3356.eurprd08.prod.outlook.com (2603:10a6:5:1c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Thu, 16 Jul 2020 16:59:12 +0000 Received: from DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3174.027; Thu, 16 Jul 2020 16:59:11 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" , Phil Yang CC: "dev@dpdk.org" , "Mcnamara, John" , David Christensen , dev , "jerinj@marvell.com" , "Ananyev, Konstantin" , Ola Liljedahl , Bruce Richardson , Ruifeng Wang , nd , David Marchand , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches Thread-Index: AQHWW5JtKe65xTzx+UC12vJy3iIY0A== Date: Thu, 16 Jul 2020 16:59:11 +0000 Message-ID: References: <1594621423-14796-1-git-send-email-phil.yang@arm.com> <3325015.uBoaBXitGU@thomas> <4777511.sDcrFEcvGN@thomas> In-Reply-To: <4777511.sDcrFEcvGN@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 62bf0f85-3c2b-4a2f-b8d5-0e8693636e53.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.112.90.121] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ad0349b2-945c-4ad4-c1fb-08d829a99428 x-ms-traffictypediagnostic: DB7PR08MB3356:|DB7PR08MB4220: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aZmD8LlyKNJXZixLIwxFGtfgMYQ8hsEly/7aAjwwwqjE1k7tR1Z1m5a3ShFH9azCcratNxcGyX+VIEPtZ6z5eejOCsD189jKviYM9eqA7LCwBwQPaMCF0cDcSYixHiitqvjJwIp5/JnGWGYREqA5hTRfGo7icFNZhc2mROF9gdjaZWCfgDK5sbOpqy3tekbGNIKnRimv9Exx8KpeIjhb4hvjKcwaLgDsSyLfl3vRPotgD1QYSsl0WIfq3Kgbnw6mQVv7LYc/keGlqO0Zry3Z0AoFkE8Q6YBcFF0DL9D9yS7hJHxxIHN3BszZtw/V2JbP X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(26005)(186003)(33656002)(66946007)(2906002)(83380400001)(66476007)(76116006)(66556008)(6636002)(66446008)(64756008)(71200400001)(478600001)(5660300002)(316002)(53546011)(8936002)(8676002)(4326008)(55016002)(9686003)(6506007)(52536014)(7696005)(110136005)(86362001)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: leBg+Q9726k2hJy16NdWgwgZzViKow6XiUyI/gdDlhsP1tWBGUwjbtiHLzk2B6wLBF/mthnYumvcpsz+6VaQp6I4NJHX0IR4mW3llsO084EM4qMxLRv3QAq8V7HhGSHUMdonha1OkPId5JWnz+YJLfstkRO0jHFXnEOnPpSydzgymHKBHvvnruLdVVbJUai2ydDYwBQk4gh36malXUo2Use9Te2NA0Z4E2PeOGU2yywlJdR2RhgLJstcjOmO0YCyTnQCYWz0zE4nQr/u8v0KcO1Op01gjvRB8RkbB+94NCSdGb+Vu2g/mAAM9r2utsL3e089HQVz8WY0/WACjQicKjkoIs3DiEJcLVOx9nI/bfhZsaAvee0DSVIJIilMTIluT3e256e+YpnR6GqsO6e4Pn9lDMbKKwWJX6IMOHOKVcnrFhzQFPzLxE4s2yYb4SJ1W/gmUBX5Q8pqilj8Puqg7Q/NH+fb+6u79Hsd9t+ITgN8w1P7Y3LOfTn0oRYNHxsG Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3356 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(46966005)(86362001)(70586007)(36906005)(81166007)(6636002)(6506007)(70206006)(82740400003)(9686003)(53546011)(55016002)(7696005)(47076004)(2906002)(316002)(33656002)(186003)(54906003)(26005)(336012)(4326008)(8676002)(52536014)(83380400001)(356005)(478600001)(8936002)(82310400002)(5660300002)(110136005); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: fdee026e-b1d7-4a49-34ba-08d829a9903a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rv/fS5C1gxz6dU7UMAgwL7QXkqz8hh8V6c6tzKvZkPAb1ENMDs6lAw4XQ+FK5mOrLt+uGjZTdFxRmlkz89zwm374IheJX371E0TpvZFnOl4b+StcKkh878hBbzk9D/6qh4sygZSup6H36FTcxuYapxFbOAeQyixOqlFBVYRM44Jk5ToZq/9LtJ1TD24etOmudyqtvcOctat6SNOCVPw/HiBN2x3LIRhM7G5mUA/YkW6alU0C0leeUHDmS6Svm2mChnvhSD2SYG1W1qa6tynvZHYuiILwaZvhzXJnOl327XCcuDLkbhzkEG1Bj0PB0aoIFRGO+ot/e/SAl7iKY/35QPaKe6keVWDGb7fPfJIn+fQx5ydlBKg44IRDd/vRweU8w8Ij75DQbg90PWL0SYGI2w== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2020 16:59:18.3726 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad0349b2-945c-4ad4-c1fb-08d829a99428 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4220 Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte > > > atomic APIs in future patches > > > > > > 16/07/2020 12:48, David Marchand: > > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote= : > > > > > check_forbidden_additions() { # > > > > > res=3D0 > > > > > + c11_atomics_dir=3D"lib/librte_distributor lib/librte_hash > lib/librte_kni > > > > > + lib/librte_lpm lib/librte_rcu lib/librte= _ring > > > > > + lib/librte_stack lib/librte_vhost > > > > > + drivers/event/octeontx drivers/event/oct= eontx2 > > > > > + drivers/event/opdl drivers/net/bnx2x dri= vers/net/hinic > > > > > + drivers/net/hns3 drivers/net/memif > drivers/net/thunderx > > > > > + drivers/net/virtio examples/l2fwd-event" > > > > > > > > I prefer a form like: > > > > > > > > + c11_atomics_dir=3D"" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/octeontx" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/octeontx2" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/opdl" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/bnx2x" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/hinic" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/hns3" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/memif" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/thunderx" > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/virtio" > > > > + c11_atomics_dir=3D"$c11_atomics_dir examples/l2fwd-event" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_distributor" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_hash" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_kni" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_lpm" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_rcu" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_ring" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_stack" > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_vhost" > > > > > > > > Easier to read and update. > > > > > > Why do we need this list at all? > > > Are we allowed to add new code with old atomics in other > > > directories? > > > How bad it is to have a warning on non-converted libs? > > > > From my perspective, the pros of this list are : > > 1. Avoid introducing false warnings in non-converted modules. Otherwise= , > the maintainers have to wonder if that module is converted or not. >=20 > Don't we want to convert all libs? The goal is to convert all the libs. > If we are adding one more rte_atomic in a lib, we should ask the question > why not converting to C11, no? Agree, I am fine with this approach. That will kind of distribute the conve= rsion work as well.=20 >=20 > > 2. Keep non-converted modules compatible. C11 atomic builtins cannot be > used directly for rte_atomicXX_t variables. > > > > The cons are : > > 1. The list needs updating every time we convert a module. This list will go away once all the modules are converted. > > 2. The script is not elegant as before. >=20 >=20