From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B721A04D7; Tue, 11 Aug 2020 07:37:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04A4C4C9D; Tue, 11 Aug 2020 07:37:06 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2074.outbound.protection.outlook.com [40.107.20.74]) by dpdk.org (Postfix) with ESMTP id 9B32B4C99 for ; Tue, 11 Aug 2020 07:37:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wn127Oqd2ObFpvvy5dP4xgEsOXeY3TTlC+jV5yBEo4Q=; b=3YfJjqRa5UEud+aUsoIWOER5mHQtQ/DA4vmnm7NOiznHGX5NxecRncrNT60APWG3j5hwXOnCPJBbukAwUfsRCpYCSkMMEF31a4T/OYI1oKd0rJOp0lZZtPi5pBB6z4WBX+7DziQ3iTql6+o1T1O2jr2OmxkyUClY1B4bS5nVRRw= Received: from AM5PR0301CA0012.eurprd03.prod.outlook.com (2603:10a6:206:14::25) by HE1PR0801MB1899.eurprd08.prod.outlook.com (2603:10a6:3:4e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Tue, 11 Aug 2020 05:37:01 +0000 Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::68) by AM5PR0301CA0012.outlook.office365.com (2603:10a6:206:14::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.18 via Frontend Transport; Tue, 11 Aug 2020 05:37:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16 via Frontend Transport; Tue, 11 Aug 2020 05:37:01 +0000 Received: ("Tessian outbound 195a290eb161:v64"); Tue, 11 Aug 2020 05:37:01 +0000 X-CR-MTA-TID: 64aa7808 Received: from 56249358a099.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8192055F-404A-43EE-BB2F-74FF1BE007D5.1; Tue, 11 Aug 2020 05:36:56 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 56249358a099.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 11 Aug 2020 05:36:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFuaNFzPURjSIkwxINmOlnEuezMs3CKi0nC1eABTKR8vkrKylv8VHFE0TBjvbz/zTVxqhePHi+2euIZ357CA2DDDoqvHwEku9Y47oLio7SCQT4oGVQKBJkNn33PCObtVhsfC8EgkKGotO0hHNfJXUWKNJKtnA4d9NKNhQYNs9N8wiSbwnz0hA5mj8sTc7fDwOGZgkR9CvOU8T/LN+JvATnGToXlwlCAP3kS3M1dYQg3tm3IXA6a6faG7LDHn2slsTu+Ehmu67wmo79LxNiU9StgPMxj1Epe9sqYdlVhbLCI31ig7NXMrf+WHOWuVs8jRxjDT1iIQ3FzU4mZdVlnV8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wn127Oqd2ObFpvvy5dP4xgEsOXeY3TTlC+jV5yBEo4Q=; b=LWTFMqkPXM3JNZMOF8frELgZHOQ5LumkZDPc2NvWhSWHuNLoMCviytkv07xQfH+gpKSn0Nxk/YJcJuJKB9QAecvd7VefySeHfH5O1d7Exzp/rGtStngPwFByVsMD3P/H5yPuxBUp5v+GLae209ZN/b6mvov275nDtmGxQo29hsbhON2nTlkeigCrc2rMd27g+PHGA7Z3msNGvtICN/+c9nJ+QaMytiXMhcbxUESaPvMC+NrMYLL0JY1BPClRD4M2vB7b8ps7yu570xwjSMhw2yZhX2ThgXf7p4XkVxOfkcuqGtvJrs7l+2sSjCn3w349CgAktAeFSGwi1hy5d0g1pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wn127Oqd2ObFpvvy5dP4xgEsOXeY3TTlC+jV5yBEo4Q=; b=3YfJjqRa5UEud+aUsoIWOER5mHQtQ/DA4vmnm7NOiznHGX5NxecRncrNT60APWG3j5hwXOnCPJBbukAwUfsRCpYCSkMMEF31a4T/OYI1oKd0rJOp0lZZtPi5pBB6z4WBX+7DziQ3iTql6+o1T1O2jr2OmxkyUClY1B4bS5nVRRw= Received: from DB6PR0802MB2438.eurprd08.prod.outlook.com (2603:10a6:4:a2::18) by DBAPR08MB5687.eurprd08.prod.outlook.com (2603:10a6:10:1b1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Tue, 11 Aug 2020 05:36:54 +0000 Received: from DB6PR0802MB2438.eurprd08.prod.outlook.com ([fe80::5daf:7995:539a:232b]) by DB6PR0802MB2438.eurprd08.prod.outlook.com ([fe80::5daf:7995:539a:232b%12]) with mapi id 15.20.3261.022; Tue, 11 Aug 2020 05:36:54 +0000 From: Honnappa Nagarahalli To: Ciara Power , "dev@dpdk.org" CC: "bruce.richardson@intel.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH 20.11 00/12] add max SIMD bitwidth to EAL Thread-Index: AQHWbNTJnpy2v7mZ6UGBBNhAZ72lHKkyZ33g Date: Tue, 11 Aug 2020 05:36:54 +0000 Message-ID: References: <20200807155859.63888-1-ciara.power@intel.com> In-Reply-To: <20200807155859.63888-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 99a8ad53-f09e-4d1d-a405-f8d46308b052.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.112.90.121] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 17f5a49b-8374-4532-471e-08d83db892bc x-ms-traffictypediagnostic: DBAPR08MB5687:|HE1PR0801MB1899: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Sj070+xfmA/x+zNt1DxtkCqKrRlQIS2aW3YZY7i18aYWGKy62ia/3SmZmr4C0NIqLslMvM6ffQxTAiRA2NtDkDCKCpvEelNiUiaNCBL135MIHb7kJNQtlxme7UlTmAI+IgW45FrVZLnEb6n6Coif0HFZRFN5dpzHPELGlpOvBUMw98GaRn//caB+y/McutO+vLq/qIEJxtDjq/rZl/jaqVoqzTo/6XlPEXYvOnQnGEmoECAUZH59z/C7JF59vdLUR9t4RKOWyz2VAKYc5fovC73AhYTG8VZZ+DSkubfsN8KzFtt1PZTaoRSDHa3NKmxP X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2438.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(53546011)(6506007)(478600001)(71200400001)(316002)(2906002)(186003)(66446008)(66556008)(76116006)(66946007)(66476007)(64756008)(110136005)(26005)(54906003)(86362001)(9686003)(55016002)(83380400001)(5660300002)(8676002)(33656002)(8936002)(52536014)(4326008)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: lneQnY585tig9KNjVv19V57cOoDwiA+fgCe2uiM+cJ4rJFzjlw87B3MdLDrjFfNiTADsUMOvqOSEyOwqDd+ScOJo4XJfmIS6AdmmAANetB43NyVDjlg9vuMkkg0HuTPxeooZyMonUbO9kfaNShWERAaR4WJKDCr/aQjDZb2duPXDdutkIjflWvwE9UZDt3771TZlSNsmWRthkOUhwYcDwR/EHgobqXHTSsd1p7QptmAFVPOsA2XoS5LGaLJOGs7fsVfLuGZ0KSCaFcdefAKHgS+e/ZwdlveKHDxwdrs9dTgbvAZg+5PFiA5UEV+yFe4TBne7doUXu1z2edwYIz5Typ3rNGvDxT/rKC0dm58YIt8o0G7Hjpw8OS9BHfCXny9HW5hSllgWP6K5fglC1ib1rgjiBSGhDvSVdttDxjmposwrTQsWU39PBskVKKYDIMbH+wZH2XhNxHGRWVN0H+zkGNTNmJtC0nGGjMjl05c4tJ3Yu4Z/xEEgoLT7z3kOlESmb+U0FHpjRifXwoL27BcLbm1g3rRHhjS8kEzWsDzoqtD/6HjWs4u5TtVY7eWQLAoHl99wCh2/qoFJFOzwCkDduUrsz6fKZ4A4mMlp4K303NU8qPBlZE/Q3+gXK5JdvNBnGUug9pvWdNcuuWCg+o0Gew== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5687 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f4c64654-e71f-4e51-4264-08d83db88e78 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VJ4HTpwkdJ+PNzB4BFSZnlLbvWRXjHI7/mLJBtBXtSZo+ESGoCO9vnbig+kxdKetNFqdrY8hTbdXov/Lq4QqGGdHdh4ippte7eGfQho70KMYramV3alDHS6SrBqCZT2zP12BquNkXAvuAKVrrZ/JO2vokQ4aY9kxig+ccn95xv6iNtU1jCOiBzNlWzvVL6CkcM+KHPLNyxo6kV8BDHhddoxWpwMaYXFg//hppu8+2pMTN/+7IQ6maXVPatiEgiC9S4Xb+5xwvZdlLoKXB4kqh04H0qS+u7yZfqezbudvp2qsQKawQ7DJR5ey+gEm5Y4RwIfyv8tTtBKLaIAxwdzJvBMXPeJfOUW6ER4aKDtcXxza955YTLoh2a6KehJsgXaIVvB+9qMZisISuoygRdk7yg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(376002)(396003)(346002)(46966005)(356005)(9686003)(82310400002)(81166007)(36906005)(110136005)(186003)(2906002)(54906003)(478600001)(8676002)(8936002)(5660300002)(82740400003)(55016002)(47076004)(316002)(26005)(33656002)(52536014)(336012)(4326008)(70206006)(86362001)(83380400001)(6506007)(53546011)(7696005)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2020 05:37:01.7400 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17f5a49b-8374-4532-471e-08d83db892bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1899 Subject: Re: [dpdk-dev] [PATCH 20.11 00/12] add max SIMD bitwidth to EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, I have not reviewed other patches in this series yet. Few questions inline= . > -----Original Message----- > From: dev On Behalf Of Ciara Power > Sent: Friday, August 7, 2020 10:59 AM > To: dev@dpdk.org > Cc: bruce.richardson@intel.com; Ciara Power > Subject: [dpdk-dev] [PATCH 20.11 00/12] add max SIMD bitwidth to EAL >=20 > A number of components in DPDK have optional AVX-512 or other vector code > paths which can be selected at runtime. Rather than having each component > provide its own mechanism to select a code path, this patchset adds suppo= rt > for a single setting to control what code paths are used. Do you mean that all the components will have to use AVX-512? IMO, different libraries might behave differently to the use of different v= ector sizes. Are we taking away the ability to use different vector sizes f= or different components. > This can be used to enable some non-default code paths e.g. ones using AV= X- > 512, but also to limit the code paths to certain vector widths, or to sca= lar > code only, which is useful for testing. >=20 > The max SIMD bitwidth setting can be set by the app itself through use of= the > available API, or can be overriden by a commandline argument passed by th= e > user. Arm platforms support SVE (scalable vector extensions) feature. With this f= eature, the code is agnostic to the vector size. i.e. same code can run on = various vector sizes. There is no code yet in DPDK with this feature. But, = it will be added in the near future. It would be good to handle this now so= that we do not have issues in the future.. >=20 > Ciara Power (12): > eal: add max SIMD bitwidth > eal: add default SIMD bitwidth values > net/i40e: add checks for max SIMD bitwidth > net/axgbe: add checks for max SIMD bitwidth > net/bnxt: add checks for max SIMD bitwidth > net/enic: add checks for max SIMD bitwidth > net/fm10k: add checks for max SIMD bitwidth > net/iavf: add checks for max SIMD bitwidth > net/ice: add checks for max SIMD bitwidth > net/ixgbe: add checks for max SIMD bitwidth > net/mlx5: add checks for max SIMD bitwidth > net/virtio: add checks for max SIMD bitwidth >=20 > drivers/net/axgbe/axgbe_rxtx.c | 3 +- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++- > drivers/net/enic/enic_rxtx_vec_avx2.c | 3 +- > drivers/net/fm10k/fm10k_ethdev.c | 11 ++-- > drivers/net/i40e/i40e_rxtx.c | 19 ++++--- > drivers/net/iavf/iavf_rxtx.c | 16 +++--- > drivers/net/ice/ice_rxtx.c | 20 ++++--- > drivers/net/ixgbe/ixgbe_rxtx.c | 7 ++- > drivers/net/mlx5/mlx5_ethdev.c | 3 +- > drivers/net/virtio/virtio_ethdev.c | 12 +++-- > lib/librte_eal/arm/include/rte_vect.h | 2 + > lib/librte_eal/common/eal_common_options.c | 63 > ++++++++++++++++++++++ > lib/librte_eal/common/eal_internal_cfg.h | 8 +++ > lib/librte_eal/common/eal_options.h | 2 + > lib/librte_eal/include/generic/rte_vect.h | 2 + > lib/librte_eal/include/rte_eal.h | 31 +++++++++++ > lib/librte_eal/ppc/include/rte_vect.h | 2 + > lib/librte_eal/rte_eal_version.map | 4 ++ > lib/librte_eal/x86/include/rte_vect.h | 2 + > 19 files changed, 184 insertions(+), 32 deletions(-) >=20 > -- > 2.17.1