From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CF64A04BC; Fri, 9 Oct 2020 18:15:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E53D1C434; Fri, 9 Oct 2020 18:15:40 +0200 (CEST) Received: from mail1.bemta26.messagelabs.com (mail1.bemta26.messagelabs.com [85.158.142.115]) by dpdk.org (Postfix) with ESMTP id 0C9E81C243 for ; Fri, 9 Oct 2020 18:15:39 +0200 (CEST) Received: from [100.113.7.48] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-4.bemta.az-b.eu-central-1.aws.symcld.net id B8/EA-08519-9AC808F5; Fri, 09 Oct 2020 16:15:37 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKJsWRWlGSWpSXmKPExsWSoc9prbuypyH e4NcmcYt3n7YzOTB6/FqwlDWAMYo1My8pvyKBNWPN3NesBS3CFfeOrWdsYNzF38XIxcEosJRZ 4tTnZ+wQzjEWiWOXpkI5exglbv5oY+ti5ORgEdjKLHGglRckISQwl0li+/HLbBDOI0aJD9dWg 1WxCZhIvNrbzARiiwgYSmxduJUZxGYWUJT4tGASSxcjB4ewgK7ErvdeECV6Ekumn4Yqt5JYOv U3O8QyFYknB16DxXkFEiWO9V5ngdg1i1Hi95t3rCAJTgEXiZubt7OA2IwCshJfGldD7RKXuPV kPlizhICAxJI955khbFGJl4//sUK81scosXrHRVaIhJXE77aFULasxKX53Ywgh0oI+EqcnmwE EdaS2Nn8mw3CzpG4tXI9G0SJisS/Q5UQYTWJG286oFbJSazqfcgCYctIPLixHRxWEgJ7mCX+b /gO5bwBhuiKTpYJjHqzkNwNYetILNj9iQ3C1pZYtvA18yxwYAhKnJz5hGUBI8sqRsukosz0jJ LcxMwcXUMDA11DQ2Ndc11DI0O9xCrdJL3UUt3k1LySokSgrF5iebFecWVuck6KXl5qySZGYIp JKWSv3MG49s0HvUOMkhxMSqK8Xk0N8UJ8SfkplRmJxRnxRaU5qcWHGGU4OJQkeH27gXKCRanp qRVpmTnAdAeTluDgURLhPd0FlOYtLkjMLc5Mh0idYtTlmPBy7iJmIZa8/LxUKXHe+yBFAiBFG aV5cCNgqfcSo6yUMC8jAwODEE9BalFuZgmq/CtGcQ5GJWHeFSBTeDLzSuA2vQI6ggnoiNe7ak COKElESEk1MC2IXBNwoTl+8o+s6Ij0ispmBvapVdcaAlMbBR6mX/d8sImncZX0nb9zXCb/WKf LbXfv3d3bTwNrXz5K1dgsquhVe1w+8GHbl9PtU81XTjj15sSPorL9BbUxhy/mSuyvMku5tbV0 x1z/T08XV0ewRHf7n2432Zfzk4HFrEH4zBrDHtXUyarLJ1x9+VIwMiyh9mOIYa/yQo0vou82z XrioLW2UfLzigyWcvPs0gVH2hgdH32YwSjf2SKmNMX/Vorhz1jeo0E8b35zzfYRNX7LGqm44C u3yx5PxjM8U1R2FVw8o6gZvWiF1uJzmmWn2ZL8XjI86z+t90tHKfTyCsW1h3cV7J7wftI21i9 /ljtUpCixFGckGmoxFxUnAgBzvMHmOAQAAA== X-Env-Sender: John.Alexander@datapath.co.uk X-Msg-Ref: server-20.tower-246.messagelabs.com!1602260136!1798039!1 X-Originating-IP: [104.47.9.59] X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass X-StarScan-Received: X-StarScan-Version: 9.60.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11979 invoked from network); 9 Oct 2020 16:15:37 -0000 Received: from mail-ve1eur03lp2059.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (104.47.9.59) by server-20.tower-246.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 9 Oct 2020 16:15:37 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EwnqpsX331EBpyvaH2n+MBjINUhYPRqD/RgFcNYhCO8JbhDqjE3zB4tN6MLdcbl6dwCnaWSjos3RIU68QjtrTknddWdeG6qONoHDozyw/LLIlEqfnu/xHqxHGYor9wdZD+/3F9G0XUSI0SzxOQiqb5KqvA135clkVqYMwQD6EAe/Pq4Rw+nFrmrP9h5ipY4pSFKGTZIa7IS8l+HxLo4I6z2WgkxXI0XsrV2SOV1OONX7bZhUThVCdFL5p+rJS4Q+EP6v9D/cSGEriJXb9X2q931TtaEahOJRsk6IpjMn1GfpmWOzt+0WckK7f6HOqqUBJdLFjEtHkQw8xxiVykjedQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SaKF5lGeQ/sbweAzzqVp96OkP24w2Lu7TZ5iXL3ON2c=; b=c9tKGB/Hk2OVvTilI8G8B/VMGFY2PfRf8RgNB5h9YjR5pfP5DS2PpNEa0Zmx5Ys6wt6P1YqLLnM09wlI4LIwrB9Be6R9nS4pfZrhGAWrASpAnJIeFNK9E5tt5QFV8jB3pqabgxxyY0DVxonOB5UIb3UeSotUlUh2l681ZmaIvrdeCBy7jcEd5qldO64sxp9qgmC1xVqapcbY52LrD7knk/20biyMkuNcZVN6MADxzIlVqshpdPVb1b9jfQpIkYNXsH2ilWceeuyafS8NQowLVQUUuGEg7OM/58EZmE6CbiUBrGH0B8z+CRqTRGJE44h6U0Q/M9x3zcHjfYg+aMijuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=datapath.co.uk; dmarc=pass action=none header.from=datapath.co.uk; dkim=pass header.d=datapath.co.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datapathuk.onmicrosoft.com; s=selector2-datapathuk-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SaKF5lGeQ/sbweAzzqVp96OkP24w2Lu7TZ5iXL3ON2c=; b=sOkmSXwQCMBC21S5c0oZHxy4i+ybGABcrCi281PUiIi5PKcpLL0lctUQA+pXkYDYJ9pESmcqHJMGhif/TNZAU14NmTVIJDzK+movLxcat5TU72iWX0ENKeFHrCIk2Ta2nWR3PM3H5JKYkom2rUAuz3cR/m/l9eFYOEhVrpWd1Vw= Received: from DB6PR0902MB2072.eurprd09.prod.outlook.com (2603:10a6:6:8::23) by DB8PR09MB4089.eurprd09.prod.outlook.com (2603:10a6:10:121::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Fri, 9 Oct 2020 16:15:36 +0000 Received: from DB6PR0902MB2072.eurprd09.prod.outlook.com ([fe80::70d7:fdfb:2fe6:48e2]) by DB6PR0902MB2072.eurprd09.prod.outlook.com ([fe80::70d7:fdfb:2fe6:48e2%7]) with mapi id 15.20.3455.026; Fri, 9 Oct 2020 16:15:36 +0000 From: John Alexander To: Bruce Richardson CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] Meson Minimum Version Thread-Index: AdaSfb8FZCNtfAcdQI2T9PwuxrwZOAL13QIAAAAVi1A= Date: Fri, 9 Oct 2020 16:15:35 +0000 Message-ID: References: <20201009155942.GE1474@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201009155942.GE1474@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2a00:23c4:403:e001:e1ef:1bc4:4be0:d23e] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 092a3010-de09-46e2-167f-08d86c6e8e3e x-ms-traffictypediagnostic: DB8PR09MB4089: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UYASkYO6sNCotCIdQwSOGsJBN+SB/nV1IQfTuBO2cmhSIG/abmMJXmh81agpTi5tLFLm5nBaN6f4rB4q1q93m9vA1Ux2lp37/KW1tYe9Tff0+Ey+ZuNgeMN+pHmy5+mtHk5MjJAyL3SpwDgGu4oTRGmigDo9Dl4+cCCCbY3Rg1pl9D8JpY8f5CBpx8fxxWiEoDWfXv/Mx7LFvgJqu+Uv4l/D5QTXpomszY9JQQhwODKC4It5sDWdW4+mPQBeBkxVpXpy8NOyGdL2GJF3yOG5RW17N6AnnjCo51T6iMlDygNbUZZMt2rKibH9oosFM/1KxKow59OOiz9JYwsZOEtVvMdTOAAPAZwiRM/MWsLG5iEzEOXdw+x7W3lIrTuKNRolnR86t35czV00zh/oguR0Xw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0902MB2072.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39840400004)(366004)(346002)(376002)(966005)(186003)(52536014)(6862004)(478600001)(66446008)(66476007)(66946007)(316002)(66556008)(55016002)(9686003)(33656002)(71200400001)(7696005)(5660300002)(76116006)(64756008)(8676002)(86362001)(4326008)(83380400001)(83080400001)(2906002)(8936002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6svZvq+HP1bo3UG8VRjfCfI0iRnYmVaDWP+RWTOQZI9GbhqARZuidzNMEU7xcGEchGpPjFTrBhrhGRbo38gDWw5kaClhYUSk5ZdcqS8BE37cSpBMPglcsi6uDIVvdcBDksT9ujlTtaj9VTCimkBpRdFj+h8v8Y5IEKv//G5fj3R25UkpSEFzpc/Nb3sj3CHSO6cUh25lzRhG6AF9A98hsu7mR3HF3NQdpi68wxLaLoSL5jpvQ8W9+4FGqEeidBy/Jwq+dMVpMdrHenA/8t0LI/GToS/u28+l0mJASJ+kN/GtnOk+6hjG7lEbeZgMl1ndb7V37iay9zrABDEAF+BJrgMUsyWFjgExfdpOL+sqEhbjIt0pS/OpCa4uBtmwUxF0lL7k/v9vmzN9Buwc6uWMR1nkDCZ0Zy/dP6rCwI3LImcELT4AGowBwatI6SLCVDZ74Bp94TEeSwmgQLLWi8A0NaHGUoJTiouDAxd9cnAFLjyVqfO13vjPgpbEWRHlFXZnFo+YNSMswDGC0jErzpzbeY5mqWqYK1pQ1GeqMD5zYD2W9Hm6cvrmK2SPbu1wBIbEUyyC/m16MbFUiW41XbzSaaGguwiH98tPbtyUWyXUdLa/Ph3dr9KKbWVycQqs8PdEFcHqbPHd/04zyS8akStc7V+OUDhxsnssdBwhHxkYVYUCrzBBpcXb5uXKKR7xFS9O8qhjePhFNrQW06JifIpf1A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: datapath.co.uk X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0902MB2072.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 092a3010-de09-46e2-167f-08d86c6e8e3e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 16:15:36.0092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 102e0f24-523c-4823-a9ce-5a8ebc4e32a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4AH6QWkoDCrFRrvgqj8dTv4fz1LulKgxqZH1Z6jEmzg8Z0hgCgrEaY9Ll+1ijIR7Bp5JI8Wtc0XkNoQCgQumlVDDvuSEa+kyUW9pQEt/XDw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR09MB4089 Subject: Re: [dpdk-dev] Meson Minimum Version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Thu, Sep 24, 2020 at 02:22:03PM +0000, John Alexander wrote: > > Hi, > > > > I've submitted a patch that uses new features of Meson, specifically th= e > directory patch aspect of the subproject feature. This requires a minimu= m > Meson version of 0.55.0. How do we go about getting the community to > accept a more recent version of Meson and getting the Travis server > upgraded too so the CI builds succeed? > > > > Patch link for reference: http://patches.dpdk.org/patch/78675/ > > > > Kind Regards, > > John Alexander. >=20 > Hi John, >=20 > this meson version change came up for discussion at the last DPDK technic= al > board meeting, and some concerns were expressed about the jump in > version and how it might impact those trying to package DPDK. >=20 > However, looking at your proposed patch, I wonder though if we really nee= d > to globally bump the meson version, and whether we can limit the > requirements to just windows builds - which is what your patch targets. > Would the following change to your patch work for you? It keeps the > minimum meson version at 0.47.1 but then later does a windows-specific > version check, printing out an error message if requirements not met? >=20 > /Bruce >=20 > $ git diff > diff --git a/config/meson.build b/config/meson.build index > 69f2aeb60..fd48c9828 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -14,6 +14,11 @@ foreach env:supported_exec_envs > set_variable('is_' + env, exec_env =3D=3D env) endforeach >=20 > +# for windows, we need meson 0.55 > +if is_windows and meson.version().version_compare('< 0.55') > + error('Require meson 0.55 to build on windows') endif > + > # MS linker requires special treatment. > # TODO: use cc.get_linker_id() with Meson >=3D 0.54 is_ms_linker =3D > is_windows and (cc.get_id() =3D=3D 'clang') diff --git a/meson.build b/me= son.build > index 9e061c73b..7dba3264e 100644 > --- a/meson.build > +++ b/meson.build > @@ -8,7 +8,7 @@ project('DPDK', 'C', > files('VERSION')).stdout().strip(), > license: 'BSD', > default_options: ['buildtype=3Drelease', 'default_library=3Dstati= c'], > - meson_version: '>=3D 0.55.0' > + meson_version: '>=3D 0.47.1' > ) >=20 > # set up some global vars for compiler, platform, configuration, etc. >=20 Hi Bruce, Thanks for the workaround suggestion. That certainly works for me. Kind Regards, John Alexander.