From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A188EA04E6; Fri, 30 Oct 2020 20:57:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5283E72E9; Fri, 30 Oct 2020 20:57:33 +0100 (CET) Received: from mail1.bemta26.messagelabs.com (mail1.bemta26.messagelabs.com [85.158.142.3]) by dpdk.org (Postfix) with ESMTP id EADA772DF for ; Fri, 30 Oct 2020 20:57:30 +0100 (CET) Received: from [100.113.0.171] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-3.bemta.az-a.eu-central-1.aws.symcld.net id 55/DB-63714-9207C9F5; Fri, 30 Oct 2020 19:57:29 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFJsWRWlGSWpSXmKPExsWSoc9kpKtZMCf eYIuXxbtP25kcGD1+LVjKGsAYxZqZl5RfkcCa8X3lKdaC6UoV8z8/Zmpg3CrexcjFwSiwlFni 5ucjLBDOMRaJw2dXsUI4exglbv5oY+ti5ORgEdjKLPFwuQVIQkhgHpPEusc9bBDOY0aJY++PM 4NUsQmYSLza28wEYosIxEqcPd3LDmIzCyhKfFowCWgHB4ewgJXE9pV5ECXWEs+v3GSBsK0kbj 86zwyxTFXi8veXjCA2r0CixJo3z8BGCgkUSHx8cgbM5hSwk1h2aCEriM0oICvxpXE1M8QqcYl bT+aD1UgICEgs2QMxU0JAVOLl439Qn01ilLh8fAorRMJK4uSzy2wQtqzEpfndjBC2r8SxlwdY IGwtiT87X0INzZE4uvQ/O8gvEgIqEv8OVUKE1SS2XzsPVSInsar3IVSrjMSDG9vBYSUh8IdJo uvRWSjnMbPErM2TWScw6s1CcjiErSOxYPcnNghbW2LZwtfMs8CBIShxcuYTlgWMLKsYLZOKMt MzSnITM3N0DQ0MdA0NjXWBpKmhXmKVbqJeaqlucmpeSVEiUFYvsbxYr7gyNzknRS8vtWQTIzD BpBQyTN/BuObNB71DjJIcTEqivE75c+KF+JLyUyozEosz4otKc1KLDzHKcHAoSfDeygPKCRal pqdWpGXmAJMdTFqCg0dJhDc2FyjNW1yQmFucmQ6ROsVozDHh5dxFzBw33y9ZxCzEkpeflyolz hsCMkkApDSjNA9uECwJX2KUlRLmZWRgYBDiKUgtys0sQZV/xSjOwagkzOsIcitPZl4J3L5XQK cwAZ2yMAnslJJEhJRUA5OUb8aOGaYm06MFfmwo9FSbtCGUb/+e6PaaQ+sWBeiv7Pj80/n389o /8vvmP1wy06LxeEncnjNu/IzxU5iezlu99W5PlDefh+eljNetJ670/LvXuVebL3J2z99q90dl 875FXLn0lC++8kbMawGrgKDvn0M2rykKqf/9w/Dro8KQE/u3/JXwnLx+ovKbpx7zfpl5qK3n4 7/yN1an4LnRm89Vu4/Umm1hLDu54tN7VYNtk3meqmqrH1ee1sWXU1oulFzG//j3Re2Xnpn/PS 1X/s1Y0cuuUL9lEtvE9912SqskO8v5PjXplaU9/GydpC+h6/H8wMzbp/yjZ0kclg38sPqiVaX q7MscBmsvXjm9k2WrEktxRqKhFnNRcSIAKP237z0EAAA= X-Env-Sender: John.Alexander@datapath.co.uk X-Msg-Ref: server-8.tower-229.messagelabs.com!1604087848!660016!1 X-Originating-IP: [104.47.2.50] X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass X-StarScan-Received: X-StarScan-Version: 9.60.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 9479 invoked from network); 30 Oct 2020 19:57:28 -0000 Received: from mail-db5eur01lp2050.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.50) by server-8.tower-229.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 30 Oct 2020 19:57:28 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GXxrOkv1uqrALBej/zPG0z8VQgN1Ekh/27sj4zvhZ7zSW8C5veyKyqIu7DBEmv6N7op61zwDKWrLTwbJ23/NW9NLeWtV1/QmsBsPYwbQtNmCQ4zX/DDcnNBZ84zeLzCAlQfJxDUeDuTKB7vW8sYwLiAf+npaoB5OmadmukaQaJaSDmsbIDOlXJhN5xh0h2SDuBpXwYPwOBgBKNkK/xIocqc++gxKGrfoe2PIoeuMfZahn4aAFit3FHJX0UjWTNWRC2fV72XtV3ghJOVgMnvJGXUYPSk2VGSla56kRee4uEQBd1t7IV6IcDZg5pxAv7bfeWB1PvcqbK1XjHPKxWCQrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RTsIrA8AyCjM14I2GvEBDJnyDxa+LzVqy3VmaPwCMJ4=; b=LxjpfKO0yltnj7qItr3IJqRbmhNJ1Af6JRSQFhDPXf162gZXDEqrkV+IXw1ZxhaTZSSL64Y3kuc+Je/CVSzXmbDbG/ZElkRxETn15IZPXkda3pODaGvlQIrOth4YydbOiwwqnFYKbtFwD48E0ljHUIWDhQj9BDzjGp1jTDiSGZ7K4pGCg81TjpvzSyR8cxPD/zosQyQNwuiCl1nvZQCtKJcdE6JeSNAW6i+YBt6amYmBjX7BIu9X/T4a7HdNvqwtXlFgBhTzRRsyLRAAGDSdKKjhEcc/e691qMH7dC/HzGLKgowweJm41NJMcg0lVeAFznVt4zrceRGeSW43eSOAjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=datapath.co.uk; dmarc=pass action=none header.from=datapath.co.uk; dkim=pass header.d=datapath.co.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datapathuk.onmicrosoft.com; s=selector2-datapathuk-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RTsIrA8AyCjM14I2GvEBDJnyDxa+LzVqy3VmaPwCMJ4=; b=IwqEY9YYlrGZWqBo4kE+AP7ClJWs6EtbhvRcCo67LiXaOocl3UNza7XVgKT3NvxOjjr8QCQR6SJVBbknPZX7ZpGEELlZgzc/JzckPhFHHmN9mAGnHvq5f7sugU5L8KZ+mu4ZOQsgz59jzWFqkQdb99Vaa9ULumvwWgF4L4YfmsI= Received: from DB6PR0902MB2072.eurprd09.prod.outlook.com (2603:10a6:6:8::23) by DB8PR09MB3451.eurprd09.prod.outlook.com (2603:10a6:10:105::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 30 Oct 2020 19:57:25 +0000 Received: from DB6PR0902MB2072.eurprd09.prod.outlook.com ([fe80::70d7:fdfb:2fe6:48e2]) by DB6PR0902MB2072.eurprd09.prod.outlook.com ([fe80::70d7:fdfb:2fe6:48e2%7]) with mapi id 15.20.3499.029; Fri, 30 Oct 2020 19:57:25 +0000 From: John Alexander To: Nick Connolly , Bruce Richardson CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] windows: minor build fixes Thread-Index: AQHWruUxPDMpcA+IBEOs3DpH4qyRqamwa1iAgAAjNoA= Date: Fri, 30 Oct 2020 19:57:25 +0000 Message-ID: References: <20201030174617.1958-1-nick.connolly@mayadata.io> <20201030174617.1958-2-nick.connolly@mayadata.io> In-Reply-To: <20201030174617.1958-2-nick.connolly@mayadata.io> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2a00:23c4:403:e001:9184:552d:56de:7c18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1e1541b-dd4c-47ac-87c9-08d87d0e05fe x-ms-traffictypediagnostic: DB8PR09MB3451: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R9WK5CdHee7+yFbKMYl97haeNZyBIHd83z7gGgboamsJ1k+TsO6yaqWbRxFtsLA+zJD2TUEJMSArrANRpXh3lmZEqeu2XOBY8I8eegCYsZD/RyeiGoKse3mpUBFw1DWOtqH4tb7wRlTIV5jfiqE09woMOD0GhVUubSILIBbXx0V0s/oCPtGGR3sUZtJjEpmO6HnOSAoF9Q+LTaqCq7Nissr7Bb6hCPSEVGoC6xagn71orLDzOSX+6pOhKfrZIs5hdlcM+QRrhZpHZLFa4n46MaBHbasHcGsep7Y4trJTrN6zYuWi1ThJty9C7ii0vljII1YLxbnFvvJ/0nQty/qxgQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0902MB2072.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(346002)(376002)(39840400004)(478600001)(66476007)(66556008)(110136005)(2906002)(76116006)(83380400001)(8676002)(86362001)(316002)(9686003)(33656002)(53546011)(66446008)(64756008)(71200400001)(8936002)(55016002)(4326008)(7696005)(6506007)(5660300002)(186003)(66946007)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Ne3tBGxEU37h2oWCvs3sPAYF6YJ0dhccgP2sZmzLY0YeDW2aJcjV6uY/W2X+R1uRjdJkiEBzZ7RbnQH6UTv1t6E/bTntG4mrLhC+qmSu4vKdZEUsVyyS/WoIJbrAhE1ALkdJgqo07OaubZCuhQpBjFcXbe2DXutstQAc6OCXW+Z8EdkwzhQIiPKlNt1+jhuGWBFxZ4tCfXxbcotPD4xNQUqzpe7yzb/ezBh06nJiCsdunEKA0EMSFO62P/Cb0cQbF/frfqSSt7rpRDtsXSCtZ2xtwCZkyaHPZR+FJwNeKfQkLF8duinHYz6LW1RO0hPsq11iY27HgWhL8prYYozAWZUeGC6LILhUWNRyue06XxtGCt3wHa98bgMNUOkSZ19xiRB8i9AYGZJnr5L6qlkYH8nt46ZVGs73+/zbJMXnDeQnP3d7tx34T2TtCCX/gKpgqfMcNRfO4gVl5Hj4qP3bYq/U2BqKaf6ycarvCSWrCmLopkmeDOHeved6I4G3Pg/j5sEbJkDZoEePaN08ArzVJjx4BmArJsaF/JIxrxpzwIP6iKU+R3jW1dXkwDviSVB12ReZBjfcOcvRP4Gp3BBsCxe8OPD7jWcQbmlrcemh3WRzjpWQRzOwpt3QHmlR9REhAfFu386BEq2iZGzpU8RF1hOHTeYFtm38v7YIDnWQBuxj1V0W28+Sz3Y+or3DBDRAMjbxuCMcwOIUD6RUf5Drlw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: datapath.co.uk X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0902MB2072.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1e1541b-dd4c-47ac-87c9-08d87d0e05fe X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 19:57:25.5336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 102e0f24-523c-4823-a9ce-5a8ebc4e32a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xgqh6zsQCbG1I03PtD2RVhPMWEEeN8cX+q6dZE/qr74DtCZ1UIVd7DLcZFA4wCCOjU+z2MPalzLjOMZmUN7iVJyI6pa3CbHi2UlijVa2rqc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR09MB3451 Subject: Re: [dpdk-dev] [PATCH] windows: minor build fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Nick Connolly > Sent: 30 October 2020 17:46 > To: Bruce Richardson > Cc: dev@dpdk.org; Nick Connolly > Subject: [dpdk-dev] [PATCH] windows: minor build fixes >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick > links or open attachments unless you recognize the sender and know the > content is safe. >=20 > Don't run symlink-drivers-solibs.sh as part of 'install' because Windows > doesn't support shell scripts. >=20 > Meson versions >=3D 0.54.0 include support for handling /implib with msvc > link. Specifying it explicitly causes failures when linking against the d= ll. Tested > using Link 14.27.29112.0 and Clang 11.0.0. >=20 > Signed-off-by: Nick Connolly > --- > config/meson.build | 8 +++++--- > drivers/meson.build | 6 ++++-- > lib/meson.build | 6 ++++-- > 3 files changed, 13 insertions(+), 7 deletions(-) >=20 > diff --git a/config/meson.build b/config/meson.build index > 258b01d06..a29693b88 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -57,9 +57,11 @@ eal_pmd_path =3D join_paths(get_option('prefix'), > driver_install_path) # driver .so files often depend upon the bus driver= s for > their connect bus, # e.g. ixgbe depends on librte_bus_pci. This means th= at > the bus drivers need # to be in the library path, so symlink the drivers= from > the main lib directory. > -meson.add_install_script('../buildtools/symlink-drivers-solibs.sh', > - get_option('libdir'), > - pmd_subdir_opt) > +if not is_windows > + meson.add_install_script('../buildtools/symlink-drivers-solibs.sh= ', > + get_option('libdir'), > + pmd_subdir_opt) > +endif >=20 > # set the machine type and cflags for it if meson.is_cross_build() diff= --git > a/drivers/meson.build b/drivers/meson.build index 4bb7e9218..6b50f7238 > 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -186,8 +186,10 @@ foreach subpath:subdirs > lk_deps =3D [version_map, def_file, mingw_map] > if is_windows > if is_ms_linker > - lk_args =3D ['-Wl,/def:' + def_fi= le.full_path(), > - '-Wl,/implib:drivers\\' += implib] > + lk_args =3D ['-Wl,/def:' + def_fi= le.full_path()] > + if meson.version().version_compar= e('<0.54.0') > + lk_args +=3D ['-Wl,/impli= b:drivers\\' + implib] > + endif > else > lk_args =3D ['-Wl,--version-scrip= t=3D' + > mingw_map.full_path()] > endif > diff --git a/lib/meson.build b/lib/meson.build index 1bb019720..ed00f8914 > 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -157,8 +157,10 @@ foreach l:libraries > output: '@0@_mingw.map'.format(libname)) >=20 > if is_ms_linker > - lk_args =3D ['-Wl,/def:' + def_file.full_= path(), > - '-Wl,/implib:lib\\' + implib] > + lk_args =3D ['-Wl,/def:' + def_file.full_= path()] > + if meson.version().version_compare('<0.54= .0') > + lk_args +=3D ['-Wl,/implib:lib\\'= + implib] > + endif > else > if is_windows > lk_args =3D ['-Wl,--version-scrip= t=3D' + > mingw_map.full_path()] > -- > 2.25.1 Hi, Do we know what the motivation to rename the import library for the Windows= build was in the first place? I've tried removing the renaming of the imp= ort library completely in the Windows build and the build produces valid ou= tput (a valid DLL and paired import library is generated for each RTE lib u= sing clang build); The meson version test addition may be unnecessary here? Kind Regards, John Alexander.