From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B806A04A2; Wed, 13 May 2020 16:06:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 629861D60D; Wed, 13 May 2020 16:06:25 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10065.outbound.protection.outlook.com [40.107.1.65]) by dpdk.org (Postfix) with ESMTP id 70C8F1D60B for ; Wed, 13 May 2020 16:06:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RJYHACanbnnpfUCGzkca33EpqII8BY6EYxm1XosRvklM5ZpShiyCBhuHWhUgcX/6tzF+owju5Lli8AW3gozHtoItyTfmepT6GeO3SCSW7bbnBhiCFwj8mCjD745WfxDvJnwr1mag4AQMcJuE7D3JyUamMOgWjLatC5iKSsjX6L5X2k8R0Z2sMGmL7/P1akYetHyZ/ZhB4n0wDXulDsjFsCVOFpk2pFpWEPi9jPvfIuDTCxxuRHIduK3F4bDtpIHzKR6C6tgdxQOwHo66ng8bFkstDHwXvNDZpx2qiarUw08eED69QA4dwN3Nj9BwK8efDAy2PUi8LW0PB9tVPkI+oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Ad4h6pOmoxB0vX10vS4qP5HUNmn+GDgQmAQOZwkQig=; b=VEfgnune9bDz6q5s958TPQOIDBZpEY69bF+a5InuLhheLFjzOM4kFYcxsssQ8tlBJbebRRBcNNAplkFqJ2urr8Dia1QbOJeqjQ3GHjEeyN2ZWSkCsmsnEOazYBzJbAe7XYzquwRCyOkTVICJ4drKtEE8MRA5VxqQ28zjluQaEdtjkgC+fdGy6zMGq96sE4imGcp7qgQhczrHexszzWuqEHxmRVdy3dGGIDNN1Ap9g6BlEWBXmuC/KyWoWkRujP0pvMEvCmJbab1dBQJCICutwE6vHZWXJuwh9340wQpH53YUZHybJWV9vT+pDhwp45pXMIAzG2ldkOTvdO5u/AWGXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Ad4h6pOmoxB0vX10vS4qP5HUNmn+GDgQmAQOZwkQig=; b=J7HSLDfK1VJ11BGBOxDmvjmZ4QuvDF0/o+nrbiCe06WIRk4IFKuKY49zFxucOSH/N1hDFVjfR55dksIT50mYjrOT0H33SEGNVgqU2knHkxKwCzAftriWOnildNJ8wDtBKpq6dpH0EwkLa/qDRuiFzsmlLBrCfCHvAvgSI6v0Sb0= Received: from DB7PR04MB4459.eurprd04.prod.outlook.com (2603:10a6:5:34::33) by DB7PR04MB4220.eurprd04.prod.outlook.com (2603:10a6:5:27::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Wed, 13 May 2020 14:06:21 +0000 Received: from DB7PR04MB4459.eurprd04.prod.outlook.com ([fe80::605f:aa16:db4b:1b71]) by DB7PR04MB4459.eurprd04.prod.outlook.com ([fe80::605f:aa16:db4b:1b71%4]) with mapi id 15.20.2979.033; Wed, 13 May 2020 14:06:21 +0000 From: "Hemant Agrawal (OSS)" To: "mdr@ashroe.eu" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section Thread-Index: AQHWKSqhYs/jBl74I0O8fAjVFMrYy6imDNLA Date: Wed, 13 May 2020 14:06:21 +0000 Message-ID: References: <20200512140100.26803-1-hemant.agrawal@nxp.com> <20200513132745.9006-1-hemant.agrawal@nxp.com> <20200513132745.9006-2-hemant.agrawal@nxp.com> In-Reply-To: <20200513132745.9006-2-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: ashroe.eu; dkim=none (message not signed) header.d=none;ashroe.eu; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [182.69.7.119] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f8d1772a-81d4-41fc-41d7-08d7f746d0be x-ms-traffictypediagnostic: DB7PR04MB4220: x-ms-exchange-sharedmailbox-routingagent-processed: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:923; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A5ZfyhulJUc2SRtjtn30L+f7XDlpy/LzHgMgYduy4dW3ZRLjddaqducLbocq7qJKy8kmVtGgusxmCDoWxmNcxybGgc+p2izw8+gHh+F7KpJH29rRKybEEc2KAqQG7QZA0lKTGc0g6JBf8Saiar/VfZJm175jXw3NDnH3XFHfFS28PtRaT68hKqhqGWXja7xa473u3sk9PB4UL5FjdfePg9XvdgqntHvv7U2XB3pHkC482e3voxZ+7jNqLt31lDqg7CLiJP1E2ezW7KaA6hHWAoSaTOtI8sX3HCUWq02oPDwry5+q7ifv6uJU0iwdWbvLzZmfrjBy5CbEwkpZD3HIIkrUlsE2+ZA0/4sOe7Z4GBHE9OIHlEHLC7L0HWxSM20kd0G4wPDr+q5AB6zGsH1wsy6JPCJn4w2tXa3Wz5Chpy0NLeEeugLJv6qHvjT3JRm3oCqLzKpViOTZMF7s2yao4M/nD7AbIz2STYblbOtwNNQhSxZCZxWILD66zlGajSjZkSa8iQEGxxVDBKkVSxLodw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR04MB4459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(366004)(33430700001)(6506007)(2906002)(64756008)(66556008)(66946007)(33656002)(71200400001)(33440700001)(55016002)(86362001)(76116006)(66446008)(66476007)(186003)(26005)(316002)(8676002)(5660300002)(4326008)(7696005)(8936002)(52536014)(53546011)(6916009)(9686003)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ghY0l6jP3fXnc+Vh7IrBnv4u6RTzOwqBA1OFj/gtjEs91wTFWCxmTJcrSCLf3BFAkyUbQallwH3CgHVN4itXnNcmCgjTwR9kX0MhpDJ8el2u9Hjvkf1TDCKWhfRsyYmavwMWoa2H51jbYQ3eY1BP2bHh6XCF7GjoHcLuq6YwBA/ck+9/pDMBXlMXO9Yyv4DatcXbtcD2W1LtFGEwnE6/reShBD9AKX5aPIGbBIjatBlPvkNRg7bf63qP/3d+fzmRu3+V8mRdQYDRG9WXKSGhi7FI5003SrcY2p+6jcrNd9lR+20U5UfvL3dJQJ335xAlktU9ipTpWgfR0LCxCA2XdWEp0kLhJg50coelWB2dDoGvit32yyK2J8csKOodiBcYxCKVWw8xg49GOIVw8kfaNr2/bQDQBsZ73BIBJ8Ln7wKOCDq1tvEuS0M7F35dQLsvVOaHq3B2FxqlzBjQd2E6htxWPl45Tcg5GC9Cfuh4/C0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8d1772a-81d4-41fc-41d7-08d7f746d0be X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 14:06:21.7525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8qRWdMeVK15XmQ6uc/3A3p7ni2Cc3i2ms/2ySa5h9FWadtJT67BJDfbPeTcC3DeclcKuYxmm8BPkhZ8C0ryUew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4220 Subject: Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ray, I could not find validate_abi using libabigail.abignore. Am I missing som= ething.=20 Though check_abi.sh uses it.=20 When I am checking with validate_abi.sh, I still see warnings. Regards, Hemant > -----Original Message----- > From: Hemant Agrawal > Sent: Wednesday, May 13, 2020 6:58 PM > To: dev@dpdk.org; david.marchand@redhat.com; mdr@ashroe.eu > Cc: Hemant Agrawal > Subject: [PATCH v3 01/12] common/dpaax: move internal symbols into > INTERNAL section >=20 > This patch moves the internal symbols to INTERNAL sections so that any > change in them is not reported as ABI breakage. >=20 > Signed-off-by: Hemant Agrawal > --- > devtools/libabigail.abignore | 3 +++ > drivers/common/dpaax/dpaa_of.h | 15 +++++++++++++++ > drivers/common/dpaax/dpaax_iova_table.h | 4 ++++ > drivers/common/dpaax/rte_common_dpaax_version.map | 2 +- > 4 files changed, 23 insertions(+), 1 deletion(-) >=20 > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore = index > c9ee73cb3c..b1488d5549 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -48,3 +48,6 @@ > changed_enumerators =3D RTE_CRYPTO_AEAD_LIST_END > [suppress_variable] > name =3D rte_crypto_aead_algorithm_strings > +; Ignore moving DPAAx stable functions to INTERNAL tag [suppress_file] > + file_name_regexp =3D ^librte_common_dpaax\. > diff --git a/drivers/common/dpaax/dpaa_of.h > b/drivers/common/dpaax/dpaa_of.h index 960b421766..38d91a1afe 100644 > --- a/drivers/common/dpaax/dpaa_of.h > +++ b/drivers/common/dpaax/dpaa_of.h > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include >=20 > #ifndef OF_INIT_DEFAULT_PATH > #define OF_INIT_DEFAULT_PATH "/proc/device-tree" > @@ -102,6 +103,7 @@ struct dt_file { > uint64_t buf[OF_FILE_BUF_MAX >> 3]; > }; >=20 > +__rte_internal > const struct device_node *of_find_compatible_node( > const struct device_node *from, > const char *type __rte_unused, > @@ -113,32 +115,44 @@ const struct device_node > *of_find_compatible_node( > dev_node !=3D NULL; \ > dev_node =3D of_find_compatible_node(dev_node, type, > compatible)) >=20 > +__rte_internal > const void *of_get_property(const struct device_node *from, const char > *name, > size_t *lenp) __attribute__((nonnull(2))); > +__rte_internal > bool of_device_is_available(const struct device_node *dev_node); >=20 > + > +__rte_internal > const struct device_node *of_find_node_by_phandle(uint64_t ph); >=20 > +__rte_internal > const struct device_node *of_get_parent(const struct device_node > *dev_node); >=20 > +__rte_internal > const struct device_node *of_get_next_child(const struct device_node > *dev_node, > const struct device_node *prev); >=20 > +__rte_internal > const void *of_get_mac_address(const struct device_node *np); >=20 > #define for_each_child_node(parent, child) \ > for (child =3D of_get_next_child(parent, NULL); child !=3D NULL; \ > child =3D of_get_next_child(parent, child)) >=20 > + > +__rte_internal > uint32_t of_n_addr_cells(const struct device_node *dev_node); uint32_t > of_n_size_cells(const struct device_node *dev_node); >=20 > +__rte_internal > const uint32_t *of_get_address(const struct device_node *dev_node, size_= t > idx, > uint64_t *size, uint32_t *flags); >=20 > +__rte_internal > uint64_t of_translate_address(const struct device_node *dev_node, > const uint32_t *addr) __attribute__((nonnull)); >=20 > +__rte_internal > bool of_device_is_compatible(const struct device_node *dev_node, > const char *compatible); >=20 > @@ -146,6 +160,7 @@ bool of_device_is_compatible(const struct > device_node *dev_node, > * subsystem that is device-tree-dependent. Eg. Qman/Bman, config layers= , > etc. > * The path should usually be "/proc/device-tree". > */ > +__rte_internal > int of_init_path(const char *dt_path); >=20 > /* of_finish() allows a controlled tear-down of the device-tree layer, e= g. if a > diff --git a/drivers/common/dpaax/dpaax_iova_table.h > b/drivers/common/dpaax/dpaax_iova_table.h > index fc3b9e7a8f..230fba8ba0 100644 > --- a/drivers/common/dpaax/dpaax_iova_table.h > +++ b/drivers/common/dpaax/dpaax_iova_table.h > @@ -61,9 +61,13 @@ extern struct dpaax_iova_table *dpaax_iova_table_p; > #define DPAAX_MEM_SPLIT_MASK_OFF (DPAAX_MEM_SPLIT - 1) /**< Offset */ >=20 > /* APIs exposed */ > +__rte_internal > int dpaax_iova_table_populate(void); > +__rte_internal > void dpaax_iova_table_depopulate(void); > +__rte_internal > int dpaax_iova_table_update(phys_addr_t paddr, void *vaddr, size_t lengt= h); > +__rte_internal > void dpaax_iova_table_dump(void); >=20 > static inline void *dpaax_iova_table_get_va(phys_addr_t paddr) __rte_hot= ; > diff --git a/drivers/common/dpaax/rte_common_dpaax_version.map > b/drivers/common/dpaax/rte_common_dpaax_version.map > index f72eba761d..ad2b2b3fec 100644 > --- a/drivers/common/dpaax/rte_common_dpaax_version.map > +++ b/drivers/common/dpaax/rte_common_dpaax_version.map > @@ -1,4 +1,4 @@ > -DPDK_20.0 { > +INTERNAL { > global: >=20 > dpaax_iova_table_depopulate; > -- > 2.17.1