From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6A02A0573; Thu, 5 Mar 2020 02:24:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BB862C4F; Thu, 5 Mar 2020 02:24:04 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40138.outbound.protection.outlook.com [40.107.4.138]) by dpdk.org (Postfix) with ESMTP id 371E12C02 for ; Thu, 5 Mar 2020 02:24:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E17OAjh12b+rQnJU0tcq9l1Jy5/JgdhXoGlSoCU5L+kU8S2mkGVA2C2qBq00Ytps07IX0GOJrSMPUC9WDZKbshKYNA1vbzgZmppVxlREtXUH+SaIQ20EQJMt51ss0QG0P/rGZUXOc8LIocsNTs307n1vH33F8fJXzw6PS0Sy/NvBBVcH+0MDI98VQCbxZCpMPmv0SBf0/uzhVxcLh310HC1U0B74sDitYDdtQYICSO5lGkUjcM4QZeCgjP7xmXEHMx8/f4Jz5vuacVpYBaFHtW//wxwKL+kTr2VG1NV9vBecFxgHKUZfkCbNedw+g5XfBjKIxi2nrDQAqG3eqsiUUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fibWZR+HGbfbEfDVdIW8ur2B9v+exrVy0Y4wZGXTnnM=; b=RZZoX6JuNgHb67eWWhngRf8WqHcHbRa9RsCXVKRD1O28xZMn+F0KQw8CzZeOUpYYK+NNYvGJkNH3Ns8RrrSdPocH3L5sm4lRs0V97FVxDkUiG3hV+rzwP1KXAQggGGzNNinqc53XFfF/ETGlt5LvwXZ7Mp8JGykOC5YzfVRcnWHOa1GsEujMYzLUBa0P+lIhXCh6NKl3rtIpgtew6mFbxawINmYcTNC5PF8Jdf3DgC9pwM5RRXDYX24trSC7NVKQ+BYMCeaV32V3MDRtCgZipGJS+mBsDcCPVQsgH+eCq0JDE//xReRnc2pC/BSk4Vepo0E/cbLo71k1Lrl90r0OBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom.co.il; dmarc=pass action=none header.from=silicom.co.il; dkim=pass header.d=silicom.co.il; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fibWZR+HGbfbEfDVdIW8ur2B9v+exrVy0Y4wZGXTnnM=; b=W4MR1hB6gwx6cWeo584UzsaIc+sBZrxlDBb/JPQKdOiM10BFDHEyqLqSYuLApOyiZHkQoCPg4AfpyalzG7G5yC60RmyAt7OPJpQP2HFMd4DL8DmLrcAmHkBurHBdvMPOb7rtghi0VQXjEtubCDzNp4n987S5F70YVUBbKSww588= Received: from DB7PR04MB5196.eurprd04.prod.outlook.com (20.176.234.140) by DB7PR04MB5098.eurprd04.prod.outlook.com (20.176.235.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.14; Thu, 5 Mar 2020 01:23:59 +0000 Received: from DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::a400:f6b9:34b1:ed]) by DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::a400:f6b9:34b1:ed%5]) with mapi id 15.20.2772.019; Thu, 5 Mar 2020 01:23:59 +0000 From: Xiaojun Liu To: "Wang, Xiao W" , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" , "Ye, Xiaolong" , Jeff Zheng Thread-Topic: [PATCH v2 5/5] net/fm10k: add switch management support Thread-Index: AQHV5/YYX/m8S09GGEuVN8K87D4VeagrzVqAgA16Jr8= Date: Thu, 5 Mar 2020 01:23:59 +0000 Message-ID: References: <1576057875-7677-2-git-send-email-xiaojun.liu@silicom.co.il> <1582207174-31037-1-git-send-email-xiaojun.liu@silicom.co.il> <1582207174-31037-6-git-send-email-xiaojun.liu@silicom.co.il>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiaojun.liu@silicom.co.il; x-originating-ip: [119.139.197.48] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c31d657-33fd-4f16-809b-08d7c0a3e17b x-ms-traffictypediagnostic: DB7PR04MB5098: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03333C607F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(39850400004)(346002)(376002)(136003)(189003)(199004)(8936002)(9686003)(76116006)(26005)(186003)(66446008)(66946007)(4326008)(8676002)(54906003)(91956017)(7696005)(81156014)(33656002)(6506007)(64756008)(53546011)(81166006)(66556008)(110136005)(107886003)(55016002)(66476007)(19627405001)(2906002)(52536014)(44832011)(316002)(5660300002)(71200400001)(478600001)(86362001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR04MB5098; H:DB7PR04MB5196.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: silicom.co.il does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MnRYJjiO+w2qUQNYLsz95SMDYv9oSNf2Nahn+wXnIBm+OPldB9kBiwCZP2G1dxFlaylhQiiXYLVlbBGfknugcwezb05d253gG4lyznS35iT3ygl04CmuCbZycUNGcsAgC6Q/AVNAI67TxWSwON2vznJ/uC1Zi4iOwXpAeKU8yKMFrA5fnGfylAAfQ0UnIMlqNuTSHOoDO6Gxv6AE7EWGBuvtZ5/gy71IdpZW+pLgCI/ysFssXHL3f0odjS08eo6r7YgI9c2Glg9tjpUHOvDDsDQdoVhgG9IQdaINB2htZeu17mtcq0szWrxJTp5on8mLBeqtOv8J725MXXRNZWSThtgvDU0YPxSjnclumtA6sQ0urX6ktRf2CAhUO9bz5adrO6v1DOqJ+i3UEAoecOg92fEeGNEXlJofAn67WTVbCmSIkVwwbWi9CZXHepPe/C2u x-ms-exchange-antispam-messagedata: f29qBE5m7o/NaNOQweJyiDg7nM9mZXRkf0sUz6vi5r9pb/QnsdsnpF0E3wDDsvmwBgMUx/G6OTXz1jHEWlIxRrGBJU44HzK618UE/+6saOxitvBI1dkFQNWaDWYDgukE8CC+8Mrdfq2T0ZczrBF17A== MIME-Version: 1.0 X-OriginatorOrg: silicom.co.il X-MS-Exchange-CrossTenant-Network-Message-Id: 5c31d657-33fd-4f16-809b-08d7c0a3e17b X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2020 01:23:59.0394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KyaJ+eKlFQEGc4bqZVhMSY4RAtXSrLP/UvlBfkoRVz0anK9qmoh5rO68To9uFmfNA3YQ8y/gVpk30tpDs/kn/RHwVvMhow9CSCFWPgiTGmY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5098 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, Thank you! Did you received my new patches last weekend? BTW, I updated to the latest dpdk as the code base. Best regards, Xiaojun ________________________________ From: Wang, Xiao W Sent: Tuesday, February 25, 2020 7:28 PM To: Xiaojun Liu ; Zhang, Qi Z ; Kwan, Ngai-mint ; Keller, Jacob E Cc: dev@dpdk.org ; Ye, Xiaolong Subject: RE: [PATCH v2 5/5] net/fm10k: add switch management support Hi Xiaojun, Gather some comments about the code changes to original file: Based on the latest dpdk, "git am" will fail with the Makefile. Add CONFIG_RTE_FM10K_MANAGEMENT=3Dn as a default option into ./config is be= tter. If user wants to turn on this switch feature, it's easier to just cha= nge "n" to "y". No need to introduce another macro ENABLE_FM10K_MANAGEMENT, just use RTE_FM= 10K_MANAGEMENT to wrap your code. For ethdev.c: static int fm10k_switch_ready; This should be a per device value, right? I = assume we may have >1 fm10k devices, then cannot share one state value. DEV_RX_OFFLOAD_RSS_HASH is removed, it may affect current usage. Log some debug info before return -EIO. How about moving the commonly used variables like "struct fm10k_hw *hw" out= of "ifdef else". Put fm10k_link_update() at the end of dev_start(). For fm10k_stats_get(), it looks there's little code shared between #if and = #else, you can just write a whole new function. There's comment "It may not work for VF", have you addressed this uncertain= ty? We'd better not to leave this in upstream version. BTW, when sending new versions, you need to document what has changed from = last version in your cover letter, in below format: V2: * Fix what * Fix what Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Thursday, February 20, 2020 10:00 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; > Keller, Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v2 5/5] net/fm10k: add switch management support > > Split dev init to 2 parts. > First only register the port in switch > management; second init hook will be > called after all the pf are registered > and switch initialization. It will finish > dev init. Also add switch interrupt support. > Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset > to support mirror operation. Add fm10k_dev_filter_ctrl > to support flow operation. > Add dpdk port and pf mapping, so > the dpdk port can map to a specific pf > and 1 dpdk port can map to 2 pf to get > total 100G throughput. > > To enable the switch management, you need add > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > config/common_linux when building. > > Signed-off-by: Xiaojun Liu > --- [...]