From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE09CA0546; Fri, 14 Feb 2020 03:46:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6DE42629; Fri, 14 Feb 2020 03:46:10 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70137.outbound.protection.outlook.com [40.107.7.137]) by dpdk.org (Postfix) with ESMTP id B7DFE11A4 for ; Fri, 14 Feb 2020 03:46:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QijuyZkBIuSpw3Hti7pKtXuhPd0ORk+GGPJJhd/VVJRFY0h0urdFnXNPuGjXlKdQqY86X2GiyQooc+M/H7gpofPK5I6SY6O4mqMQ1NMWH0hcZ8uBXgZDYQct7hxGyQSr3gRJUbPHgPWdiTjk8ZLEF9iROitKQb4FGn2NNuCjlSibVbcgd/pJU4cg/j5/5RhyR+V84ae/wPKcn5TGVka5yFNeujn+xn7ZDezo4Ft7oIegN12Nct6MsuAPwENlFZAqu2Z39UUXV5juE1hThg9vSr524P+seZ35VUu4Hln6BMZzXNmFB0sxkyoqYYjVKW9rCm4mP6bMEGPQ/7NJ6zhLWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kr4ODgnkF7r3E0m+n28ATmJsusZnH+kD8NAkIXVw1e4=; b=kO803/wxZ+tYlfluwczF68O181RlMGUr48pbnznlCdvDOeVSjPLZD/CBZEAeEBn0LQHYuhXdKc1YpzvXrMfjDN4iIyxwKwCJgVHjAXsAq/q+xKbxABjY+roBT9E7sZ6205unO3OKFZThWiec5C3hc84RA9375TyCDo6WmkJD9sWAwGH7pXt+/I4HGWuVWoZizWnbUFwu4GaTJwXNt0YNXtLypxuym6hi8h9jUbPqRnbhSXpaX2sO5ixfE1VAzBEK1wJVhimcuemu4QXKHDXy7ik3O5pZomSnUuMe37PnB5FW1lYn9YyjZ4zRwTVZIZcr7eJff7OuTiVaHVDLpf69Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom.co.il; dmarc=pass action=none header.from=silicom.co.il; dkim=pass header.d=silicom.co.il; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kr4ODgnkF7r3E0m+n28ATmJsusZnH+kD8NAkIXVw1e4=; b=XYsL+bRgIvEKl3vjJcKTDNCdEuLYElwMMCakZBTpCaubQ/4MUiAOe0H2k9iABjnIMO+j2wGmUXi+bGAfzAS5La8zMCziPuyGP/aroSrolHiXZC7RBZmTA+HuMNn9O5Oj9U5jRBRFlY1Y1O9Yeh+p9HIPsFD49anCckC9w8UORX8= Received: from DB7PR04MB5196.eurprd04.prod.outlook.com (20.176.234.140) by DB7PR04MB4346.eurprd04.prod.outlook.com (52.135.131.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Fri, 14 Feb 2020 02:46:06 +0000 Received: from DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::a400:f6b9:34b1:ed]) by DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::a400:f6b9:34b1:ed%5]) with mapi id 15.20.2729.025; Fri, 14 Feb 2020 02:46:06 +0000 From: Xiaojun Liu To: "Wang, Xiao W" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Fornal, Jakub" , "Keller, Jacob E" , Jeff Zheng , Eyal Cohen Thread-Topic: [PATCH v2 0/7] support switch management Thread-Index: AQHVsAigriNscwtQbUeBgjjdweYzFKf0qTOggAA4zbCAIUVWkIAEOYeL Date: Fri, 14 Feb 2020 02:46:06 +0000 Message-ID: References: <1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiaojun.liu@silicom.co.il; x-originating-ip: [119.139.196.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb72842b-94c3-41e6-318d-08d7b0f80a06 x-ms-traffictypediagnostic: DB7PR04MB4346: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03137AC81E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39830400003)(366004)(346002)(136003)(189003)(199004)(6916009)(26005)(8676002)(107886003)(4326008)(81166006)(478600001)(19627405001)(33656002)(186003)(86362001)(81156014)(44832011)(9686003)(55016002)(8936002)(316002)(2906002)(966005)(64756008)(66556008)(5660300002)(66476007)(54906003)(52536014)(6506007)(76116006)(66946007)(71200400001)(53546011)(91956017)(7696005)(66446008)(21314003); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR04MB4346; H:DB7PR04MB5196.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: silicom.co.il does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M02wLuVSzXt+IARCnTD+a9hVDS/n337v69oqrlSZ8GOwSExW56Zy3z2zpc41KmOzlfcsLPHw+db1e+6WPynmklFkxLbeoHywEM7yt44Dko2NifLNi847dW/uwebWc58DYeXxyjgDtpMXuUdXYjAhZRdlWuZRGskkHbLxqawuYO3q+HQ3dhjZpgl9L7h6qaNa7jUG73ZHTCTSvj9T/ZHnLBgtiVuqrwZRR4uvQpBZgDMQMw/UZ4jCeKxlxWxCOCKX2uyM2vO2Lwtz6SMiuthud/wVb4kbYd/qVnFSKBdjEmQw0yDJY5Vo+agwqU2bF9NQtIXXaOSDywosTr/h0nFHCfOTNf45GisQdVE7qa6QGshI62KNd/B2MZcW4zEdz66MHGNvx8+4TV7rnlqFNGNCxlkhl8JBqVBDKn+mQNls0bZzHTYFRNvMaB4jbCIQ9prPMs324aMNLgWtYwOlSgm1UJJHbWcTQiItvEjZCzDiUS63wR0HpRRVtOdaJQ09+ON8IizWdIpTAwGx44UayFEm4HMPwr/uUqQ0vYrVpZBSG4DDuJMuxqjDiG5z34umx4Xi x-ms-exchange-antispam-messagedata: xFhi/2pwxiefmNVTj4PVxqyE3plflTbEGr0bBMWvurK/GxaMJFvyOxkMbFOWhA+NHWcdsw7alplFcnSxswCb21SvjVIDxRqNXkWy+vY/bSUjZDRd0FnN9XfSSRrtmyTadb39Ne60giDE1HuwdYwX1g== MIME-Version: 1.0 X-OriginatorOrg: silicom.co.il X-MS-Exchange-CrossTenant-Network-Message-Id: bb72842b-94c3-41e6-318d-08d7b0f80a06 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2020 02:46:06.0921 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kNqUT3StMPUE1bIudYcAkk6d3pStJEYvMtVtGn10Gp0AlATbX54Zo289OG0lHaf5qtSkVHJ78Z+P3U7nCzXx0Y7MI8FBeG3zVcJ+Mn4q27s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4346 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 0/7] support switch management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi Xiao, Thanks for your comments! I will fix them ASAP. Best regards, Xiaojun ________________________________ From: Wang, Xiao W Sent: Tuesday, February 11, 2020 6:31 PM To: Xiaojun Liu Cc: dev@dpdk.org ; Zhang, Qi Z ; Kwan, = Ngai-mint ; Fornal, Jakub ; Keller, Jacob E ; Jeff Zheng ; Eyal Cohen Subject: RE: [PATCH v2 0/7] support switch management Since this is a big code change, so just some general comments/suggestions = for your next version patch set: - please clean up comments like "XXX" in the code. - It's better to define MACRO for all register addrs and bit shift, please = try to avoid magic number (e.g. in the serdes part). - There're threads created for handling events and timers, we'd better use = pthread_join() to recycle them in fm10k_sm_detach(). - set "tapstop" and "shiftwidth" to 8 in vimrc, then recheck the macros and= keep them aligned. - There're some "printf" for debugging, please use dpdk logging API instead= . Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Tuesday, January 21, 2020 2:15 PM > To: Wang, Xiao W > Cc: dev@dpdk.org; Zhang, Qi Z ; Kwan, Ngai-mint > ; jakub.fornal@intel.co; Keller, Jacob E > ; Jeff Zheng ; Eyal > Cohen > Subject: RE: [PATCH v2 0/7] support switch management > > Hi Xiao, > > Thank you! I will update the commit log and prepare a document to describ= e > the design and implementation. > > Best regards, > Xiaojun > > -----Original Message----- > From: Wang, Xiao W [mailto:xiao.w.wang@intel.com] > Sent: Tuesday, January 21, 2020 10:53 AM > To: Xiaojun Liu > Cc: dev@dpdk.org; Zhang, Qi Z; Kwan, Ngai-mint; jakub.fornal@intel.co; > Keller, Jacob E > Subject: RE: [PATCH v2 0/7] support switch management > > Hi Xiaojun, > > Could you please help to improve the commit logs of all the 7 patches? Th= ey > look very similar, and info like below is not very helpful for reviewer, = since > we already know which file you are adding. > "To support switch management, add the following files: > Add fm10k/switch/fm10k_debug.h(define log Macros). > Add fm10k/switch/fm10k_regs.h(define all the registers)." > > Please talk more about the design and implementation details in the commi= t > log. Refer to history patches if you need a sample. > > Also please help to address the compile error reported by automation in l= ink > http://patches.dpdk.org/patch/63742/: > "ci/Intel-compilation fail Compilation issues" > > I would look deeper into your change, and you can address above comments > simultaneously. > > Best Regards, > Xiao > > > -----Original Message----- > > From: Xiaojun Liu > > Sent: Wednesday, December 11, 2019 5:52 PM > > To: Wang, Xiao W ; Zhang, Qi Z > > ; Kwan, Ngai-mint ; > > jakub.fornal@intel.co; Keller, Jacob E > > Cc: dev@dpdk.org; Xiaojun Liu > > Subject: [PATCH v2 0/7] support switch management > > > > To avoid configuration for both kernel driver > > and userspace SDK outside DPDK, we add switch > > management in FM10K DPDK PMD driver. > > To enable switch management, you need add > > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > > config/common_linux when building. > > > > > > Xiaojun Liu (7): > > net/fm10k: add i2c sbus registers definition > > net/fm10k: add some modules of port > > net/fm10k: add config ffu statistics support > > net/fm10k: add flow and switch management > > net/fm10k: add switch initialization > > net/fm10k: add mirror and filter ctrl > > net/fm10k: add dpdk port mapping > > > > drivers/net/fm10k/Makefile | 22 + > > drivers/net/fm10k/fm10k_ethdev.c | 580 +++++- > > drivers/net/fm10k/switch/fm10k_config.c | 855 ++++++++ > > drivers/net/fm10k/switch/fm10k_config.h | 171 ++ > > drivers/net/fm10k/switch/fm10k_debug.h | 19 + > > drivers/net/fm10k/switch/fm10k_ext_port.c | 841 ++++++++ > > drivers/net/fm10k/switch/fm10k_ext_port.h | 136 ++ > > drivers/net/fm10k/switch/fm10k_ffu.c | 1209 +++++++++++ > > drivers/net/fm10k/switch/fm10k_ffu.h | 31 + > > drivers/net/fm10k/switch/fm10k_flow.c | 872 ++++++++ > > drivers/net/fm10k/switch/fm10k_flow.h | 26 + > > drivers/net/fm10k/switch/fm10k_i2c.c | 310 +++ > > drivers/net/fm10k/switch/fm10k_i2c.h | 54 + > > drivers/net/fm10k/switch/fm10k_regs.h | 2202 > ++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_sbus.c | 292 +++ > > drivers/net/fm10k/switch/fm10k_sbus.h | 40 + > > drivers/net/fm10k/switch/fm10k_serdes.c | 1886 +++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_serdes.h | 32 + > > drivers/net/fm10k/switch/fm10k_sm.c | 182 ++ > > drivers/net/fm10k/switch/fm10k_sm.h | 78 + > > drivers/net/fm10k/switch/fm10k_spico_code.c | 2966 > > +++++++++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_spico_code.h | 21 + > > drivers/net/fm10k/switch/fm10k_stats.c | 1242 +++++++++++ > > drivers/net/fm10k/switch/fm10k_stats.h | 257 +++ > > drivers/net/fm10k/switch/fm10k_switch.c | 2562 > > +++++++++++++++++++++++ > > drivers/net/fm10k/switch/fm10k_switch.h | 336 +++ > > 26 files changed, 17188 insertions(+), 34 deletions(-) > > create mode 100644 drivers/net/fm10k/switch/fm10k_config.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_config.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.h > > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.c > > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h > > > > -- > > 1.8.3.1