From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F56BA052F; Tue, 21 Jan 2020 07:15:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50AF32BF9; Tue, 21 Jan 2020 07:15:32 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2124.outbound.protection.outlook.com [40.107.22.124]) by dpdk.org (Postfix) with ESMTP id BC4681515 for ; Tue, 21 Jan 2020 07:15:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WcuUsolO/4cn9EdqAHY019zL3C/jHI3UJsKYr/wQ7blqkBBwpKB8CYuUm59NyPfOYTswvO8xcAXB7CqWP7nxc6g+iJBW0N7KTO/UIiWrd5gYXv6Sk79Z30cJ2SLdUJWFfwPvFAyCpi69Qe6bk6J7I5Zo08LwwJwJhF4OmSPGxzh2MTCWfDdastb5wZCesX/me8nx84cUWaTceCeuPLnt6bctJ45lG+SSvGPNNZOJQpgy8KPRqOCbYCTn/oF3u4IbEnaGPQqniAvOnkP28G2HqLfk8YA+TbqC95D2w0R7+IHDVnvoi0r1Q+muapCMyDP8cGiDvPLFVurZW/IGKrKE8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xh07iq+HmdVmvTlZLAVN6GTY1R+zVNNmBsHZ6lPV2sY=; b=TKLnd5z3FnpiB0xBIurQe/+vPFkTdsBFGc1CMntw59Judm5msxYgZu+KJkzYH/dk7gHSQaFalWHuq/sNhV6Y+H+k5NO9/Cbfkds15VMBhb0ba5qSnnkIBj1N1uaERA6ixqMvM1pXN6NdJQPSfdgS2yGjJjqTBG87LijuEjoS+B6BpzYqqFd4tZmn7fDzT+8SK8K1XPVtOE8/8uPt0B2TpQV+VY98yvIS0uWzgThw/GQWt7mHtwQ95fpeacgjR1Tm98d3FD5I9yKFvZHChSfaL3llimdwLgj9ceK4FeYMzgH28JxIHb4BS6Pffh1+XArCygwI4jQikssIwlxVUjlQ0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom.co.il; dmarc=pass action=none header.from=silicom.co.il; dkim=pass header.d=silicom.co.il; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xh07iq+HmdVmvTlZLAVN6GTY1R+zVNNmBsHZ6lPV2sY=; b=Tp4GDy6b108vCYroEWqs8Mpo1ZUBbvYBgszSTXjiV0aLGBkJ0DhcZEyqRlIo/7shiq+/BXsBCajhBhVbKfEd+908T0IBY3wmMscqfpBFcNVAIpOSYddzMxP7oOc4SrLPkKJo/wa6zn4G6ivGHkcbp9Z5msCRnaTHj08vSOYNrY4= Received: from DB7PR04MB5196.eurprd04.prod.outlook.com (20.176.234.140) by DB7PR04MB5403.eurprd04.prod.outlook.com (20.178.104.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18; Tue, 21 Jan 2020 06:15:29 +0000 Received: from DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::cdaa:fcae:322b:59ed]) by DB7PR04MB5196.eurprd04.prod.outlook.com ([fe80::cdaa:fcae:322b:59ed%7]) with mapi id 15.20.2644.026; Tue, 21 Jan 2020 06:15:29 +0000 From: Xiaojun Liu To: "Wang, Xiao W" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "jakub.fornal@intel.co" , "Keller, Jacob E" , Jeff Zheng , Eyal Cohen Thread-Topic: [PATCH v2 0/7] support switch management Thread-Index: AQHVsAigriNscwtQbUeBgjjdweYzFKf0qTOggAA4zbA= Date: Tue, 21 Jan 2020 06:15:28 +0000 Message-ID: References: <1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiaojun.liu@silicom.co.il; x-originating-ip: [103.91.219.177] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6b15862-ab09-4e6e-201d-08d79e395072 x-ms-traffictypediagnostic: DB7PR04MB5403: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0289B6431E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(376002)(366004)(136003)(39850400004)(346002)(199004)(189003)(4326008)(2906002)(33656002)(107886003)(186003)(53546011)(26005)(52536014)(316002)(966005)(8676002)(7696005)(9686003)(478600001)(5660300002)(81166006)(44832011)(81156014)(6916009)(8936002)(6506007)(66946007)(64756008)(76116006)(55016002)(54906003)(71200400001)(66476007)(66556008)(66446008)(86362001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR04MB5403; H:DB7PR04MB5196.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: silicom.co.il does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 35QvZBpE3QLguHYURt3POyX0Hg7Pf5gnlqbtdJ0HfW0ib4BpPQDwOpLvQR9wpRpCXJzx8rGRkMAKRjnGg7lhSrzWRLmyB0VmC2nNpAPmqtl8LpShPwY1/Pc+qzTDkTfeAjY0p9qQyhpq3+/egxbMUtt4nKgF9tbXYJmN4rbS/rFWKeH9LPb1gG8p6IbNmRD5hhLtJy7CQfkicDz7HOmPhwBBYAGUQxWI4Pslbb2Pb28fxTpu/SKyUV5sFiemfNH29A+nLPbexITKm9HIkmqIhxU8hCoGjY7l8esgYjiJbQuyr102Ez+3Obf+2ZmKTeC+ampppKZWzZgspFkNWYB9SLqe8ylBN75FCuyOj+Lv8eEnav4Dup4j68MoZjHlp8EodqgrQnqHxGh7q+UysyOqaSxC4MMByHZVTCsjXr8X8ZH8TabZ6ceYurA4fYxSGBDqFYNz/1pmXNAXNqyJLIDy6Ncl7HL5SZ15mZy7drKuTsi178MZC4XjppqZaBswsTSnJz8nPrc/8AP9T0c7IsGdNQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom.co.il X-MS-Exchange-CrossTenant-Network-Message-Id: f6b15862-ab09-4e6e-201d-08d79e395072 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2020 06:15:29.1968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MxMmLeqIaLtP77/LkkRmTxNAFXgw2A4N0jMmVFTL26fI0gWF/JbQFAs7doksAJ98NPsqY5mbPLQPxtjLM0ecgywdCdW6mP9DmydRdQeAaTs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5403 Subject: Re: [dpdk-dev] [PATCH v2 0/7] support switch management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, Thank you! I will update the commit log and prepare a document to describe = the design and implementation. Best regards, Xiaojun -----Original Message----- From: Wang, Xiao W [mailto:xiao.w.wang@intel.com]=20 Sent: Tuesday, January 21, 2020 10:53 AM To: Xiaojun Liu Cc: dev@dpdk.org; Zhang, Qi Z; Kwan, Ngai-mint; jakub.fornal@intel.co; Kell= er, Jacob E Subject: RE: [PATCH v2 0/7] support switch management Hi Xiaojun, Could you please help to improve the commit logs of all the 7 patches? They= look very similar, and info like below is not very helpful for reviewer, s= ince we already know which file you are adding. "To support switch management, add the following files: Add fm10k/switch/fm10k_debug.h(define log Macros). Add fm10k/switch/fm10k_regs.h(define all the registers)." Please talk more about the design and implementation details in the commit = log. Refer to history patches if you need a sample. Also please help to address the compile error reported by automation in lin= k http://patches.dpdk.org/patch/63742/: "ci/Intel-compilation fail Compilation issues" I would look deeper into your change, and you can address above comments si= multaneously. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Wednesday, December 11, 2019 5:52 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; > jakub.fornal@intel.co; Keller, Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v2 0/7] support switch management >=20 > To avoid configuration for both kernel driver > and userspace SDK outside DPDK, we add switch > management in FM10K DPDK PMD driver. > To enable switch management, you need add > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > config/common_linux when building. >=20 >=20 > Xiaojun Liu (7): > net/fm10k: add i2c sbus registers definition > net/fm10k: add some modules of port > net/fm10k: add config ffu statistics support > net/fm10k: add flow and switch management > net/fm10k: add switch initialization > net/fm10k: add mirror and filter ctrl > net/fm10k: add dpdk port mapping >=20 > drivers/net/fm10k/Makefile | 22 + > drivers/net/fm10k/fm10k_ethdev.c | 580 +++++- > drivers/net/fm10k/switch/fm10k_config.c | 855 ++++++++ > drivers/net/fm10k/switch/fm10k_config.h | 171 ++ > drivers/net/fm10k/switch/fm10k_debug.h | 19 + > drivers/net/fm10k/switch/fm10k_ext_port.c | 841 ++++++++ > drivers/net/fm10k/switch/fm10k_ext_port.h | 136 ++ > drivers/net/fm10k/switch/fm10k_ffu.c | 1209 +++++++++++ > drivers/net/fm10k/switch/fm10k_ffu.h | 31 + > drivers/net/fm10k/switch/fm10k_flow.c | 872 ++++++++ > drivers/net/fm10k/switch/fm10k_flow.h | 26 + > drivers/net/fm10k/switch/fm10k_i2c.c | 310 +++ > drivers/net/fm10k/switch/fm10k_i2c.h | 54 + > drivers/net/fm10k/switch/fm10k_regs.h | 2202 ++++++++++++++++++++ > drivers/net/fm10k/switch/fm10k_sbus.c | 292 +++ > drivers/net/fm10k/switch/fm10k_sbus.h | 40 + > drivers/net/fm10k/switch/fm10k_serdes.c | 1886 +++++++++++++++++ > drivers/net/fm10k/switch/fm10k_serdes.h | 32 + > drivers/net/fm10k/switch/fm10k_sm.c | 182 ++ > drivers/net/fm10k/switch/fm10k_sm.h | 78 + > drivers/net/fm10k/switch/fm10k_spico_code.c | 2966 > +++++++++++++++++++++++++++ > drivers/net/fm10k/switch/fm10k_spico_code.h | 21 + > drivers/net/fm10k/switch/fm10k_stats.c | 1242 +++++++++++ > drivers/net/fm10k/switch/fm10k_stats.h | 257 +++ > drivers/net/fm10k/switch/fm10k_switch.c | 2562 > +++++++++++++++++++++++ > drivers/net/fm10k/switch/fm10k_switch.h | 336 +++ > 26 files changed, 17188 insertions(+), 34 deletions(-) > create mode 100644 drivers/net/fm10k/switch/fm10k_config.c > create mode 100644 drivers/net/fm10k/switch/fm10k_config.h > create mode 100644 drivers/net/fm10k/switch/fm10k_debug.h > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.c > create mode 100644 drivers/net/fm10k/switch/fm10k_ext_port.h > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.c > create mode 100644 drivers/net/fm10k/switch/fm10k_ffu.h > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.c > create mode 100644 drivers/net/fm10k/switch/fm10k_flow.h > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.c > create mode 100644 drivers/net/fm10k/switch/fm10k_i2c.h > create mode 100644 drivers/net/fm10k/switch/fm10k_regs.h > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.c > create mode 100644 drivers/net/fm10k/switch/fm10k_sbus.h > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.c > create mode 100644 drivers/net/fm10k/switch/fm10k_serdes.h > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.c > create mode 100644 drivers/net/fm10k/switch/fm10k_sm.h > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.c > create mode 100644 drivers/net/fm10k/switch/fm10k_spico_code.h > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.c > create mode 100644 drivers/net/fm10k/switch/fm10k_stats.h > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.c > create mode 100644 drivers/net/fm10k/switch/fm10k_switch.h >=20 > -- > 1.8.3.1