Re: [dpdk-dev] [PATCH] net/mlx5: fix build on PPC64

[Shahaf Shuler <shahafs@mellanox.com>]

Wednesday, November 7, 2018 11:10 PM, Thomas Monjalon:
> Subject: Re: [PATCH] net/mlx5: fix build on PPC64
> 
> 07/11/2018 20:05, dwilder:
> > On 2018-11-07 08:00, Thomas Monjalon wrote:
> > > The AltiVec header file breaks boolean type:
> > >
> > > error: incompatible types when initializing type '__vector _bool
> > > int' {aka '_vector(4) __bool int'} using type 'int'
> > >
> > > If __APPLE_ALTIVEC__ is defined, then bool type is redefined and
> > > conflicts with stdbool.h.
> > >
> > > There is no good solution to fix it for the whole project without
> > > breaking something else, so a workaround is inserted in mlx5 PMD.
> > > This workaround is not compatible with C++ but there is no C++ in DPDK.
> > >
> > > Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > > Suggested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > <cut ....>
> >
> > Tested-by: David Wilder <dwilder@us.ibm.com>
> >
> > Hi Thomas
> >
> > Thanks for re-posting this patch.  I see no build breaks on power8 or
> > power9 with this patch.  I tried both 18.11-rc1 and upstream (master).
> 
> It is not really a re-post. I took the last solution which was proposed for EAL,
> and applied it to mlx5 only.

Applied to next-net-mlx, thanks. 

>