From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20063.outbound.protection.outlook.com [40.107.2.63]) by dpdk.org (Postfix) with ESMTP id F24401B45E; Thu, 12 Jul 2018 12:57:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jm/m0eQUfWkckYfdufWQUGBJokmfIVb89Fg79FDmUQM=; b=r5nd74W33FHhQFFfOsVu1TC2OqdxL6+X85nHTY6q90wvdVH9gAsMLSlSEt0e3fp33vM+xT8wgmWUyQm3ziIz9FlOBwgBGtfo7+FSlcss54UY/hDX++7OmfrbBeIxqmaKd0HCRvUIwO1CpFsXxPEWHHJNZDlTJKVZrYFMssm5UAc= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5034.eurprd05.prod.outlook.com (20.176.236.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.17; Thu, 12 Jul 2018 10:57:22 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::d9c6:913c:c361:f7b7]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::d9c6:913c:c361:f7b7%6]) with mapi id 15.20.0930.022; Thu, 12 Jul 2018 10:57:22 +0000 From: Shahaf Shuler To: Ori Kam , Yongseok Koh CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "stephen@networkplumber.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix compilation for rdma-core v19 Thread-Index: AQHUGc6TCKfxdZZDMUqo5R2+RtCMT6SLanjA Date: Thu, 12 Jul 2018 10:57:22 +0000 Message-ID: References: <20180712065653.29801-1-shahafs@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5034; 7:7u41miwaVZH6wGr0R9ClYlO4cFV75o/9bSmPwkCbeqzULhBdVuw/qwV2RKL1vHkiICx2wJsyFEPa/EovGT0fewzA6DStmUc8/La/Kwe2Zlrtml7Z3UtHGlH99U+UCTBsNSLvOljPd0wPlbfvwEo4d7+CHqLa7Efzfs+cGIVdyXBumxoD/u2AbmEnL/peV3ouDXbjTJW+Ik0F306bwBZO0pLNH/YvSkiNa1ouFH4d4JjtNa65NCmH4I22RmsbFt/E x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 23226fb4-ac91-4ecb-60eb-08d5e7e63eaa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5034; x-ms-traffictypediagnostic: DB7PR05MB5034: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB5034; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5034; x-forefront-prvs: 0731AA2DE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(376002)(366004)(346002)(199004)(189003)(81166006)(11346002)(4326008)(446003)(76176011)(229853002)(486006)(53936002)(6506007)(476003)(6116002)(99286004)(256004)(86362001)(25786009)(7696005)(102836004)(6436002)(6636002)(33656002)(110136005)(2900100001)(54906003)(106356001)(14444005)(97736004)(26005)(316002)(66066001)(2906002)(478600001)(68736007)(7736002)(105586002)(74316002)(5660300001)(55016002)(3846002)(8936002)(14454004)(81156014)(5250100002)(305945005)(8676002)(6246003)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5034; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: X8TL8qcDs6uXABc436beM5QYZas8XoUKJ5Q9UoEmPBhJ15J1EvB64zWYtRxGO/gCF7fg8TzcHyCsSI44Qb/PKpVCU8mGj0K2xYk9fPLKn37O2G4b2yyXb4pPDI4vS2IMZs090sYpi0/X1NGA0ZTE2hJgWHNxptK4DjNoZtOzCQFNe/eD0BXzJ+wOtnqHlYVd5PKg5oO8837lSowm5gxQuP8dTvJ2bOLnzoadIiDrbYpj1dqvhpJ2uzeJC5PNH2GiOZdPsDdaT8Qs4tYDquw1mhY3Rz62fX6kc/jyQZ0lS9l+lqm7uUHMK0OLW6KE4E7sGPu1EkpAw8LLRrb1+dLZ0oPiHSZyEzRzOz/CvOHcT9o= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23226fb4-ac91-4ecb-60eb-08d5e7e63eaa X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2018 10:57:22.1500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5034 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation for rdma-core v19 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 10:57:25 -0000 Thursday, July 12, 2018 1:54 PM, Ori Kam: > Subject: RE: [PATCH] net/mlx5: fix compilation for rdma-core v19 > > > > The flow counter support introduced by commit 9a761de8ea14 ("net/mlx5: > > flow counter support") was intend to work only with MLNX_OFED_4.3 as > > the upstream rdma-core libraries were lack such support. > > > > On rdma-core v19 the support for the flow counters was added but with > > different user APIs, hence causing compilation issues on the PMD. > > > > This patch fix the compilation errors by forcing the flow counters to > > be enabled only with MLNX_OFED APIs. > > Once MLNX_OFED and rdma-core APIs will be aligned, a proper patch to > > support the new API will be submitted. > > > > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") > > Cc: stable@dpdk.org > > Cc: orika@mellanox.com > > > > Reported-by:Stephen Hemminger > > Reported-by: Ferruh Yigit > > Signed-off-by: Shahaf Shuler > > --- > > drivers/net/mlx5/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > > index 9e274964b4..d86c6bbab9 100644 > > --- a/drivers/net/mlx5/Makefile > > +++ b/drivers/net/mlx5/Makefile > > @@ -150,7 +150,7 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto- > > config-h.sh > > $Q sh -- '$<' '$@' \ > > HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT \ > > infiniband/verbs.h \ > > - enum IBV_FLOW_SPEC_ACTION_COUNT \ > > + type 'struct ibv_counter_set_init_attr' \ > > $(AUTOCONF_OUTPUT) > > $Q sh -- '$<' '$@' \ > > HAVE_RDMA_NL_NLDEV \ > > -- > > 2.12.0 >=20 >=20 > Acked-by: Ori Kam Applied to next-net-mlx, thanks.=20