From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: preserve promisc flag for flow isolation mode
Date: Sun, 5 Aug 2018 10:42:26 +0000 [thread overview]
Message-ID: <DB7PR05MB442618D7EFB3A5C5796C4B26C3210@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180802210632.11006-1-yskoh@mellanox.com>
Friday, August 3, 2018 12:07 AM, Yongseok Koh:
> Subject: [PATCH v2 1/2] net/mlx5: preserve promisc flag for flow isolation
> mode
>
> mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous
> mode as it can't be enabled in flow isolation mode. If the function pointers
> are null, librte APIs such as rte_eth_promiscuous_enable/disable()
> fail to set the flag (dev->data->promiscuous). The flag is used when starting
> traffic by mlx5_traffic_enable(). When switching out of flow isolation mode,
> promiscuous mode will not be set even though it has been enabled.
>
> Fixes: 0887aa7f27f3 ("net/mlx5: add new operations for isolated mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Series applied to next-net-mlx, thanks.
prev parent reply other threads:[~2018-08-05 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 1:05 [dpdk-dev] [PATCH " Yongseok Koh
2018-08-02 1:05 ` [dpdk-dev] [PATCH 2/2] net/mlx5: preserve allmulti " Yongseok Koh
2018-08-02 21:06 ` [dpdk-dev] [PATCH v2 1/2] net/mlx5: preserve promisc " Yongseok Koh
2018-08-02 21:06 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: preserve allmulti " Yongseok Koh
2018-08-05 10:42 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB442618D7EFB3A5C5796C4B26C3210@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).