DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "Yongseok Koh" <yskoh@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Yaroslav Brustinov" <ybrustin@cisco.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib
Date: Tue, 24 Jul 2018 13:51:24 +0000	[thread overview]
Message-ID: <DB7PR05MB4426199AE87257E29F482EFAC3550@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180724120551.GR5211@6wind.com>

Yaroslav, 

Tuesday, July 24, 2018 3:06 PM, Adrien Mazarguil:
> Subject: Re: [PATCH] net/mlx5: fix linkage error for glue lib
> > Odd, how could this happen assuming both files are compiled during the
> > same run using identical flags? Looks like a compiler issue.
> >
> > Anyway, may I suggest an alignment constraint on the structure type in
> > mlx5_glue.h instead, so that all users inherit it. E.g. using C11 syntax:
> >
> >  #include <stdalign.h>
> >  #include <stddef.h>
> >
> >  [...]
> >  alignas(max_align_t)
> >  struct mlx5_glue {
> >      [...]
> >  };
> 
> My bad, this is not a correct use for alignas(), it doesn't work on types.
> How about this instead:
> 
>  alignas(max_align_t)
>  const struct mlx5_glue *mlx5_glue;

Can you confirm the above suggestion fixes your issue? 

> 
> >

  reply	other threads:[~2018-07-24 13:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  8:54 Shahaf Shuler
2018-07-24 12:00 ` Adrien Mazarguil
2018-07-24 12:05   ` Adrien Mazarguil
2018-07-24 13:51     ` Shahaf Shuler [this message]
2018-07-24 14:24       ` Yaroslav Brustinov (ybrustin)
2018-07-24 16:03         ` Adrien Mazarguil
2018-07-25  7:38           ` Yaroslav Brustinov (ybrustin)
2018-07-25  9:24             ` Adrien Mazarguil
2018-07-25 10:02               ` Yaroslav Brustinov (ybrustin)
2018-07-25 13:18 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2018-07-25 13:22   ` Adrien Mazarguil
2018-07-26  5:44     ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR05MB4426199AE87257E29F482EFAC3550@DB7PR05MB4426.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=ybrustin@cisco.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).