From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0081.outbound.protection.outlook.com [104.47.1.81]) by dpdk.org (Postfix) with ESMTP id 98289235; Tue, 24 Jul 2018 15:51:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ZH1SMq17Tu2z/LTjB1AtGIw1FsemQ8Aoch1YEkFzz0=; b=QdB9zJJsevR2Y/GDQs76xy7s+wav8/pZxgpgh8XO8+1S+ZNGM5ouNsnERVcsa8EFH4Z4R3rgukzAne6E/zgEjR1Qu3lZSEfRiA9FxDJVDkQ+kxjuaL4/3Mfvbf1Dpxm66rYgBPOb3gUHAURShyjsyVFDzyxVHhXEMx7CRj1NQ6A= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4268.eurprd05.prod.outlook.com (52.134.108.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Tue, 24 Jul 2018 13:51:24 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%3]) with mapi id 15.20.0952.022; Tue, 24 Jul 2018 13:51:24 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: Yongseok Koh , "dev@dpdk.org" , Yaroslav Brustinov , "stable@dpdk.org" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [PATCH] net/mlx5: fix linkage error for glue lib Thread-Index: AQHUI0YBhC2ZAweWBkCoKqV1bh6Kd6SeRsiAgAAdQ4A= Date: Tue, 24 Jul 2018 13:51:24 +0000 Message-ID: References: <20180724085445.52206-1-shahafs@mellanox.com> <20180724120048.GQ5211@6wind.com> <20180724120551.GR5211@6wind.com> In-Reply-To: <20180724120551.GR5211@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4268; 6:aFAOWHa2dJ0Q/vu6b701O0wgnvPic/s050vJZF7Cp3DUh4Lkq/AB2Ja7N7IHKazEuNwDC3JLuhLpT3DLjHvoziRkO6iVJ+VDUNhQCDBHcsbaGCThNqpX/8WOAiXCFSc7F1ws0fT/wMKvAMSTrZJL9DrF4935lSIwdlXJblnto6jmAUsiFTjqp7TcAkVfezTACpimDuxMExGP8aT/B0vNYmDNtIllrOtqwUEMr8LHG7J6tGmpDM54PA8v6brVIsLrEY+tZwuGDkmFxeALGvD1euXGJNBbP3FXeuYtI8SWVrwsK4YBUhIbnFCDawX+uaneH4V5xiqrnS10gDEObGm7IOPIlX5Zx2O1w6/S9VbHwkQuc+qNlriWigoqgt7Y/3iku2ugG0Ysh+YRGGslHj8CxHs/Xv1EJ7Dj8Pf1CTodq1UUZS+KUFipZc14+yd5nt6kM9SASZoBClouaQD4czhByg==; 5:ktSQP+WpOqK+SCSq+FlxNdKBa8qPRN7Zmk7U81jiy97POMVLJdx3XHJisfXXXpK5kPWNFGy0Mxxkf17csqyozyaaijP2ULyN9snx7sOHSbyhvPT765Hpk8cn8ih6U3/YV2crtmVITf80UD8FbYWsj0eNCzo2w169PgTYtM/5WaY=; 7:ZxgHWrre1PxosrYN33ZQG40ozMxW3wNmr/MeiQYevV9+kaBbB3i1xqgySKOjW8+VvftcdiwiNifatECVzlK/6HO0/e1D1wdCHyJL5tOlxWOxXX9vWR7ugdg9vxCER/nkwwQ25Hh+Ms6JBoQLubMoL8Yw6XXG/F4gUX9mDO+/pRoXDv00E9vv46/3Ulcpm8+MW9I8hjW1ECrFzXuu9Sd04R2iPYalURLqiZOJ9Zw9qbayhr9bzB85kbJstYjow3Rw x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2e8b9f20-7228-43d5-096c-08d5f16c8b89 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4268; x-ms-traffictypediagnostic: DB7PR05MB4268: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4268; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4268; x-forefront-prvs: 0743E8D0A6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(396003)(376002)(346002)(366004)(52314003)(189003)(199004)(86362001)(106356001)(6916009)(3846002)(11346002)(6116002)(97736004)(105586002)(2906002)(316002)(54906003)(229853002)(66066001)(6436002)(68736007)(14454004)(478600001)(9686003)(55016002)(7696005)(53936002)(476003)(2900100001)(81156014)(26005)(8676002)(81166006)(99286004)(256004)(6246003)(7736002)(186003)(446003)(5660300001)(25786009)(305945005)(74316002)(5250100002)(4326008)(14444005)(102836004)(76176011)(486006)(6506007)(33656002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4268; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: mA4PucPcvzI7llgOY8c+A5uo48GqhvJCOuD+1+mbz1M47+AzRmNNoSlO1WEsylbNIIpPkLaf9ZkU//nPlhxQfbG/2M4sDqAxE2lQnjMnxaxb3M4+YaPW8Gut/Ad+pv7MUsVS4p4V3gATcOkSqDvy6M+fJH3isPXPkPjyJps8IVB9wGF7QSvMU6f3ZXOJM+LkAffKQSxnLuHp3XZrKXC6/j89wqn0ZmRmUKEDfKfp1UCM+KkVSQnztSZ7IfeD2/ZvoefscolBBLNR6HyqMEVsU5nj1DZZVBCXH45elzp6LCn4of5LDgQ0PJLOlHl2wxe9zvlzUsyzrmGxdbGXV9Ja+Fny2MD/WTdasVykvxsTk/k= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e8b9f20-7228-43d5-096c-08d5f16c8b89 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2018 13:51:24.1787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4268 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 13:51:26 -0000 Yaroslav,=20 Tuesday, July 24, 2018 3:06 PM, Adrien Mazarguil: > Subject: Re: [PATCH] net/mlx5: fix linkage error for glue lib > > Odd, how could this happen assuming both files are compiled during the > > same run using identical flags? Looks like a compiler issue. > > > > Anyway, may I suggest an alignment constraint on the structure type in > > mlx5_glue.h instead, so that all users inherit it. E.g. using C11 synta= x: > > > > #include > > #include > > > > [...] > > alignas(max_align_t) > > struct mlx5_glue { > > [...] > > }; >=20 > My bad, this is not a correct use for alignas(), it doesn't work on types= . > How about this instead: >=20 > alignas(max_align_t) > const struct mlx5_glue *mlx5_glue; Can you confirm the above suggestion fixes your issue?=20 >=20 > >