From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0042.outbound.protection.outlook.com [104.47.1.42]) by dpdk.org (Postfix) with ESMTP id CDEE728F3; Sun, 29 Apr 2018 08:02:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3OEwi9B0tqJgnSbjENucL0a3d5lIeYWT64N/vqmzfwE=; b=FlOE5/BMTUDXiur2WcRaNABDEcMfucE9aUe3KaAxFhAX4+jgXDO7xG03Rc6cyEodSjgpZ2mL4DVx2w3fZ55xxsB/4SBRRvwXpWYkszPm3S9fGhJMnhJSHponH6fBH5xQVCDbpTlbGLgKQF0d4cxmXTd76tWEhwIoymt0DGnUt2Q= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4251.eurprd05.prod.outlook.com (52.134.108.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.15; Sun, 29 Apr 2018 06:02:03 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0715.022; Sun, 29 Apr 2018 06:02:03 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: Ferruh Yigit , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error Thread-Index: AQHT3XtWjIhGMO0TUEyj0RcNUuqXu6QXRBQQ Date: Sun, 29 Apr 2018 06:02:02 +0000 Message-ID: References: <20180425153739.9157-1-adrien.mazarguil@6wind.com> <20180426162142.6617-1-adrien.mazarguil@6wind.com> In-Reply-To: <20180426162142.6617-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4251; 7:zCtyYfoQrKVU7qZNqS8Hd3xuFH9qTbBwGsODLlCIjn3bF49p4l+/mux5tneODdMK4bHoF7AS3c0ynECN9B8P3YdzwIUpNTeRQTLHqouDNep5H7X9hD7M1Nq0fpviCemEX+8W21UFIIzzCdAZYyIdKfbHArRHEogMjgvlUuS7lDSJUHOg2YBpzL4UsKnrUvtLNs0RDwo5UID78+ARbA0jMvIb14eLRUB6lKZ1jjddjzB6xNrZ4bqo1G8ENq+YaiyW x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4251; x-ms-traffictypediagnostic: DB7PR05MB4251: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4251; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4251; x-forefront-prvs: 0657D528EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(346002)(376002)(39860400002)(366004)(396003)(199004)(189003)(99286004)(54906003)(5660300001)(106356001)(316002)(81166006)(5250100002)(8936002)(305945005)(3660700001)(8676002)(97736004)(7696005)(5890100001)(2906002)(81156014)(14454004)(6916009)(59450400001)(486006)(76176011)(6246003)(33656002)(105586002)(2900100001)(102836004)(446003)(55016002)(3280700002)(6436002)(4326008)(3846002)(66066001)(68736007)(53936002)(26005)(478600001)(11346002)(6506007)(7736002)(74316002)(186003)(25786009)(9686003)(86362001)(476003)(229853002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4251; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ilzFTHsW6Zaw/XMq54Jk6YcwjkH3q8VkWOX/sFDRaQ34+Y9ODPRk5AbIl4QcuXsBjKAR05ASknFhxjdCEcWlDziJmXQCScI9nwE8seWpHB22+Q6gwnUbhtf1R3MfqFYXa24fiFYRK+8XDM+OLQjuSJEyHecL/KoZ4tVopvES64zkj3GfFvALaogS5TpjW+mT spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5de768c8-76cb-4235-cc58-08d5ad96ba9c X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5de768c8-76cb-4235-cc58-08d5ad96ba9c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2018 06:02:02.9862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4251 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2018 06:02:05 -0000 Thursday, April 26, 2018 7:26 PM, Adrien Mazarguil: > Subject: [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error >=20 > When creation of a flow rule fails during dev_start(), the usage count of= the > common RSS context is not decremented, which triggers an assertion failur= e > in debug mode during dev_close(). >=20 > This is addressed by tracking the initialization status of the common RSS > context in order to add missing cleanup code. >=20 > A similar issue exists in mlx4_rxq_attach(), where usage count is > incremented on a Rx queue but not released in case of error. This may lea= d > to the above issue since RSS contexts created by flow rules attach > themselves to Rx queues, incrementing their usage count. >=20 > Fixes: 5697a4142107 ("net/mlx4: relax Rx queue configuration order") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adrien Mazarguil Series applied to next-net-mlx, thanks.=20