From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0058.outbound.protection.outlook.com [104.47.0.58]) by dpdk.org (Postfix) with ESMTP id B46515B12 for ; Wed, 28 Mar 2018 08:03:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QPGJ7HeYwkCWezR1xWXicyDqRfbEBtYSbNgHvouK5dA=; b=VFdVeUSpc8Rs2iEqI65Vp2m8XrTnGr4WVq9lmGnA1Agv9iqKi9F5lS5n9Bwu9FrlBy/yJ7xl/Uqh+yYMLVXLP3NsjB4LinLQZOVm5SGvPSDawMgGQpL7TOiFKsK8wezhqXJ89CLTgwFU13h40Qk59hilcs22UraKrnU+x+3TQBc= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4460.eurprd05.prod.outlook.com (52.134.109.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Wed, 28 Mar 2018 06:03:32 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f%13]) with mapi id 15.20.0609.012; Wed, 28 Mar 2018 06:03:31 +0000 From: Shahaf Shuler To: Thomas Monjalon , Adrien Mazarguil CC: Ferruh Yigit , Ophir Munk , "dev@dpdk.org" , Olga Shern Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling Thread-Index: AQHTxHar4tNQDB/ur0qLb+/a8GEPkaPiZPYAgAAEnACAAAn5AIACuE1g Date: Wed, 28 Mar 2018 06:03:31 +0000 Message-ID: References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com> <20180326115452.GF4011@6wind.com> <2388926.RzC4zprzFL@xps> In-Reply-To: <2388926.RzC4zprzFL@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4460; 7:jPA5pNX9J6hpcbzaFKgRzMgQKoMF+1MKw0qiFWaIQ0fnnpQkGi5nYpJ3vPERYjasDFR2ECEbuVDgcWCQfwFxd3tahoPRHa0/OOMx0zGQ/O+5XQ+rpWgDU9uYO96rjr2Uwwh3SJOKo8UP8Z2ErLa2A1C1iC2yxUmlcYMBSpwxGYcPqPplydiBMfEiGAqxXX4h56O+X7DCd7C3gtgvqJONZPhbMaxYauPhvgsXRyL3mUSl8uJZc46sxwH//pFflZyU x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5242764a-c25e-4b6e-4f39-08d59471a254 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4460; x-ms-traffictypediagnostic: DB7PR05MB4460: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB7PR05MB4460; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4460; x-forefront-prvs: 06259BA5A2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(39380400002)(346002)(39860400002)(376002)(396003)(189003)(199004)(105586002)(7736002)(5250100002)(6506007)(68736007)(25786009)(305945005)(99286004)(33656002)(8676002)(93886005)(110136005)(7696005)(45080400002)(5660300001)(54906003)(106356001)(6116002)(3660700001)(486005)(3846002)(486005)(229853002)(8936002)(81166006)(81156014)(2906002)(3280700002)(74316002)(4326008)(66066001)(9686003)(76176011)(2900100001)(14454004)(59450400001)(966005)(478600001)(97736004)(6246003)(575784001)(107886003)(102836004)(86362001)(53936002)(11346002)(53546011)(316002)(6306002)(6436002)(186003)(476003)(446003)(26005)(55016002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4460; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: rRlYG0/JWQWkwrzcjJLvVfApTunpMM2+LirGvx5+IPtG83pUd+qigNoY2kDNhfsnsoTstWAmcCIHCqqA/c5akBc+Hm/qaChk6/GDEqCZOLGcLeGeKTnnH/JUx7QbuUsTrbZfdzqlGiI8jHvs0hfF7ViosFvlKjcQ19OXh9zaofwLI6J5YEB674aY+PSLqz5tMZyzahzeIOWfFj+GTaR/JuJoTNQMaB8wlRDRW1UcHuoL0xCffpaYUdN8jQ/ePq5cNUXI6w46ZI16hDN0lCAFg9LrbsYEYCWAtu4wdH36JeEou8nSit7uKMi/QxTaC1GpX0G5TKCuN077flBnQWTMwQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5242764a-c25e-4b6e-4f39-08d59471a254 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2018 06:03:31.7036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4460 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 06:03:35 -0000 Monday, March 26, 2018 3:31 PM, Thomas Monjalon: > 26/03/2018 13:54, Adrien Mazarguil: > > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > > Previous to this commit mlx4 CRC stripping was executed by default > > > > and there was no verbs API to disable it. > > > > > > Are you aware of the discussion about CRC [1]? Is this patch compatib= le > with plans? > > > > > > [1] > > > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fd > > > > pdk.org%2Fdev%2Fpatchwork%2Fpatch%2F36415%2F&data=3D02%7C01%7Csh > ahafs% > > > > 40mellanox.com%7C90c78c02ec954cc1dfda08d59315619f%7Ca652971c7d2e4 > d9b > > > > a6a4d149256f461b%7C0%7C0%7C636576642435977344&sdata=3DbroGz4U2Kw1 > u9xJk > > > t%2FryP7j2CU9XN0GnM5jsUxHwiNg%3D&reserved=3D0 > > > > I wasn't aware of this notice. Looks like it makes this patch > > unnecessary since mlx4 always strip by default; this patch makes it > > configurable at will and only exposes the capability when HW supports > > its configuration (i.e. the ability to leave CRC inside mbuf). > > > > We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in > > mlx5_get_rx_queue_offloads() in order to fully comply. > > > > I leave it up to you, I don't mind if we include this patch only to > > revert it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP. >=20 > A new flag to keep CRC will be introduced. > We will need toggling anyway. Do we have such CRC flag already? If not I will include this patch and we r= evert/adjust it when the new flag will be introduced.=20 >=20 >=20