From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0051.outbound.protection.outlook.com [104.47.0.51]) by dpdk.org (Postfix) with ESMTP id 3F61E1B1CE for ; Mon, 16 Apr 2018 07:50:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Yv6cq/j77w3b8Er2WUG1boG/7MvKcaJWCzWZXcTR37k=; b=CcflWMhVYID4u0VsfVn+mOapVOdz8Ebje2y7khliE/KfKtxgyv0xEhXKFn1/NzwpRuc8bVQwVn5GEM+XdXURjtX6LXxYkZQt6bWICrE3zI7TWEtxwjVSEFeWGIqeYUG1aSzk02XaSJ1yuJQ6h9qbvmG/dFHZjJNGCB0Mpbyyhpk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4139.eurprd05.prod.outlook.com (52.134.107.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Mon, 16 Apr 2018 05:50:17 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f%13]) with mapi id 15.20.0675.015; Mon, 16 Apr 2018 05:50:17 +0000 From: Shahaf Shuler To: Thomas Monjalon , "Burakov, Anatoly" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: fix compilation without VFIO Thread-Index: AQHT0mhu70myJcNCNE+E2jjE5VuYXKP9ylCAgACfx4CAAEIdgIAACD8AgAAF3ACABC4pkA== Date: Mon, 16 Apr 2018 05:50:17 +0000 Message-ID: References: <20180412133422.104155-1-shahafs@mellanox.com> <23085973.mySOohilc8@xps> <507876726.mBf8imolCA@xps> In-Reply-To: <507876726.mBf8imolCA@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4139; 7:EPk5MgcG80TmY0NAmwiRhYNsZj/7ZybxSB5YnvgwKmnxAZ6FWcuDP6ZAKl8ctsChB/k8bM0/ipVgF/lSYPGT396ETgETu30oSQlCU176JOckadkVfqENIexRKe/638Nn7xYlRHaU+zLghzp1Ts6OI7+fsBKZFFFSA6/N8zWFNd32ZJu0A4tgEY++FBojOlhEdNUKYaSlLmG44RP1JJ57XA2nVxIArZ5IbaNipOexUCx6fAx3HZlsKoio5/D01txx x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4139; x-ms-traffictypediagnostic: DB7PR05MB4139: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231232)(944501327)(52105095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4139; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4139; x-forefront-prvs: 0644578634 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(366004)(376002)(39380400002)(39860400002)(199004)(189003)(43544003)(55016002)(3660700001)(4326008)(110136005)(7736002)(25786009)(6116002)(53936002)(86362001)(305945005)(2900100001)(2906002)(5660300001)(3846002)(6436002)(99286004)(5250100002)(3280700002)(74316002)(14454004)(9686003)(486006)(8936002)(476003)(8676002)(81166006)(81156014)(446003)(33656002)(11346002)(229853002)(186003)(26005)(97736004)(478600001)(102836004)(6246003)(105586002)(316002)(7696005)(93886005)(68736007)(66066001)(6506007)(76176011)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4139; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: mDTsxRUlh98GCg8WyMmur7tcq6HsPFBt7Oaz93BzltAh+b5WYI1nOT0ZfAa+iOpmb2AYuvDS19qGBRtATIuCsgiIbEKVSWVjqwxhvaKYKhORCZnTwMzbMLsN0jby5524SaruIWGX0F7Q1pPc+N3+wyp9MpsUk5sWVjfvvzbLtES8x2Ljc93IdbXBCt4IHRNo spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 26830b64-6353-4e67-03fc-08d5a35dee84 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26830b64-6353-4e67-03fc-08d5a35dee84 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2018 05:50:17.0927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4139 Subject: Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 05:50:18 -0000 Friday, April 13, 2018 4:59 PM, Thomas Monjalon: > > > > OK. Shahaf, will you submit a v2 with this, or should i do it? I think > > it should be just a matter of #ifndef VFIO_PRESENT //define > > vfio_device_info struct #endif - this should take care of the problem > > of hiding the function definitions. > > > > FreeBSD will also need to be adjusted to remove dummy prototypes. >=20 > I think you are more familiar with VFIO than any of us. > It is better to let you do, think about the implications and do the tests= . > Thanks :) >=20 I don't mind whom of us will do it, as long as it will be done quickly. Cur= rently there are some tests which cannot run on our regression due to it.=20