From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02hn0246.outbound.protection.outlook.com [104.47.5.246]) by dpdk.org (Postfix) with ESMTP id 68352235 for ; Tue, 24 Jul 2018 13:54:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tWixXmNdaexpuW0QHzDOZYXe454iMQazhU7qYAlcsPU=; b=i1MinaRUjODT3Mu8Z9DMh0XdjDkp6xskmi+hiY25AI5ZcfZ4k/0Mk/SNxuzx3TSNdBpz/ploUWclJc5D6Rv0SeZGthBc8YH8Ol2reXu4j+Elm2xVROkYR4zQF4VGxHKbqM4ZwUMWAujDaMkxz5h8HwkiLxfPjyfXoXkyHTa9gq8= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4906.eurprd05.prod.outlook.com (20.176.235.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Tue, 24 Jul 2018 11:53:54 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%3]) with mapi id 15.20.0952.022; Tue, 24 Jul 2018 11:53:54 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "dev@dpdk.org" , Yongseok Koh , Adrien Mazarguil , Alex Rosenbaum Thread-Topic: [PATCH] mk: fix application compilation with lmnl and mlx5 Thread-Index: AQHUIzDP+hJIi2bht0eHYPbwhmIV3KSeLpRQgAASfwCAAABeAA== Date: Tue, 24 Jul 2018 11:53:54 +0000 Message-ID: References: <14690e825609ee181e3cd522302d4788ef436f35.1532424524.git.nelio.laranjeiro@6wind.com> <20180724114450.5mrrdkye7elwpka5@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180724114450.5mrrdkye7elwpka5@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4906; 7:J89W/93MKJtBz1EDyUUpe1Lu5F5kvPVaMOrFflsjRg/teQMo10oVC6LMA57nYkKfbqWJb2wlYXW+DiFAV7y+LMyh1hqUewAIThXb7BhuFF5tdUUdZQN5e66hk4kEHbromTHQcwnnLKusj/CGKOWqkY2wytqOoM74Qr36PRFU/QuLcTNTbpoy3nkdYsj3ngLNRCKVs9wL2Xu/T95hFlEnX9bj9MnFhMUNUBnn5S8GWH1JjgcwCkAMNzV9DUlhQWKk x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1cc44fa3-334a-41be-23fa-08d5f15c215b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4906; x-ms-traffictypediagnostic: DB7PR05MB4906:|DB7PR05MB4906: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(131327999870524)(66839620246622)(45079756050767); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(2232096)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4906; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4906; x-forefront-prvs: 0743E8D0A6 x-forefront-antispam-report: SFV:SPM; SFS:(10009020)(346002)(376002)(396003)(39860400002)(136003)(366004)(189003)(199004)(8936002)(11346002)(6506007)(575784001)(102836004)(14454004)(55016002)(8676002)(81156014)(81166006)(9686003)(3846002)(106356001)(6116002)(7736002)(6306002)(305945005)(26005)(86362001)(2906002)(74316002)(6436002)(97736004)(186003)(5660300001)(7696005)(54906003)(6916009)(316002)(229853002)(478600001)(45080400002)(966005)(33656002)(4326008)(486006)(76176011)(99286004)(66066001)(5250100002)(256004)(25786009)(68736007)(476003)(53936002)(2900100001)(107886003)(105586002)(446003)(14444005)(6246003)(59010400001); DIR:OUT; SFP:1501; SCL:5; SRVR:DB7PR05MB4906; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 0JxxPstQY/WmHP1mE/NyH2Yx1P6cNmu66qo1u3HzcMZ1uWXh96SSkmdjgzM6EnkkIz9OYM8vnIragUhikcLH4jcoQWXfnFW7YF7gpv4z1F+Rd/Uh+ZN4GXpdpUgq6wutn+RVuPWZFZzUA/XO3vJ/hZm2ANUEKsVDgotkNoMzHvp77o0JAA2aYNZ9VFWrLw4mKn7fx4Bet/UPKevE4XfBLcXO0D26DG5EC6NX65g/XYiFux71xpfF9RaLTERZwYyPk0SomvfrNG2mlP0BWnrTPbraJunOwCiGXiir50wEK51hu5q8RqREdToNx8axpTO+RemlKpmrb+xe7Z1ZzAkIlLzppQ46zM91QrJWLM4++yeHOkdqGBfcaTDUu3jKFTqQjd51u0/sMSG5XvW49voOnIrBHgYb7NXIqxveSDzAfxd8lbnguk+WZ8jZ1rSbRJMA7DffZX+26qO5ho1/A4xpJol+22fqJxx2YiDDmrU+O/6N7uxGqywrf2RCnPvgiweHLh0SkYTMMsrkaTHt3tL1cF8F3C15kcHQCfsn9WQ1Eenm8zt/szWEFXyRI7zOWgXOeFZGHCC3GMfnjpWiaHUwrcoZ9npXwcjjxVGWDtw7AdO0TTloYmTJzPYOJ28b3BY61AvDcA91y4etwBJQZLC1nMFWkuH1ZQ3U/9dHOBxjN6mPMq7c2hcysWba40OKp58H0Xk3jYQST4ibtm2KTG1p7w== spamdiagnosticoutput: 1:22 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cc44fa3-334a-41be-23fa-08d5f15c215b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2018 11:53:54.0762 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4906 Subject: Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 11:54:09 -0000 Tuesday, July 24, 2018 2:45 PM, N=E9lio Laranjeiro: > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 >=20 > On Tue, Jul 24, 2018 at 11:21:52AM +0000, Shahaf Shuler wrote: > > Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro: > > > Subject: [PATCH] mk: fix application compilation with lmnl and mlx5 > > > > > > When Mellanox MLX5 PMD is compiled with > > > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS=3Dy, the external dependency > on > > > libmln is missing. > > > > > > Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads") > > > Cc: adrien.mazarguil@6wind.com > > > > > > Signed-off-by: Nelio Laranjeiro > > > --- > > > mk/rte.app.mk | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index > > > f4d28c2da..ff39d37aa > > > 100644 > > > --- a/mk/rte.app.mk > > > +++ b/mk/rte.app.mk > > > @@ -149,7 +149,7 @@ else > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) +=3D -lrte_pmd_mlx4 - > > > libverbs -lmlx4 > > > endif > > > ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) > > > -_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D -lrte_pmd_mlx5 -ldl > > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D -lrte_pmd_mlx5 -ldl > - > > > lmnl > > > > This issue raise some more basic question. > > The DLOPEN mode was introduced to run in systems which don't have > > verbs/mlx5 libs installed, because those were the only dependencies > > for the PMD back then. > > Now we have the libmnl, which is external dependency just like > > rdma-core, and following your fix, hard linked also in case of DLOPEN > > option. > > It means the whole DPDK binary/lib will be depended on libmnl and this > > is not what we want with DLOPEN. > > > > Can we consider different options: > > 1. always statically link libmnl >=20 > This will force users to re-compile their application to have the missing > features disabled because some calls are not available, see the list of > HAVE_RDMA_NLDEV_* elements in the MLX5 makefile due to the issues this > Netlink stuff brings. I don't understand.=20 First the HAVE_RDMA_NLDEV_* actually re-define the needed enum in case some= of the user space headers are missing. It is not to disable to support on some features in libmnl. In the doc patch[1] is state the minimal libmnl version: "Minimal version for libmnl is **1.0.3**." This one contains all the needed support for switch rules? Do we expect that w/ more switch rules we will need more feature from this = lib? (not sure, it is only to open the sockets). =20 [1] https://patches.dpdk.org/patch/43266/ >=20 > > 2. dlopen libmnl just like we do for verbs/mlx5 >=20 > You want another glue library. It won't be for this release in this case= , I don't > have time to write such glue. Yes I agree the first approach is better (static linkage).=20 >=20 > > > else > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D -lrte_pmd_mlx5 - > > > libverbs -lmlx5 -lmnl > > > endif > > > -- > > > 2.18.0 > > >=20 > [1] > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fma > ils.dpdk.org%2Farchives%2Fdev%2F2018- > March%2F092876.html&data=3D02%7C01%7Cshahafs%40mellanox.com%7 > C206bd64b84a341f50c6e08d5f15ae0d5%7Ca652971c7d2e4d9ba6a4d149256f4 > 61b%7C0%7C0%7C636680294972217071&sdata=3DGIfPD0xe8QnHaRh%2Bv > BTy1p3r%2FWj3j2GlmcVPFCbSLMw%3D&reserved=3D0 >=20 > -- > N=E9lio Laranjeiro > 6WIND