From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20076.outbound.protection.outlook.com [40.107.2.76]) by dpdk.org (Postfix) with ESMTP id 8B87A231E for ; Tue, 4 Sep 2018 12:02:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+/jyYWsVt2NDwZfxo8kkt2/cdvoEm3Zr9Nqk/z8RXk=; b=ncrqCShz0PlhZU2eWkh0guoOjB2v+UKvGIbYpDydtWOx2v9zq+h4EIdW9Hv17MXzPGkSLwCHtybVSwd+QLz9/YATOvRNV8mrrLCbXOoVrYW4SPyVnW7c8E7+Tz6LUZkktC2ypYVtaAMt50et1MoSC5KGFpyP5WvotcrADcG0Z9k= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4492.eurprd05.prod.outlook.com (52.134.109.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.14; Tue, 4 Sep 2018 10:02:02 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c8e7:d9c1:5054:693b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c8e7:d9c1:5054:693b%6]) with mapi id 15.20.1101.016; Tue, 4 Sep 2018 10:02:01 +0000 From: Shahaf Shuler To: Ferruh Yigit , Thomas Monjalon , Andrew Rybchenko CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] ethdev: make default behavior CRC strip on Rx Thread-Index: AQHURC+RERA7iwGcm0Kfi9QtLeFh9KTf4v1w Date: Tue, 4 Sep 2018 10:02:01 +0000 Message-ID: References: <20180903144501.31373-1-ferruh.yigit@intel.com> <20180904101257.61129-1-ferruh.yigit@intel.com> In-Reply-To: <20180904101257.61129-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4492; 6:Hr9X20RjJG6BIkk3md4OJwfkswkUGUSKWPFI2ZHyOZbCf0/qqCZ1de+l+RJ/4QrjXd0fFxb4S/XHWgNY5evPx2PSl1kvIqRii0cEExfvAjFfQOIJTywFO2qOdJD+WYN+zimp8W/37pL56BGzQV06itcGRNcbpTxkLed8iZxrw2JD21/W43eNjEK9OQ6nXWr6haz4wfp8Ls/EiyFurgHrRuCpXNL4MC8fPwdTVXV2pimiC4aiRV6h3a46ZKJUfoCAHKIh8V9f+MFBRcwthivu7LPEn7F5DhesYXwiUpVAb4w00DaBtKw1dfp7cI9MMPqsgv8JpZA5dXYCd1UZnuld61bQtAIV5VACmHLuyRiZtPChOjxD8JxA5+55fptM0bYE2q+u/fIymjdPZLqaIMKcHfMr+FqlpYl3Uqln+6et7g9oQTYaA27y1c/l796q4hoQ7fj3awbnvIekl6iIudHcmw==; 5:mCRnKLWG0Qd8IcFbTWy7VCogejig69ZpH7YGoZAYewspI40F7xqQgP8sEFwGcSXjXuzDP9gPAzgndfRtEMM/EFwVzRkyWY69P760dJrVH13Jfp2FzyqnEXZoflc8EB2WdOvWH+YEJIlbDJITuEWPxRR6dXIfSBUM4eFXxCGII2E=; 7:6hlIVFzmysnEpNt+aVn9YZEln7KA1tZ4366Z1RixFeLsNDK17hr0fmHdB7nZmysx+HZOhiIEqdyr7yOZGKBwgxjlG9dVK9OdGwI1j806Pg2QIeED+25L9GpnWaGur47iA6kuHL6t0y3X+oUx4p7xKa08TODttO3I33QP1zGCeG1t6+feTh2JdjMvKoO4uOd3EaVO4X9s1Xo85O72SEbcK1aGIk8QEwRLBAYIyqHIgC/HB6o2//ekt/MDpc6728dL x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 4936c389-cbdb-4ab8-2c47-08d6124d75ef x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4492; x-ms-traffictypediagnostic: DB7PR05MB4492: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(10201501046)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699016); SRVR:DB7PR05MB4492; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4492; x-forefront-prvs: 0785459C39 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(366004)(39860400002)(396003)(346002)(376002)(199004)(189003)(110136005)(68736007)(8936002)(55016002)(2900100001)(76176011)(81166006)(81156014)(7696005)(97736004)(6436002)(2906002)(14454004)(99286004)(106356001)(478600001)(316002)(229853002)(105586002)(74316002)(6246003)(66066001)(305945005)(7736002)(33656002)(5660300001)(102836004)(486006)(5250100002)(256004)(25786009)(11346002)(476003)(446003)(6506007)(53936002)(86362001)(26005)(9686003)(3846002)(4326008)(6116002)(186003)(8676002)(83323001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4492; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: nQfLaKjy/20JSrPU4OTC8Db+wxCf5ac0PMQ32Vhtc8udobF8+q/Zg+o/7+6u7n+6QW8UkBHoBKNjsa8+Wp3aH4YGGHgjw5V4BKPB5VqF74bBInc8ipfUKME9syZMqsfI8LhMeOXadMUKrIYgwCVLcFqJlLOjTeRMcQSUdqHiBJC4ghycsdOm0j2W52R2S23ghcyWK6QNb0M781ivdgg96rA4FGAge6FviibDuY78dYjN2knet4ZSURFBAY4zSDiBXO+DMUDZ2FhI2bHE9NDgWVCMOQan4F7QxP6Rr/n0JtmDbnywuBO3tJg2HKPV7bQq6jHCNTXzujOM7pPqRI1knQ8m1v5kGzLLq6FPfDDpOig= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4936c389-cbdb-4ab8-2c47-08d6124d75ef X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2018 10:02:01.9494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4492 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 10:02:03 -0000 Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: > Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx >=20 > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. >=20 > PMDs that support keeping CRC should advertise > DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. >=20 > Applications that require keeping CRC should check PMD capability first > and if it is supported can enable this feature by setting > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() >=20 > Signed-off-by: Ferruh Yigit > Acked-by: Tomasz Duszynski > --- > v2: > * fix flag check > * add KEEP_CRC flag into "show port cap #" >=20 > Note "show port cap #" and > "show port # [r/t]x_offload capabilities/configuration" > does same thing, in long term I suggest removing "show port cap" one Acked-by: Shahaf Shuler