* [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
@ 2018-05-08 12:30 Ophir Munk
2018-05-08 12:34 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Ophir Munk @ 2018-05-08 12:30 UTC (permalink / raw)
To: dev, Adrien Mazarguil
Cc: Thomas Monjalon, Olga Shern, Ophir Munk, Shahaf Shuler
Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
doc/guides/nics/mlx4.rst | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 9564f89..a6bbde8 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -143,6 +143,13 @@ below.
following limitation: VLAN filtering is not supported with this mode.
This is the recommended mode in case VLAN filter is not needed.
+Limitations
+-----------
+
+- CRC stripping is supported by default and this capability is always reported
+ as "true". The ability to enable/disable CRC stripping requires OFED version
+ 4.3-1.5.0.0 or rdma-core version v18.
+
Prerequisites
-------------
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
2018-05-08 12:30 [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation Ophir Munk
@ 2018-05-08 12:34 ` Thomas Monjalon
2018-05-09 10:07 ` Shahaf Shuler
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2018-05-08 12:34 UTC (permalink / raw)
To: Ophir Munk; +Cc: dev, Adrien Mazarguil, Olga Shern, Shahaf Shuler
08/05/2018 14:30, Ophir Munk:
> +Limitations
> +-----------
> +
> +- CRC stripping is supported by default and this capability is always reported
> + as "true". The ability to enable/disable CRC stripping requires OFED version
> + 4.3-1.5.0.0 or rdma-core version v18.
I think it is better to merge this patch with the one fixing the capability.
So we will be able to refer to one atomic commit in the history.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
2018-05-08 12:34 ` Thomas Monjalon
@ 2018-05-09 10:07 ` Shahaf Shuler
2018-05-09 10:31 ` Ophir Munk
0 siblings, 1 reply; 5+ messages in thread
From: Shahaf Shuler @ 2018-05-09 10:07 UTC (permalink / raw)
To: Thomas Monjalon, Ophir Munk; +Cc: dev, Adrien Mazarguil, Olga Shern
Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
>
> 08/05/2018 14:30, Ophir Munk:
> > +Limitations
> > +-----------
> > +
> > +- CRC stripping is supported by default and this capability is always
> reported
> > + as "true". The ability to enable/disable CRC stripping requires OFED
> version
> > + 4.3-1.5.0.0 or rdma-core version v18.
>
> I think it is better to merge this patch with the one fixing the capability.
> So we will be able to refer to one atomic commit in the history.
>
If you agree Ophir I will squash the two patch into one and merge it on mlx4. OK?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
2018-05-09 10:07 ` Shahaf Shuler
@ 2018-05-09 10:31 ` Ophir Munk
2018-05-09 11:12 ` Shahaf Shuler
0 siblings, 1 reply; 5+ messages in thread
From: Ophir Munk @ 2018-05-09 10:31 UTC (permalink / raw)
To: Shahaf Shuler, Thomas Monjalon; +Cc: dev, Adrien Mazarguil, Olga Shern
Sure. Agreed.
Regards,
Ophir
> -----Original Message-----
> From: Shahaf Shuler
> Sent: Wednesday, May 09, 2018 1:07 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Ophir Munk
> <ophirmu@mellanox.com>
> Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Olga
> Shern <olgas@mellanox.com>
> Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
>
> Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> >
> > 08/05/2018 14:30, Ophir Munk:
> > > +Limitations
> > > +-----------
> > > +
> > > +- CRC stripping is supported by default and this capability is always
> > reported
> > > + as "true". The ability to enable/disable CRC stripping requires OFED
> > version
> > > + 4.3-1.5.0.0 or rdma-core version v18.
> >
> > I think it is better to merge this patch with the one fixing the capability.
> > So we will be able to refer to one atomic commit in the history.
> >
>
> If you agree Ophir I will squash the two patch into one and merge it on mlx4.
> OK?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
2018-05-09 10:31 ` Ophir Munk
@ 2018-05-09 11:12 ` Shahaf Shuler
0 siblings, 0 replies; 5+ messages in thread
From: Shahaf Shuler @ 2018-05-09 11:12 UTC (permalink / raw)
To: Ophir Munk, Thomas Monjalon; +Cc: dev, Adrien Mazarguil, Olga Shern
Wednesday, May 9, 2018 1:32 PM, Ophir Munk:
> Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
>
> Sure. Agreed.
>
> Regards,
> Ophir
>
> > -----Original Message-----
> > From: Shahaf Shuler
> > Sent: Wednesday, May 09, 2018 1:07 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; Ophir Munk
> > <ophirmu@mellanox.com>
> > Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Olga
> > Shern <olgas@mellanox.com>
> > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling
> > limitation
> >
> > Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> > > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling
> > > limitation
Applied to next-net-mlx along and squashed into
http://dpdk.org/dev/patchwork/patch/39461/
> > >
> > > 08/05/2018 14:30, Ophir Munk:
> > > > +Limitations
> > > > +-----------
> > > > +
> > > > +- CRC stripping is supported by default and this capability is
> > > > +always
> > > reported
> > > > + as "true". The ability to enable/disable CRC stripping requires
> > > > + OFED
> > > version
> > > > + 4.3-1.5.0.0 or rdma-core version v18.
> > >
> > > I think it is better to merge this patch with the one fixing the capability.
> > > So we will be able to refer to one atomic commit in the history.
> > >
> >
> > If you agree Ophir I will squash the two patch into one and merge it on
> mlx4.
> > OK?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-09 11:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08 12:30 [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation Ophir Munk
2018-05-08 12:34 ` Thomas Monjalon
2018-05-09 10:07 ` Shahaf Shuler
2018-05-09 10:31 ` Ophir Munk
2018-05-09 11:12 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).