From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80085.outbound.protection.outlook.com [40.107.8.85]) by dpdk.org (Postfix) with ESMTP id 6B791235 for ; Tue, 14 Aug 2018 09:35:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7auy+5zaQAFFNo11TOsSnk2vA1LitHGHCspgDYuAySc=; b=DqQzz5HSRmhScNcDPMxwuFBrZk+lDXRUMKY0uciLdFqzQZ+Dye9REY/0AnKgfDIYfOjKMCYGbh0Vl+umYApPMilC6U36GpEc4+BCe6zPEq8xs8DB107N4ShQRJlwaA3h70A9vla+WotOmNhGUbcKVawf8vGSEVSae6FzTMXPEDM= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4411.eurprd05.prod.outlook.com (52.134.109.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.23; Tue, 14 Aug 2018 07:35:37 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%4]) with mapi id 15.20.1017.022; Tue, 14 Aug 2018 07:35:37 +0000 From: Shahaf Shuler To: Stephen Hemminger CC: Yongseok Koh , "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [RFC] mlx5: fix error unwind in device start Thread-Index: AQHUKeL8TJuTvg/rbU67vTTfddBCWaS9X3JAgAB/NYCAAQ97YA== Date: Tue, 14 Aug 2018 07:35:37 +0000 Message-ID: References: <20180801215952.25326-1-stephen@networkplumber.org> <20180813082049.1758d647@xeon-e3> In-Reply-To: <20180813082049.1758d647@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4411; 6:9Wizs3o+bj2mH1J41+4kAq7j4Ti19oevQgEeM3dMbVbz06qvObE2JwhnVhoEf9RgJ2FIRVQy/PsRRC7sYutczqB9WeeHM2SEr18jhyecTjQt1RNQ9JbcfK9aw8jwXt7YtnYRy0bECbR9+OMa4Iqc1pFb+SR88H4lLPI/rLqg2kP+KHatzVRjlb95jrauOP8h/pwEg5Cv0jJyE86PFS/QLigyG2+oiWnLf7Rpo9H4WD8P3soZvCBVGN/Sk3sfHBW+9ifRBYyTh98D/zaZdxnCEvLksQQNX5yPxqmNFPVxWTw392PnzvtGD2mpYDMzDq0TpUqzhjXObfVKXzpnS/3fueeZQZfmVoQ3nV/GGdPajTzicAUf6nQCSoi/XUCkTKeTrGbGb9Hlkep4vEbwSOLDLonklwEUf6mqoUSWDoDcF/P2QPQjxs3YEk8u/1JXrNWcGi3H80ISEkBPwOaP9Uu/zA==; 5:a7ljxY0Bxe2wPIRs4MiXLj4x0GzGc8Ohc0r++wn0jJrbovJ0CRWx9yE/dWWW5B7S6xxpuRZSK74unQxiTEVZoIH/DIf2o1CGadwNVgxKnTHmjiNMq0u1xgSFU7pq0+JMbnOwq/Xev9y50gap/BgqC4+wbbe8lAmiA9pkRo/ESFE=; 7:csGUUS7VY1XiOAUQxgCZGRAb+YW8GtJONYN6upzDl4IN1N3lueoXK+d4OpcISQwFSsPaRTd9jcwPrZxU7tqta11VyJWTWav2QMIrsV/YFoECjVf3GdLGXtRPV4S82H7sJLWau5VFTQSj0bpAkIki1azt3TZkluhtRVgO9i/RNB+CAYtoQiAfb2KQq1tevvD6nTbuPWvJeSwsg5I8n4iuXLvUT9FM3svKeVDGkX+BMprmhKx8sQWoXi9j+k7YUekG x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: ccf9f8a3-5097-414a-f753-08d601b88747 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4411; x-ms-traffictypediagnostic: DB7PR05MB4411: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4411; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4411; x-forefront-prvs: 0764C4A8CD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(39860400002)(396003)(136003)(376002)(189003)(199004)(6246003)(446003)(3846002)(66066001)(74316002)(7736002)(11346002)(5660300001)(97736004)(5250100002)(6116002)(186003)(2906002)(105586002)(26005)(305945005)(54906003)(316002)(86362001)(106356001)(102836004)(256004)(6506007)(25786009)(8936002)(6436002)(99286004)(68736007)(478600001)(76176011)(7696005)(53936002)(55016002)(81166006)(9686003)(6916009)(2900100001)(476003)(81156014)(14454004)(486006)(33656002)(8676002)(229853002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4411; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: upfMfW93h30mEnLSm86FCpPmRUaM4UQ9a7HB5fWUTRE9Prj7lRQsZ0Wa1LkjZdKN92QdJG5gs9nzwpnn+sCWrncqDcKp1SZpIOEXvSANMYJNNirXxefZbIos5I/gsJZmn96Dtx4G57yA/JwjkwQkBpFEqUy2ipGn9NYO4Au1j7mhe159TBhgJB43/165ygcVPGcvE+Gz0+lklE6UPpkeqQ/Una315UTljjZWGs3XfAeUBvBVn/T+Rf7RJcFEQRIVOcIi4JoWlU4Xz8fjTlmjnW8lWkA5Mg9zdySLCUtHQWQI72AD1UctrnFsShD7uXPgmQiKF2i4gThpJnKy12uzOMtlkfdAru944Tn/lkY5LTg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccf9f8a3-5097-414a-f753-08d601b88747 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2018 07:35:37.3203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4411 Subject: Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 07:35:41 -0000 Monday, August 13, 2018 6:21 PM, Stephen Hemminger: > Subject: Re: [RFC] mlx5: fix error unwind in device start >=20 > The issue was caused in an early version of netvsc VF support where it fo= rgot > to call dev_configure on the mlx5 device. In that case mlx5 would get > confused and stuck. I see, well missing the configuration stage is quite critical regardless. I= am surprised ethdev layer didn't block the device start, and maybe this is the right fix for this specific case till a rework will b= e done for the mlx5 device start logic.=20