From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Ophir Munk <ophirmu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"Olga Shern" <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling
Date: Tue, 10 Apr 2018 06:26:57 +0000 [thread overview]
Message-ID: <DB7PR05MB442670C9C3B61C314761BF29C3BE0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180326093433.GD4011@6wind.com>
Monday, March 26, 2018 12:35 PM, Adrien Mazarguil:
> Subject: Re: [PATCH v3] net/mlx4: support CRC strip toggling
>
> On Sun, Mar 25, 2018 at 08:19:29PM +0000, Ophir Munk wrote:
> > Previous to this commit mlx4 CRC stripping was executed by default and
> > there was no verbs API to disable it.
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> > ---
> > v1: initial version
> > v2: following internal reviews
> > v3: following dpdk.org mailing list reviews
>
> Except for the remaining extra space mentioned below :)
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
It seems the direction of the KEEP_CRC flag discussion[1] is for the flag to be included only on 18.08.
Hence applying this patch (with the extra space removal). In case KEEP_CRC will be included on 18.05 we will have another patch to adjust.
[1] https://dpdk.org/dev/patchwork/patch/36416/
next prev parent reply other threads:[~2018-04-10 6:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 9:00 [dpdk-dev] [PATCH v1] net/mlx4: disable CRC stripping Ophir Munk
2018-03-19 16:36 ` [dpdk-dev] [PATCH v2] net/mlx4: support CRC strip toggling Ophir Munk
2018-03-23 14:53 ` Adrien Mazarguil
2018-03-25 16:17 ` Ophir Munk
2018-03-25 20:19 ` [dpdk-dev] [PATCH v3] " Ophir Munk
2018-03-26 9:34 ` Adrien Mazarguil
2018-04-10 6:26 ` Shahaf Shuler [this message]
2018-03-26 11:38 ` Ferruh Yigit
2018-03-26 11:54 ` Adrien Mazarguil
2018-03-26 12:30 ` Thomas Monjalon
2018-03-28 6:03 ` Shahaf Shuler
2018-03-28 14:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB442670C9C3B61C314761BF29C3BE0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).