From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0042.outbound.protection.outlook.com [104.47.1.42]) by dpdk.org (Postfix) with ESMTP id 201E31BA20 for ; Tue, 10 Apr 2018 08:26:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ludgh+9q8TPfHZhn3POqPeDV22sWsUfgq9/SjDcjeNA=; b=CUGS0jPHS9xMAZtvpY/HCAg6alYs7v33u//161IjHU4vWDI0wJmh4lEJJraRXduQH9omfGa/hRxmpNG14AIMyloY6Gm4TCYzpWkXc2gAMfEV6puclHxh+Wjhvg2PI8gKErqw6PfHbGOaF2SXp2/KpE3Z/vEDBFJWCipw3BgPHRI= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4171.eurprd05.prod.outlook.com (52.134.107.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 06:26:57 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f%13]) with mapi id 15.20.0653.014; Tue, 10 Apr 2018 06:26:57 +0000 From: Shahaf Shuler To: Adrien Mazarguil , Ophir Munk CC: "dev@dpdk.org" , Thomas Monjalon , "Olga Shern" Thread-Topic: [PATCH v3] net/mlx4: support CRC strip toggling Thread-Index: AQHTxHar4tNQDB/ur0qLb+/a8GEPkaPiQl6AgBddytA= Date: Tue, 10 Apr 2018 06:26:57 +0000 Message-ID: References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com> <1522009169-13860-1-git-send-email-ophirmu@mellanox.com> <20180326093433.GD4011@6wind.com> In-Reply-To: <20180326093433.GD4011@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4171; 7:txKDm1dDw85upIT4zy/ZQGefE4SqBRVDrcdCFSGGgX692Z3xxfGVIks4Gozq4rAOWPsT9xwlK+23fflsXyyXpa30gG//EU5FEpGoTJXHYHAoV4moRrv56edyzX7oy02LfyqUv//3KySV4kqrVjj6Qm/1W/UhYZhSUlRzelAbX20cxSRn9OxF6OCnBH1AXUCPLcMUe7gTZynPTrjBCgb7Ep+9S5C/19RrvHY2GuUWe1uD4JyPhXwIqYMRXP9ON+Is x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4171; x-ms-traffictypediagnostic: DB7PR05MB4171: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(15185016700835); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB7PR05MB4171; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4171; x-forefront-prvs: 0638FD5066 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(39380400002)(366004)(346002)(189003)(199004)(4326008)(102836004)(81166006)(8936002)(81156014)(9686003)(6306002)(55016002)(8676002)(6436002)(97736004)(105586002)(5250100002)(68736007)(106356001)(229853002)(25786009)(2900100001)(107886003)(33656002)(6246003)(6636002)(316002)(54906003)(110136005)(966005)(14454004)(5660300001)(11346002)(99286004)(53936002)(6506007)(476003)(186003)(76176011)(7696005)(486006)(26005)(446003)(74316002)(3280700002)(2906002)(305945005)(7736002)(66066001)(6346003)(6116002)(3660700001)(3846002)(478600001)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4171; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-microsoft-antispam-message-info: GFO+htW4Cf4f1k/AecioMthSBv7MMrc7jBrfKCAiP8pjJKplOWmk//GitkcG7bZDEgEYQyjetacc9Wbeu+gTnjnxKnLOOSWGrhZaJlnsTAj8gVHLyidjkHr0+DMr3nHZLXnPh9am+fy6oXw8w/7BS9ztE+PLvDJEAB3gOATIa0sBAlI35FoRmhsg23NfRRVP/2Cfg4pPaN2WmlIbxgzqsGgULbkEpd1ffwAy0DMYDXEyuWq8RzdUfdVOzICuwEOZDXJY/NHC+dmg6ScfAr4ZJmOMniXeeR9S1UA/qP6YtchD+gL4SQSOUgYcG2FU381ZLFomjOX+TFQiXsU/7iVl8ZnSsphHN3VcqcLog1jlL5TaIhebIoxMTf2HRNRdukjl86OsjsW4pxtoMAifxtBb4Jh7n/kpF160dS+n8W/vGSI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9926bd37-8d1c-4a36-34da-08d59eac0f9b X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9926bd37-8d1c-4a36-34da-08d59eac0f9b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2018 06:26:57.4936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4171 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 06:26:59 -0000 Monday, March 26, 2018 12:35 PM, Adrien Mazarguil: > Subject: Re: [PATCH v3] net/mlx4: support CRC strip toggling >=20 > On Sun, Mar 25, 2018 at 08:19:29PM +0000, Ophir Munk wrote: > > Previous to this commit mlx4 CRC stripping was executed by default and > > there was no verbs API to disable it. > > > > Signed-off-by: Ophir Munk > > --- > > v1: initial version > > v2: following internal reviews > > v3: following dpdk.org mailing list reviews >=20 > Except for the remaining extra space mentioned below :) >=20 > Acked-by: Adrien Mazarguil It seems the direction of the KEEP_CRC flag discussion[1] is for the flag t= o be included only on 18.08. Hence applying this patch (with the extra space removal). In case KEEP_CRC = will be included on 18.05 we will have another patch to adjust.=20 [1] https://dpdk.org/dev/patchwork/patch/36416/