From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0078.outbound.protection.outlook.com [104.47.2.78]) by dpdk.org (Postfix) with ESMTP id 596C31AFEF for ; Wed, 9 May 2018 12:07:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kKQp1l3fHGtwBzVVjSiFv3ZzKADFu+Ie/ViLd66ETo0=; b=ENhD6tD0VMc/kvNx0BZ6gQ4kvaxNgOwC0Y/kLIqr8GCeRYus2iKLx2p6udH0eyUMIxFsrCtzUkAUZtEtJMsTG/AMiyDJLYTFXqhkvGZEn8pC9KNQyWKy0ZqHBYSPsqzezuXx2BCBRlIgm/gKnFoPqUkE8riNwBSodgM6w56YrWE= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4170.eurprd05.prod.outlook.com (52.134.107.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Wed, 9 May 2018 10:07:29 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0735.018; Wed, 9 May 2018 10:07:29 +0000 From: Shahaf Shuler To: Thomas Monjalon , Ophir Munk CC: "dev@dpdk.org" , Adrien Mazarguil , Olga Shern Thread-Topic: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation Thread-Index: AQHT5shiKifE7EvHH0i5SVE5dRT76aQlxD+AgAFpF5A= Date: Wed, 9 May 2018 10:07:29 +0000 Message-ID: References: <1525782629-897-1-git-send-email-ophirmu@mellanox.com> <1663463.84SeaxCa5g@xps> In-Reply-To: <1663463.84SeaxCa5g@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4170; 7:KKPalOa5TtQdkwG5ObCKQX0QUKLnzpf/md6qv3ehPHpdQEwixpTlP2BJAb0Wd8MWEJ/l0Dz2U2YWCwDroeZuwnQK4smkraG1w42pzbFbc6B4H01yKR8GPqKdC/dFAvbu5+hVyBvGDxtGw9n2t2AGY/fx0+Qw6PU2+fgz2pCCj42n+iM/H1Tk9fkSty+NfJ7D6spRAtv+/1/Xm0HJgaOTuJJp1w84oWlaMXDxYA7tNguqosAIE4bl/Ea7T5VgDrLe x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4170; x-ms-traffictypediagnostic: DB7PR05MB4170: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR05MB4170; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4170; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(396003)(376002)(366004)(199004)(189003)(305945005)(6506007)(9686003)(446003)(3846002)(53936002)(11346002)(26005)(186003)(486006)(5250100002)(476003)(99286004)(316002)(6116002)(7696005)(102836004)(54906003)(7736002)(86362001)(76176011)(2900100001)(5660300001)(3660700001)(33656002)(66066001)(81156014)(74316002)(107886003)(110136005)(8676002)(81166006)(4326008)(229853002)(25786009)(6636002)(55016002)(14454004)(68736007)(6436002)(3280700002)(97736004)(106356001)(2906002)(478600001)(8936002)(105586002)(6246003)(168613001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4170; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 97lTPInElh8tpBK+Zrc6Fzert49xRR+yQfC90hnsXhBDpHA9S2MGMWjEF2ItdINtzARckTx29G1qYKji34+0VX41J08n8N/NY1mEmhvszvOiwlbOduX66i0OcmsjMlMoAGY1g4lhp3LqMQE9+fGjYwXSKlYSiCNo3teDy4hplULq+5xC04S4nQbPhhXvXK2l spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d962f09d-b993-4033-7605-08d5b594ac34 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d962f09d-b993-4033-7605-08d5b594ac34 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 10:07:29.0605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4170 Subject: Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 10:07:30 -0000 Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon: > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation >=20 > 08/05/2018 14:30, Ophir Munk: > > +Limitations > > +----------- > > + > > +- CRC stripping is supported by default and this capability is always > reported > > + as "true". The ability to enable/disable CRC stripping requires OFED > version > > + 4.3-1.5.0.0 or rdma-core version v18. >=20 > I think it is better to merge this patch with the one fixing the capabili= ty. > So we will be able to refer to one atomic commit in the history. >=20 If you agree Ophir I will squash the two patch into one and merge it on mlx= 4. OK?=20