From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20043.outbound.protection.outlook.com [40.107.2.43]) by dpdk.org (Postfix) with ESMTP id 5606023D for ; Mon, 29 Oct 2018 11:03:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pSW8xBlgihV8ZBGPinZ5Q1yvvNJUbfdUeD+YB/0zsKw=; b=vkcQAZxMgJCNR44bt46+TPpivSsk4tuQ+tJqUptgAdxK4SxNECgTPVDsMKSG3zs9tYsgZxlWFLGjiVygzo0AGRWruOfvyyRtqup3LUqvQ09bc5j7gKOZzKDXxBgs8l22rAgIUd1FSwO8/fBDFEMuukGIpeVvB+XL7aW22N3hqVQ= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5307.eurprd05.prod.outlook.com (20.178.42.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.22; Mon, 29 Oct 2018 10:03:04 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973%3]) with mapi id 15.20.1273.027; Mon, 29 Oct 2018 10:03:04 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [dpdk-dev] [PATCH v6 0/6] add encap and decap actions to Direct Verbs flow in MLX5 PMD Thread-Index: AQHUbJ6gBW28VuoLZk2NjGFvME/9naU2A2Ww Date: Mon, 29 Oct 2018 10:03:04 +0000 Message-ID: References: <1539259967-10975-1-git-send-email-dekelp@mellanox.com> <1540498108-18358-1-git-send-email-dekelp@mellanox.com> In-Reply-To: <1540498108-18358-1-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5307; 6:p0Yne680/gdYLjjIdTxXh8UZayxSeLzEyIT26v8fY2W+BTiVOxBDCKalmsqvewjJfMcEH3O+LQxosU/EoEZVmMvWHI4cmtYAvzUpZf94hYsXKa8yUh0Lh52/smDbgacCGb2agLDkmjcvaYojqlk0hMPebA/WCC7pXrWTZa2gbM8+MIUP6nSHOaS7tcK1nkdO7DH1e5AJgU0SQAaQxwh9zScIGjohm5r2S3gepxhC7NWDy1S6LgadRS6nBbb0TbU/SDWgRGMxzHaDEuLRhCsb2f0OTtEiwtdtSNuPhbghSno4poq7URr8IAStNblCdHnglK5N7fU60oDNaAQ2KI49sF4QJ2VqZykYsNZWZ2ooQxz6n4NIxz1JmUxZJeD88jYzJ4M3YQeG8wN8Jb/RLwaP7JtM1XZ7TT4+jjCiaj2NEEhJusD5HnvQYs4mQlnKRQ8sQHcojsI4QCj8liSh5ll00A==; 5:tUlJJekhO66v+oW1/X27M+DM/RFlQwXCMOvRT9mnqetlU0HM9aI5f+A/0ohe5Z3afSKI7nskEy0bj8lE0tQlphHSnIL0AoicZw6L2gIgS/q1ExMx1b15jOMygVdFsu8HX9bhKvGqnXbDjA5G/eQvdwsvbM8vQAcqYOKHC9DKUug=; 7:lVwdM4Rj77qyhwGeIcowC/Vz4nAJzRaYtfzxncBX5364IyCuSzJvom0OU0lrEPH+YF92uzDddnutpZfk640tYLzTpByjB9mj7jHQ3RfxSh69KixGThR67ednb3ewGaG5hxxOg3RHZnrzApvU2/vzyA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9107e5d3-e1b2-4dea-b2bd-08d63d85b7b9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5307; x-ms-traffictypediagnostic: DB7PR05MB5307: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(45079756050767)(189930954265078); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231382)(944501410)(4982022)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB5307; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5307; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(396003)(366004)(39860400002)(189003)(199004)(110136005)(26005)(54906003)(486006)(14454004)(186003)(102836004)(6246003)(305945005)(53936002)(229853002)(7736002)(9686003)(476003)(66066001)(5660300001)(478600001)(33656002)(6506007)(55016002)(316002)(6306002)(76176011)(966005)(45080400002)(7696005)(6436002)(99286004)(25786009)(107886003)(4326008)(2906002)(14444005)(3846002)(6116002)(256004)(2900100001)(86362001)(74316002)(71190400001)(6636002)(575784001)(8936002)(11346002)(446003)(97736004)(71200400001)(68736007)(81166006)(105586002)(81156014)(5250100002)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5307; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: d4seOj1WLhnfRxv9/If90ErOb35n+Nr+aR5wzvybzIYY/kp9uq0UWV6eEiY8MwgDMsVjzY/dOUkyMQJzHwt+nsM6oGYuooZff/o/v1lkrRyHmu6b74xc8DM58ghkhnPHnBVppoxqo30XHbDUVrTMWEwKWc00nzBbeYwd0MZqAtfBIMIWSgqZ5+LaJ66hm2Bk851/yNi38gvjJ5QpXfiISToDqVm4O2M+zHb0MQ3jbmBOsKnkPwNhdOdqs5kQaOrFUXbFjcxGYtV676K8Tpqk/rPeqWODrqEhmiwNv7t86ftickVinyTeTYMEdD2TvXB9HXWRAedVnfuQWV6SW1xXOiWs9fEAKvDJfnNjG3WMGpc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9107e5d3-e1b2-4dea-b2bd-08d63d85b7b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 10:03:04.0368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5307 Subject: Re: [dpdk-dev] [PATCH v6 0/6] add encap and decap actions to Direct Verbs flow in MLX5 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 10:03:06 -0000 Hi Dekel, Thursday, October 25, 2018 11:08 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v6 0/6] add encap and decap actions to Direct > Verbs flow in MLX5 PMD >=20 > This series adds support of encap and decap actions in DV format. > L2 tunnel support for VXLAN and NVGRE, and L2/L3 tunnel support using raw > data buffer. > It is using the generic encapsulation framework from [1]. >=20 > [1] "ethdev: add generic L2/L3 tunnel encapsulation actions" >=20 > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmail > s.dpdk.org%2Farchives%2Fdev%2F2018- > October%2F114654.html&data=3D02%7C01%7Cshahafs%40mellanox.com > %7C5c61dd00f0ea45acba0608d63ab5c0e6%7Ca652971c7d2e4d9ba6a4d14925 > 6f461b%7C0%7C0%7C636760949640981142&sdata=3DtdOJhJfndTAP6Uotk > MJrkgBsa7AXljXJRMPsivfveUo%3D&reserved=3D0 In general looks good, please see some comments to address.=20 >=20 > --- > v6: > * Adapt L2 tunnel to VXLAN and NVGRE > * Add encap/decap using raw data > v5: > * Move DV actions code under common DV flag. > v4: > * Update in glue functions. > v3: > * Apply additional code review comments. > v2: > * Rebase on tip. > * Apply code review comments. >=20 >=20 > Dekel Peled (6): > net/mlx5: add flow action functions to glue > net/mlx5: add VXLAN encap action to Direct Verbs > net/mlx5: add VXLAN decap action to Direct Verbs > net/mlx5: add NVGRE encap action to Direct Verbs > net/mlx5: add NVGRE decap action to Direct Verbs > net/mlx5: add raw data encap decap to Direct Verbs >=20 > drivers/net/mlx5/Makefile | 2 +- > drivers/net/mlx5/meson.build | 2 +- > drivers/net/mlx5/mlx5_flow.h | 15 + > drivers/net/mlx5/mlx5_flow_dv.c | 671 > +++++++++++++++++++++++++++++++++++++++- > drivers/net/mlx5/mlx5_glue.c | 38 +++ > drivers/net/mlx5/mlx5_glue.h | 10 + > 6 files changed, 731 insertions(+), 7 deletions(-) >=20 > -- > 1.8.3.1