From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0049.outbound.protection.outlook.com [104.47.2.49]) by dpdk.org (Postfix) with ESMTP id 8200C4C76 for ; Sun, 18 Mar 2018 06:52:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GPq9QvoCgYxNNGYE5intiC1FS3ss+cu6enRK6LXF8qQ=; b=l70VGgwrnaj4oNT9po/UeuT4Q2zjaCQXb4r7nXMb/sftEIfms5bxjBjvzQpzvVuDXbjxFLU7F0nsp3GW4pCk2VdGo1ThHfqOYFjXFybODgLFXF0Wg9fI4/ud1rMUXAPuCtqMP7Epyr1/x/F7a6X5wtQFKTP0I+YJyx6INFnNiRk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4139.eurprd05.prod.outlook.com (52.134.107.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Sun, 18 Mar 2018 05:52:18 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e%13]) with mapi id 15.20.0588.016; Sun, 18 Mar 2018 05:52:18 +0000 From: Shahaf Shuler To: Ferruh Yigit , John McNamara , Marko Kovacevic CC: "dev@dpdk.org" , Thomas Monjalon , Patil , Harish Thread-Topic: [PATCH] doc: update new ethdev offload API description Thread-Index: AQHTvT6xePKXlKiB2UKnd0hyIUztKqPVfsyw Date: Sun, 18 Mar 2018 05:52:18 +0000 Message-ID: References: <44e451f86e4582815767cf75b4e0f01f5cc60b5f.1507104596.git.shahafs@mellanox.com> <20180316155138.125423-1-ferruh.yigit@intel.com> In-Reply-To: <20180316155138.125423-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4139; 7:ff1xrldnsd9TGDmpQTHIPlVCO9LzCnxqICBO5cphVEBaQO6e7g725/AfItTY/+QRaTG4446OoyF3EtP6LFbbAIu2jnAUPxDoYu4+Pea7zNUCvdsdUdLjwxbm6CQNobE0mgshIreWcqNpxOlKu63fTQIAMOMHra6uEmn78WaLwwNBAvo1kx1+wFQfvzrJwVx2J3NCTHpudNtqlDKNUgGbDuhKodBJzF9AKghmQZxIQk9ErO6u9rDyBnzOK2xPKSaA x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d8648cab-5ce3-4d57-71ea-08d58c9468fb x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4139; x-ms-traffictypediagnostic: DB7PR05MB4139: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501300)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4139; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4139; x-forefront-prvs: 06157D541C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(39860400002)(396003)(366004)(376002)(199004)(189003)(4326008)(229853002)(9686003)(54906003)(110136005)(3280700002)(76176011)(26005)(5250100002)(3846002)(6116002)(2906002)(59450400001)(316002)(68736007)(99286004)(186003)(106356001)(3660700001)(7696005)(14454004)(53936002)(8676002)(81166006)(81156014)(6506007)(8936002)(33656002)(74316002)(2950100002)(2900100001)(305945005)(7736002)(55016002)(86362001)(478600001)(66066001)(105586002)(102836004)(97736004)(25786009)(6436002)(5660300001)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4139; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eLMkrwrbWyhJozL99VIUvEmgAoWfEbyLKlGnPUeMvy8BkyoaEwvvs5HiMXppVu7w6pzdDpCQQ1mQOEbEhc3TtQE+1XOwbUp72or7dCNSPFh0ytF48nGB1oTMPf7hCresI1w1AREX5WirjF9vsGLdPElLHmnceeAS2aAM0WbED+fkniVmMylgGMlwvtxLCVT4wITmGS2oiNGfWNqXtQOcvFs9fOt1oGzgd+5tXHGUWLvolK8ixHClSlB62fvmoeE0r6FVOkn2vCRFrbUzu52Gl1XhBIklapvI95thpKF4X8FczSHdVJ+8izfSBuMx1vp+L1/fmXeev6Xg+hGweVVNjQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8648cab-5ce3-4d57-71ea-08d58c9468fb X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2018 05:52:18.6213 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4139 Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Mar 2018 05:52:22 -0000 Friday, March 16, 2018 5:52 PM, Ferruh Yigit: > Don't mandate API to pass port offload configuration during queue setup, > this is unnecessary for devices that support only port level offloads. >=20 > Fixes: 81ac560dc1b4 ("doc: add details on ethdev offloads API") > Cc: shahafs@mellanox.com >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: Patil, Harish >=20 > Btw, this expectation from API should be clear from source code and API > documentation (doxygen comments in header file) instead of > documentation. Am I missing something or we are doing something wrong > here? > --- > doc/guides/prog_guide/poll_mode_drv.rst | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/poll_mode_drv.rst > b/doc/guides/prog_guide/poll_mode_drv.rst > index e5d01874e..3247f309f 100644 > --- a/doc/guides/prog_guide/poll_mode_drv.rst > +++ b/doc/guides/prog_guide/poll_mode_drv.rst > @@ -303,9 +303,7 @@ Supported offloads can be either per-port or per- > queue. > Offloads are enabled using the existing ``DEV_TX_OFFLOAD_*`` or > ``DEV_RX_OFFLOAD_*`` flags. > Per-port offload configuration is set using ``rte_eth_dev_configure``. > Per-queue offload configuration is set using ``rte_eth_rx_queue_setup`` > and ``rte_eth_tx_queue_setup``. > -To enable per-port offload, the offload should be set on both device > configuration and queue setup. > -In case of a mixed configuration the queue setup shall return with an er= ror. > -To enable per-queue offload, the offload can be set only on the queue > setup. > +Per-port offloads should be set on the port configuration. Queue offload= s > should be set on the queue configuration. > Offloads which are not enabled are disabled by default. >=20 > For an application to use the Tx offloads API it should set the > ``ETH_TXQ_FLAGS_IGNORE`` flag in the ``txq_flags`` field located in > ``rte_eth_txconf`` struct. I am OK with such change. However, while documentation is good, most of the customers learn on the AP= I usage from the existing examples.=20 Currently both examples and testpmd behave according to the old approach, s= ee example from testpmd[1] before the rx_queue_setup. I think a modification there is needed if we are going to change the API.=20 [1] /* Apply Rx offloads configuration */ = =20 port->rx_conf.offloads =3D port->dev_conf.rxmode.off= loads; > -- > 2.13.6