From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60065.outbound.protection.outlook.com [40.107.6.65]) by dpdk.org (Postfix) with ESMTP id 646F01D7 for ; Tue, 13 Nov 2018 19:39:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F6fFCsqT2K8cdoq3IIkCaOizvtlUIEheQww1zyO20+k=; b=WWvpO4JSjmXPaOzVjjQ8RVhxlOFOM6HNnTI6Bo2HJckxzFhSxc3kqNFhECxmbEjnyM3bbKiS4kJiZCYOyCMkSekFPbeDbifqARdt8nMAZ8fBv9haeHojiv14f1fuKkUruSIdJ8B/HqFbyQ5Axna68WjSDIXte5BPs/4aWnOi4OE= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4889.eurprd05.prod.outlook.com (20.176.235.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Tue, 13 Nov 2018 18:39:04 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f%2]) with mapi id 15.20.1294.044; Tue, 13 Nov 2018 18:39:04 +0000 From: Shahaf Shuler To: Adrien Mazarguil , Ori Kam CC: Ophir Munk , Yongseok Koh , Andrew Rybchenko , Ferruh Yigit , "dev@dpdk.org" , Thomas Monjalon , Asaf Penso , Olga Shern Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types Thread-Index: AQHUdnuTzEeEC1WTSkenbNxbXJIGnKVEDEOAgAA0mQCAABg3AIAAEryAgAAYpICAAQ60AIAA73+AgACYpgCAAzt4AIADpSyAgAAU3sA= Date: Tue, 13 Nov 2018 18:39:04 +0000 Message-ID: References: <1541582611-1609-1-git-send-email-ophirmu@mellanox.com> <20181107093109.GG4638@6wind.com> <20181107140604.GL4638@6wind.com> <20181107164118.GM4638@6wind.com> <20181113171519.GF17131@6wind.com> In-Reply-To: <20181113171519.GF17131@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4889; 6:81yug7r1grjhYDyjI00im3KHan0sK+WtRks9HhiBykMGKFyPMBIV8KVw0387lk46Az7d1ltlZQ/qM//0ivD1D9c9DNv2RI6x4OCU5fO37k0Ray6FL+bwRAJfAVgXgTWjIbwOtOWKHoIbMn2WINJOQUFuYe11NScEwNqpEO3XW402erWRY7vw6KzX6rhU96O0BvoSrHB50iJe7eyl/rIWoBd7noMWkwQaIZnusEdX5AJnS59Nbg/qb5iYeAYvHPypiKlVjThk5BE6s0MN6RBXTIJQGUuq1oXtMsqQzSechR8c3bSiNDmrwW6Wn60r1me/yi5P40iJ+GEEWsN5+aEiWXpFYhA2K8ymY9EiqV7zyt4LuR0+DEIljJTRMMCxtNhMxfar4q7+B4CaJeABiMLupKwac6D54hOZpZ084hrKU1P46snMomucWQbyp2qsBwzlKCc2ZdUQMLaOUQtKZKOuJQ==; 5:b+m5w8VHiYBgSITgyZCMtw/VdcUB2nlkZRYSMD5slR4VTbJXwvhDJNJgkYNU7oBPueEHRE5E3FHwJ8+jCUTFXkjdMGA6wkSwvpPbdVCKyIaqKkPVtto9Qer6iRCrnze1oEmlBEValXE7dRF6Cxps/ea5U5ta+eT7u6av7T4xs7s=; 7:H2YcEfMpspQAi+QoaPe8Nx2XMFXaDoZ/WR5ztn3WiXmk0VAgobsbUXCdFCjsWhcOVpsqMpJshr2h7Gij5zjTDwzRG7yW8lk+auvr4BgOgsB8qCV3sj/6lM4CUl5vUcg7DCCqCfawbj9tq78vgoxc4g== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 64a02aa6-a590-460a-96ac-08d649974998 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390060)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4889; x-ms-traffictypediagnostic: DB7PR05MB4889: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397)(45079756050767)(189930954265078); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231406)(944501410)(52105112)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB4889; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4889; x-forefront-prvs: 085551F5A8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(346002)(136003)(39860400002)(189003)(199004)(2906002)(33656002)(3846002)(6116002)(2900100001)(6436002)(6506007)(76176011)(5660300001)(97736004)(99286004)(110136005)(446003)(102836004)(316002)(54906003)(74316002)(26005)(186003)(7696005)(71200400001)(68736007)(305945005)(7736002)(486006)(476003)(93886005)(71190400001)(11346002)(256004)(66066001)(14454004)(8936002)(478600001)(966005)(25786009)(45080400002)(86362001)(575784001)(81166006)(107886003)(4326008)(8676002)(9686003)(53936002)(105586002)(106356001)(6636002)(6306002)(55016002)(81156014)(6246003)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4889; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: gEpCDmT40doas2tmfVDtSvtPuqW+FwZwguoIediycQCQgkOwgXy7ggXxzI/f2wXXWWyTN7zTpkwN0oBiG9bYVrG5/F/Lh6QsrcQbdc2snGvL2rqGPKivx6+XOhPmqSmJHtqUyqRcJXjRikVWD7RqmitbBAotA0yObO5cL9mhKHyjRhB+VLzGdcIzmyBCKGZkED+7Ccr6FhlWjDX72QafOTe00awQgDVYxPCVcWHiRqwgvu6S60wzUlMrb62S/4WdjQvscN/HpcIZKvBkp3lPYEvQ3o0M+XPFT1gzuVEtHuDhxZdtLX+6aVYOGGPs0GcPZMcvMxDkJx6IZ4fHcoCt5FuBW0rywCohwmmc2XA1W/I= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64a02aa6-a590-460a-96ac-08d649974998 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2018 18:39:04.1567 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4889 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 18:39:05 -0000 Hi Adrien,=20 Tuesday, November 13, 2018 7:15 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types >=20 > Again a bit late to the party, please see below. >=20 > On Sun, Nov 11, 2018 at 09:35:22AM +0000, Ori Kam wrote: [...] > > > The setfault is the result of commit a4391f8bae ("app/testpmd: set > > > default RSS key as null"). > > > Reverting this commit should fix the segfault but it also means > > > there is no way to set default key (key=3DNULL) with testpmd. > > > Need to check if this is only a testpmd limitation and not all > > > applications limitation. > > > > > > We should decide how an application can set default RSS without > > > knowing anything about keys. > > > > > > > I agree with Adrian that the main criteria should be the length. > > Maybe the set default RSS in testpmd should get new parameter. >=20 > Since [1] was reverted and we seem to agree that a zero key_len should > trigger a PMD-specific default key, this can already be requested with > testpmd by overriding key_len, e.g.: >=20 > flow create 1 pattern eth / end actions rss key_len 0 / end >=20 > Using an empty string as the key would yield the same result but cannot b= e > expressed on the command line yet. Note that specifying a key automatical= ly > overrides key_len, so key_len must be forced to 0 last to get PMD default= s: >=20 > flow create 1 pattern eth / end actions rss key foo key_len 0 / end I don't understand why we are backing up API claims with "how testpmd is im= plemented". The APIs should be correct, regardless of how testpmd is using = them.=20 To this doc issue,=20 I don't understand on what cases it makes sense for application to have rss= _key_len =3D 0 while rss_key !=3D NULL. This is obviously in-consist input,= and of course all PMD will just ignore the key. I think enforcing rss_key and rss_key_len to be NULL is a fair requirement = from application, and it makes no confusion in the API inputs. >=20 > Here key_len is set to testpmd's default size when parsing "rss", updated= to > 3 when parsing "key foo" and updated once again when parsing "key_len 0". >=20 > Lastly, while it would make sense for testpmd to use 0 as the default val= ue, > doing so yields inconsistent balancing results between vendors/devices as > they all come with a different key. Same reason as initializing the RSS t= ypes > field to the global rss_hf instead of 0. >=20 > [1] "app/testpmd: revert setting default RSS" >=20 > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fma > ils.dpdk.org%2Farchives%2Fdev%2F2018- > November%2F118786.html&data=3D02%7C01%7Cshahafs%40mellanox.co > m%7C0eecf3e9af4b4b6bc53108d6498ba2a8%7Ca652971c7d2e4d9ba6a4d1492 > 56f461b%7C0%7C0%7C636777261425388073&sdata=3DHu0iGr2xS%2FI%2FI > s5PtzCylMMft5w5TBmtd3GYppEKKcA%3D&reserved=3D0 >=20 > -- > Adrien Mazarguil > 6WIND