From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00056.outbound.protection.outlook.com [40.107.0.56]) by dpdk.org (Postfix) with ESMTP id BED1E1B11C for ; Wed, 14 Nov 2018 15:56:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2BeHvGMO3MJCUXmhYdAcQshIYII0h95F3iYaFRporL8=; b=KhM6rgKTrStkvdISXP9gE/vIix4U5VwuP3ajEPffNGAQYXKR2MxaNcx7aIMPDhj0lz8Xjn024khMRPl+H7Jr+iIEXdK1qjo/GDB1lBRhWG0onrudAC0uGjspENe2Kl/oUGWLMogB4cDo41TOL9hTC2ffVXT6jRR4BbHoaQN9RMk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5226.eurprd05.prod.outlook.com (20.178.42.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Wed, 14 Nov 2018 14:56:00 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f%2]) with mapi id 15.20.1294.044; Wed, 14 Nov 2018 14:56:00 +0000 From: Shahaf Shuler To: Shahaf Shuler , Slava Ovsiienko , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Thread-Index: AQHUfCoojWlLAPcZwEmxS4wpd+n4SQ== Date: Wed, 14 Nov 2018 14:56:00 +0000 Message-ID: References: <1541225876-8817-2-git-send-email-viacheslavo@mellanox.com> <1542052877-41512-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5226; 6:ikB5lxUY5tzObY7pSuM8e3mntha7+S3RDkQD+2PKcny/8+aTIOgeRS7+Goti6ztD2rOK/mGOUn8XwcygA38tKdJKdiB6fB5RZa04pJM4kHuvYjkshNy6PavilSD6PI0KlJdHrJrTVF1qfan9ptn7qksPQHf1MCa+tA+oDCMwgU11Be9ulBn+8P75i6lE/tRuOTk5j43bm89+ZKNMF3XP+7NdUalPsgGYktih1FHcKdzM8dNRzspuQb7MWuSA7C+X3fF5CsOPFY2XbQbdGzpgcwQtmD483SQsRTxfBrQCIp5Zvn/L8/Z2iEN9aagA/jAssqIH/U4wA7f8nYb2NvtAj2uzCtFFPUKwtIWELVg5SO/16XBDIXsaSWQwMp7IB7nJfE+pf5scZjpn99A6eJVmjlH6nnwUjxGbJOAZDf0HTm9y09bpaveHKT8nsFVqP21GMo/Un6WzoBCCB7XKKFQixQ==; 5:KbQGuM4gUPJM2vj1lGt1nJwt6HQ4m7YYtrbhsvJErN8LJpHj0cJPMIovljDbo8kMu5X3iZ2KltmzC2a4niVJlD6KtFpOlxd2iMou5WVvYadtY+Uhq0jAupx+rY9aoGXwp4FBaXHuz5umbeeq6M79q4uQ1FpkT18yJXWEjQGvjtI=; 7:y62rA4rZv2SBHXvBIGUdx9qvQf1yezPW8qY4tjuTbmpb9b6x1Zri4wW+3bKmaowBdJ3PnWqeRlx8Tact8tgmh6aaWiGnhb68tT0+jVt0tAJcYRFyPkuA9QPnT8smc3Q/zYbBPscS8Rf6RV0ZnmqsNA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1bd018c4-4b0e-4fc9-7027-08d64a414acc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5226; x-ms-traffictypediagnostic: DB7PR05MB5226: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231410)(944501410)(52105112)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB5226; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5226; x-forefront-prvs: 085634EFF4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(376002)(136003)(396003)(346002)(189003)(199004)(86362001)(478600001)(25786009)(2900100001)(446003)(186003)(66066001)(6116002)(3846002)(476003)(11346002)(26005)(486006)(97736004)(229853002)(110136005)(316002)(106356001)(105586002)(6506007)(14454004)(7696005)(5660300001)(53936002)(55016002)(6246003)(102836004)(9686003)(71190400001)(71200400001)(68736007)(4326008)(81156014)(7736002)(14444005)(99286004)(33656002)(256004)(305945005)(2906002)(6436002)(76176011)(81166006)(74316002)(8936002)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5226; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: OjJzjIpejYQh/A7TDwFV/8JypAz0Gafky4wlzqq7HdStk4MycNyPpkxLpYGS5P+VMEMpRRHc6fUc9/9UJxzfF+j922QDYmJ+wDJVtcfNpYvzAEsaDvYM/GX3KzwxphY3/sqUiNkhzxCVGw71V4E0TsvAdxzAo9zTwIR2+UexpUNjdUDdD8HJklBRJfDf5UZA+RjR1ZS3Vzb2P2nVuvLVg2Koybc6uZJN9FH4kbzzwqSNwXiqvGxLVJHFDIqQ+sSiIOXWcBu3lXJOGxnYYha6L/D1MqYYZ1gt/GhKTodu4UNLXnJh7z6wRIi352dBJ2YD3K2kHYY3KUOqVotcEDUxwQBTdcAPjf9ZYqVDPkk5ws8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bd018c4-4b0e-4fc9-7027-08d64a414acc X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2018 14:56:00.6339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5226 Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 14:56:02 -0000 Tuesday, November 13, 2018 3:21 PM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rul= e > flags check >=20 > Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > > Subject: [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags > > check > > > > The tc flower filter rules are used to control E-switch from the > > application side. In order to gain garanteed rule hardware offload the > > skip_sw flag should be specified while applying the rule. Some tc > > rules is rejected by kernel if skip_sw flag is set by design. > > Currently this regards VXLAN tunneling rules only, which are applied to > special VXLAN virtual devices. > > > > Albeit these rules should be applied with no skip_sw flag set the > > kernel tries to perform hardware offload. If kernel succeeded the > > in_hw flag is set in rule properties and application may check this > > flag to get know whether the applied rule is actually hardware offloade= d. > > > > Signed-off-by: Viacheslav Ovsiienko > > >=20 > Hi Slava, > In general looks good. Please see few comments. >=20 > In addition, please make the signed-of name and the author name match for > the next version. Series applied to next-net-mlx, with modification of the author name. Thank= s.