* [dpdk-dev] [PATCH] net/mlx5: fix existing file remove
@ 2018-03-16 10:27 Xueming Li
2018-03-16 10:57 ` Nélio Laranjeiro
2018-03-16 15:22 ` [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal Xueming Li
0 siblings, 2 replies; 5+ messages in thread
From: Xueming Li @ 2018-03-16 10:27 UTC (permalink / raw)
To: Nelio Laranjeiro, Adrien Mazarguil, Shahaf Shuler; +Cc: Xueming Li, dev
Remove file detection before removing existing file.
Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
drivers/net/mlx5/mlx5_socket.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c
index 61c1a4a..fb80fb3 100644
--- a/drivers/net/mlx5/mlx5_socket.c
+++ b/drivers/net/mlx5/mlx5_socket.c
@@ -32,7 +32,6 @@
};
int ret;
int flags;
- struct stat file_stat;
/*
* Initialise the socket to communicate with the secondary
@@ -52,9 +51,7 @@
goto out;
snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d",
MLX5_DRIVER_NAME, priv->primary_socket);
- ret = stat(sun.sun_path, &file_stat);
- if (!ret)
- claim_zero(remove(sun.sun_path));
+ remove(sun.sun_path);
ret = bind(priv->primary_socket, (const struct sockaddr *)&sun,
sizeof(sun));
if (ret < 0) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix existing file remove
2018-03-16 10:27 [dpdk-dev] [PATCH] net/mlx5: fix existing file remove Xueming Li
@ 2018-03-16 10:57 ` Nélio Laranjeiro
2018-03-16 15:22 ` [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal Xueming Li
1 sibling, 0 replies; 5+ messages in thread
From: Nélio Laranjeiro @ 2018-03-16 10:57 UTC (permalink / raw)
To: Xueming Li; +Cc: Adrien Mazarguil, Shahaf Shuler, dev
On Fri, Mar 16, 2018 at 06:27:48PM +0800, Xueming Li wrote:
> Remove file detection before removing existing file.
>
The explanation can induce some misunderstandings, the fact is there is
no guarantee that the file won't be removed by an external
user/application in between the stat() and remove() syscalls.
As it cannot be done atomically there is no need to need to make such
verification, remove() will fail if the file does not exists anymore.
> Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Unless the commit log which can explain why this move is made,
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_socket.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c
> index 61c1a4a..fb80fb3 100644
> --- a/drivers/net/mlx5/mlx5_socket.c
> +++ b/drivers/net/mlx5/mlx5_socket.c
> @@ -32,7 +32,6 @@
> };
> int ret;
> int flags;
> - struct stat file_stat;
>
> /*
> * Initialise the socket to communicate with the secondary
> @@ -52,9 +51,7 @@
> goto out;
> snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d",
> MLX5_DRIVER_NAME, priv->primary_socket);
> - ret = stat(sun.sun_path, &file_stat);
> - if (!ret)
> - claim_zero(remove(sun.sun_path));
> + remove(sun.sun_path);
> ret = bind(priv->primary_socket, (const struct sockaddr *)&sun,
> sizeof(sun));
> if (ret < 0) {
> --
> 1.8.3.1
>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal
2018-03-16 10:27 [dpdk-dev] [PATCH] net/mlx5: fix existing file remove Xueming Li
2018-03-16 10:57 ` Nélio Laranjeiro
@ 2018-03-16 15:22 ` Xueming Li
2018-03-16 15:37 ` Nélio Laranjeiro
1 sibling, 1 reply; 5+ messages in thread
From: Xueming Li @ 2018-03-16 15:22 UTC (permalink / raw)
To: Nelio Laranjeiro, Adrien Mazarguil, Shahaf Shuler; +Cc: Xueming Li, dev
There is no guarantee that the file won't be removed by external
user/application between the stat() and remove() syscalls, remove() will
fail if the file no longer exists.
Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
drivers/net/mlx5/mlx5_socket.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c
index 61c1a4a..fb80fb3 100644
--- a/drivers/net/mlx5/mlx5_socket.c
+++ b/drivers/net/mlx5/mlx5_socket.c
@@ -32,7 +32,6 @@
};
int ret;
int flags;
- struct stat file_stat;
/*
* Initialise the socket to communicate with the secondary
@@ -52,9 +51,7 @@
goto out;
snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d",
MLX5_DRIVER_NAME, priv->primary_socket);
- ret = stat(sun.sun_path, &file_stat);
- if (!ret)
- claim_zero(remove(sun.sun_path));
+ remove(sun.sun_path);
ret = bind(priv->primary_socket, (const struct sockaddr *)&sun,
sizeof(sun));
if (ret < 0) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal
2018-03-16 15:22 ` [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal Xueming Li
@ 2018-03-16 15:37 ` Nélio Laranjeiro
2018-03-19 9:13 ` Shahaf Shuler
0 siblings, 1 reply; 5+ messages in thread
From: Nélio Laranjeiro @ 2018-03-16 15:37 UTC (permalink / raw)
To: Xueming Li; +Cc: Adrien Mazarguil, Shahaf Shuler, dev
On Fri, Mar 16, 2018 at 11:22:27PM +0800, Xueming Li wrote:
> There is no guarantee that the file won't be removed by external
> user/application between the stat() and remove() syscalls, remove() will
> fail if the file no longer exists.
>
> Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_socket.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c
> index 61c1a4a..fb80fb3 100644
> --- a/drivers/net/mlx5/mlx5_socket.c
> +++ b/drivers/net/mlx5/mlx5_socket.c
> @@ -32,7 +32,6 @@
> };
> int ret;
> int flags;
> - struct stat file_stat;
>
> /*
> * Initialise the socket to communicate with the secondary
> @@ -52,9 +51,7 @@
> goto out;
> snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d",
> MLX5_DRIVER_NAME, priv->primary_socket);
> - ret = stat(sun.sun_path, &file_stat);
> - if (!ret)
> - claim_zero(remove(sun.sun_path));
> + remove(sun.sun_path);
> ret = bind(priv->primary_socket, (const struct sockaddr *)&sun,
> sizeof(sun));
> if (ret < 0) {
> --
> 1.8.3.1
>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal
2018-03-16 15:37 ` Nélio Laranjeiro
@ 2018-03-19 9:13 ` Shahaf Shuler
0 siblings, 0 replies; 5+ messages in thread
From: Shahaf Shuler @ 2018-03-19 9:13 UTC (permalink / raw)
To: Nélio Laranjeiro, Xueming(Steven) Li; +Cc: Adrien Mazarguil, dev
Friday, March 16, 2018 5:38 PM, Nélio Laranjeiro:
> On Fri, Mar 16, 2018 at 11:22:27PM +0800, Xueming Li wrote:
> > There is no guarantee that the file won't be removed by external
> > user/application between the stat() and remove() syscalls, remove()
> > will fail if the file no longer exists.
> >
> > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file
> > descriptor")
> >
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-19 9:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-16 10:27 [dpdk-dev] [PATCH] net/mlx5: fix existing file remove Xueming Li
2018-03-16 10:57 ` Nélio Laranjeiro
2018-03-16 15:22 ` [dpdk-dev] [PATCH v1] net/mlx5: fix existing file removal Xueming Li
2018-03-16 15:37 ` Nélio Laranjeiro
2018-03-19 9:13 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).