Re: [dpdk-dev] [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default

[Shahaf Shuler <shahafs@mellanox.com>]

Wednesday, August 15, 2018 8:12 PM, Yongseok Koh:
> Subject: Re: [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send
> by default
> 
> 
> > On Aug 15, 2018, at 5:17 AM, Shahaf Shuler <shahafs@mellanox.com>
> wrote:
> >
> > On ConnectX-4 Lx the Multi Packet Send (MPW) feature is considered
> > un-secure, as on some cases were the application provides incorrect
> > mbufs on the Tx burst the host or NIC can get stuck.
> >
> > Hence, disabling the feature by default for this specific NIC.
> > Users can still enable this feature and enjoy the performance gain
> > (mostly for low number of cores) by using the txq_mpw_en devarg.
> >
> > This patch will impact the out of the box performance of some
> > application using ConnectX-4 Lx for the sack of security and robustness.
> >
> > Since we need different defaults based on the underlying device the
> > mpw field in the configuration struct was extended to contain also the
> > MLX5_ARG_UNSET option.
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> 
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

> 
> Thanks