From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20086.outbound.protection.outlook.com [40.107.2.86]) by dpdk.org (Postfix) with ESMTP id 9CD3C1C01 for ; Mon, 23 Apr 2018 07:52:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IY37WK4BOTo57aNsdd7XKKmoz3d5tOXV5DS0ZT1bj2s=; b=WjZEZJiiCIQK3HrA2Ftucn2NaYcGAEF2KShR1kkitvjsY/o8uWCjqBSgP6wnww5Qv6yZs4UkdMhKherXjKmNqE4EOGMv4bcP+f7GRdE0nJw9lA9pfgDJBeEqztzVLQgE9W7pLGIis7ElOuBZz7eTKQMJbBlxoJztvr22EmHLDzk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4458.eurprd05.prod.outlook.com (52.134.109.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.12; Mon, 23 Apr 2018 05:52:08 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0696.017; Mon, 23 Apr 2018 05:52:08 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Yongseok Koh CC: Adrien Mazarguil Thread-Topic: [dpdk-dev] [PATCH v2 3/3] net/mlx5: implement multicast add list devop Thread-Index: AQHT1xwu2KYTLNN7ZU24WTooVmTu46QN32Jg Date: Mon, 23 Apr 2018 05:52:08 +0000 Message-ID: References: <870d4840cdb872d363d103808f82eb3645fd36b0.1524059312.git.nelio.laranjeiro@6wind.com> In-Reply-To: <870d4840cdb872d363d103808f82eb3645fd36b0.1524059312.git.nelio.laranjeiro@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4458; 7:V52j7RVkznS6C56yZ77HL0Zdb6FI6llOq3/IQbHlOGRtPrAby6humbeEUESIqzol0GVRYCxjsiBRG/5aaaIB1WE53h9qfYs4za9ODVNxxad88RtoWqNtpNRhXrW4vKluy9m6xiB6bP8hoRlA6bqhJ/rY4WJBWtCKmb3F+m4eMaV+WtePlNDycXNtuz2PLLdCMFHPqgdAWG1PZlwqf8hzvAj7Io5uVSTC1iZ3TDNqAT/dzT3y0wQSz0+sFLnCNcA7 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4458; x-ms-traffictypediagnostic: DB7PR05MB4458: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231232)(944501410)(52105095)(93006095)(93001095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4458; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4458; x-forefront-prvs: 06515DA04B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(366004)(376002)(396003)(346002)(102836004)(76176011)(3280700002)(229853002)(6246003)(53936002)(7696005)(6506007)(81166006)(86362001)(110136005)(66066001)(316002)(11346002)(8936002)(59450400001)(3660700001)(476003)(446003)(2906002)(2900100001)(305945005)(5660300001)(74316002)(478600001)(6636002)(33656002)(7736002)(186003)(25786009)(9686003)(4326008)(2501003)(6116002)(5250100002)(26005)(55016002)(6436002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4458; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: UVO/2NR+2OWknUEmia00Q0Q7637e4YGH/0TTwQlqSnJmYZ+pXMI2cdsJsx1Tq78/uofN3zOQH1dgQPP7W2NE6VuzIE05umLUq51W/hyf9P/FQlZjbT8TKAIMHpojeuov3m0CrAzCHJcPybCYr4YZYN0TuO8wPZmMQVgm/aqBier9nSBW0ZAc0iRboIcMTEOR spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 29f4aba7-d383-472f-98d4-08d5a8de59ba X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29f4aba7-d383-472f-98d4-08d5a8de59ba X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 05:52:08.2994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4458 Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/mlx5: implement multicast add list devop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 05:52:10 -0000 Hi Nelio, Small comments before I merge. Wednesday, April 18, 2018 4:50 PM, Nelio Laranjeiro: > Subject: [dpdk-dev] [PATCH v2 3/3] net/mlx5: implement multicast add list > devop >=20 > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5.c | 2 ++ > drivers/net/mlx5/mlx5.h | 2 ++ > drivers/net/mlx5/mlx5_defs.h | 5 ++++- drivers/net/mlx5/mlx5_mac.c | = 33 > +++++++++++++++++++++++++++++++++ > 4 files changed, 41 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 68783c3ac..887924d07 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -277,6 +277,7 @@ const struct eth_dev_ops mlx5_dev_ops =3D { > .mac_addr_remove =3D mlx5_mac_addr_remove, > .mac_addr_add =3D mlx5_mac_addr_add, > .mac_addr_set =3D mlx5_mac_addr_set, > + .set_mc_addr_list =3D mlx5_set_mc_addr_list, > .mtu_set =3D mlx5_dev_set_mtu, > .vlan_strip_queue_set =3D mlx5_vlan_strip_queue_set, > .vlan_offload_set =3D mlx5_vlan_offload_set, @@ -329,6 +330,7 @@ > const struct eth_dev_ops mlx5_dev_ops_isolate =3D { > .mac_addr_remove =3D mlx5_mac_addr_remove, > .mac_addr_add =3D mlx5_mac_addr_add, > .mac_addr_set =3D mlx5_mac_addr_set, > + .set_mc_addr_list =3D mlx5_set_mc_addr_list, > .mtu_set =3D mlx5_dev_set_mtu, > .vlan_strip_queue_set =3D mlx5_vlan_strip_queue_set, > .vlan_offload_set =3D mlx5_vlan_offload_set, diff --git > a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > 6ad41390a..64f025d22 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -203,6 +203,8 @@ void mlx5_mac_addr_remove(struct rte_eth_dev > *dev, uint32_t index); int mlx5_mac_addr_add(struct rte_eth_dev *dev, > struct ether_addr *mac, > uint32_t index, uint32_t vmdq); int > mlx5_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr > *mac_addr); > +int mlx5_set_mc_addr_list(struct rte_eth_dev *dev, > + struct ether_addr *mc_addr_set, uint32_t > nb_mc_addr); >=20 > /* mlx5_rss.c */ >=20 > diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h > index e3aa03bef..5973742a7 100644 > --- a/drivers/net/mlx5/mlx5_defs.h > +++ b/drivers/net/mlx5/mlx5_defs.h > @@ -15,8 +15,11 @@ >=20 > /* Maximum number of simultaneous unicast MAC addresses. */ #define > MLX5_MAX_UC_MAC_ADDRESSES 128 > +/* Maximum number of simultaneous Multicast MAC addresses. */ #define > +MLX5_MAX_MC_MAC_ADDRESSES 128 > /* Maximum number of simultaneous MAC addresses. */ -#define > MLX5_MAX_MAC_ADDRESSES MLX5_MAX_UC_MAC_ADDRESSES > +#define MLX5_MAX_MAC_ADDRESSES \ > + (MLX5_MAX_UC_MAC_ADDRESSES + > MLX5_MAX_MC_MAC_ADDRESSES) >=20 > /* Maximum number of simultaneous VLAN filters. */ #define > MLX5_MAX_VLAN_IDS 128 diff --git a/drivers/net/mlx5/mlx5_mac.c > b/drivers/net/mlx5/mlx5_mac.c index e9334ea4a..32560d55e 100644 > --- a/drivers/net/mlx5/mlx5_mac.c > +++ b/drivers/net/mlx5/mlx5_mac.c > @@ -201,3 +201,36 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct > ether_addr *mac_addr) > dev->data->port_id); > return mlx5_mac_addr_add(dev, mac_addr, 0, 0); } > + > +/** > + * DPDK callback to set multicast addresses list. > + * > + * @param dev > + * Pointer to Ethernet device structure. > + * @param mac_addr_set > + * Multicast MAC address pointer array. > + * @param nb_mac_addr > + * Number of entries in the array. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set= . > + */ > +int > +mlx5_set_mc_addr_list(struct rte_eth_dev *dev, > + struct ether_addr *mc_addr_set, uint32_t nb_mc_addr) { > + uint32_t i; > + int ret; > + We should check nb_mc_addr < MLX5_MAX_MC_MAC_ADDRESSES before we start oper= ate.=20 > + for (i =3D MLX5_MAX_UC_MAC_ADDRESSES; i !=3D > MLX5_MAX_MAC_ADDRESSES; ++i) > + mlx5_internal_mac_addr_remove(dev, i); > + i =3D MLX5_MAX_UC_MAC_ADDRESSES; > + while (nb_mc_addr--) { Maybe worth checking is_multicast_ether_addr(mc_addr_set) and to skip + war= n if it is not.=20 > + ret =3D mlx5_internal_mac_addr_add(dev, mc_addr_set++, > i++); > + if (ret) > + return ret; > + } > + if (!dev->data->promiscuous) > + return mlx5_traffic_restart(dev); > + return 0; > +} > -- > 2.17.0