From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shahafs@mellanox.com> Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0045.outbound.protection.outlook.com [104.47.2.45]) by dpdk.org (Postfix) with ESMTP id 12D882C56 for <dev@dpdk.org>; Sun, 27 May 2018 06:36:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IHioO9dyyMtKGWD5l/Q4b/slvxsqiafViqiGT2JeL+s=; b=JrFy7fFdN2HX+ZFA7LEd2ytaGhN3iygpjtktptcs5BuiZ0OcCRBjC8k8MKp6715u0ynwm8b512eC+z2mEt7UniAtEujHz535y0p3rsqsKfiLiqWF7UZnkxdscFlNzf40OmAdiZ/MIneB4qpWTB/6+eUrsxX5REyMDupcaaLAV9A= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5017.eurprd05.prod.outlook.com (20.176.236.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.797.11; Sun, 27 May 2018 04:36:41 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::e57e:5e77:595f:d4f7]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::e57e:5e77:595f:d4f7%13]) with mapi id 15.20.0797.011; Sun, 27 May 2018 04:36:41 +0000 From: Shahaf Shuler <shahafs@mellanox.com> To: Yongseok Koh <yskoh@mellanox.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "stephen@networkplumber.org" <stephen@networkplumber.org>, Yongseok Koh <yskoh@mellanox.com> Thread-Topic: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro Thread-Index: AQHT88aWGHoTP+w8tEqk5mhFh65yQqRDAPFw Date: Sun, 27 May 2018 04:36:41 +0000 Message-ID: <DB7PR05MB4426C901EE88F7B71FBB225EC36F0@DB7PR05MB4426.eurprd05.prod.outlook.com> References: <20180525005338.28773-1-yskoh@mellanox.com> <20180525012006.29856-1-yskoh@mellanox.com> In-Reply-To: <20180525012006.29856-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5017; 7:95+PIt0z7hv1n8FQZgEJbBQPxpgzkXnEFmzT74BBP75SfrttXuP1hkQ76Sojw7IIPM2ATz4nIG2DV3IzJrJWIfChMGIkJ1/I1tA4QKEfjGLQasZnnxPy4bDR79AhmPrbF3kOdfT9Mpq0DqULUrkQkVK51zXCZKkLq0H2Z7ygzEstBHoz6MLU5vSggWNzWhSuMupjAf5icao6i0kz/RzLLs3MXDMqRBOQLpIhRPmikTMiBbuqKVP+wRPxI+2wVmI0 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5017; x-ms-traffictypediagnostic: DB7PR05MB5017: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <DB7PR05MB501774346F4DB82C33AB80FDC36F0@DB7PR05MB5017.eurprd05.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB5017; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5017; x-forefront-prvs: 0685122203 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(39380400002)(366004)(396003)(189003)(199004)(446003)(76176011)(486006)(14454004)(476003)(6506007)(105586002)(102836004)(45080400002)(5660300001)(11346002)(26005)(6116002)(7696005)(3846002)(97736004)(59450400001)(86362001)(316002)(99286004)(3660700001)(2906002)(8936002)(3280700002)(2900100001)(110136005)(229853002)(54906003)(66066001)(68736007)(33656002)(966005)(6436002)(53936002)(5890100001)(2501003)(478600001)(6246003)(4326008)(107886003)(74316002)(25786009)(106356001)(305945005)(55016002)(9686003)(81166006)(6306002)(81156014)(7736002)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5017; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: zsTfiIAAdjK+O/TBlhvFpeTa9VDJItrrF+K5HLT+jYxFkaudCYoDUvM0/zr3Pyh6VXo2SYopTvldvdnW//VcQQx6hoLdAjuaIxmOM6E/QXl17NXzjcVyZjtxfsGw+c8qNtk+b7W0laUaEVbSB9GOCukDqYRxYBqBfqdMAvBejWoKK/vVMfEvefO2QjYrBTBy spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 3ccc1519-2a0b-43c0-3460-08d5c38b71c8 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ccc1519-2a0b-43c0-3460-08d5c38b71c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2018 04:36:41.8359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5017 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 27 May 2018 04:36:53 -0000 Friday, May 25, 2018 4:20 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf > check macro >=20 > Link: > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2018- > April%2F099476.html&data=3D02%7C01%7Cshahafs%40mellanox.com%7Ccaccc > ead653640735e3308d5c1ddb6b0%7Ca652971c7d2e4d9ba6a4d149256f461b%7 > C0%7C0%7C636628080378790994&sdata=3D7JOFTPtuU4OYWowtwEKp3BaK5aS > 8idulFiGhLEHRIkU%3D&reserved=3D0 >=20 > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> > --- >=20 > v2: > * modify removal deadline and add more comments in the deprecation note > * mark deprecation on the comment of the macro in rte_mbuf.h >=20 > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > lib/librte_mbuf/rte_mbuf.h | 3 ++- > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 1e2443c76..e1630c2cf 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -42,6 +42,13 @@ Deprecation Notices > is defined in librte_sched in a non-generic way. The new generic forma= t > will contain: queue ID, traffic class, color. Field size will not chan= ge. >=20 > +* mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or > +later and > + replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05. > +As > + ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05, > +``RTE_MBUF_INDIRECT()`` > + can no longer be mutually exclusive with ``RTE_MBUF_DIRECT()`` if the > +new > + experimental API ``rte_pktmbuf_attach_extbuf()`` is used. Removal of > +the macro > + is to fix this semantic inconsistency. > + > * ethdev: a new Tx and Rx offload API was introduced on 17.11. > In the new API, offloads are divided into per-port and per-queue offlo= ads. > Offloads are disabled by default and enabled per application request. > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h inde= x > e136d12b7..8e6b4d292 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -738,7 +738,8 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > #define RTE_MBUF_CLONED(mb) ((mb)->ol_flags & > IND_ATTACHED_MBUF) >=20 > /** > - * Returns TRUE if given mbuf is indirect, or FALSE otherwise. > + * Deprecated. > + * Use RTE_MBUF_CLONED(). > */ > #define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) Acked-by: Shahaf Shuler <shahafs@mellanox.com> >=20 > -- > 2.11.0