Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix RSS flow action hash type selection

[Shahaf Shuler <shahafs@mellanox.com>]

Tuesday, August 14, 2018 2:17 PM, Shahaf Shuler:
> Subject: [dpdk-stable] [PATCH v2] net/mlx5: fix RSS flow action hash type
> selection
> 
> On the code after the below commits, the criteria to select the IPV4 or
> IPV6 hash functions was the existence of some ETH_RSS_IPV4 RSS types on
> the flow rule.
> 
> The check is wrong. For example ETH_RSS_NONFRAG_IPV4_TCP will not
> select the IPV4 hash which will cause the packet to be spread in a bad way.
> 
> Fix it by adding the corresponding types needed for each hash selection.
> 
> Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action")
> Fixes: fd0b70316bca ("net/mlx5: support inner RSS computation")
> Cc: stable@dpdk.org
> Cc: nelio.laranjeiro@6wind.com
> Cc: orika@mellanox.com
> 
> Reported-by: Yaroslav Brustinov <ybrustin@cisco.com>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> 
> Few notes:
> 1. this patch should be backported to 18.08 stable 2. There is more work
> planned in 18.11 for the flow engine.
>    The work should be on top of this fix.
> 
> On v2:
>  * Removed duplicated ETH_RSS_NONFRAG_IPV6_OTHER flag.
>  * Ordered the flags according to their aprearance in rte_ethdev.h
> 
> ---

Applied to next-net-mlx, thanks.