From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF498A00BE; Tue, 7 Jul 2020 10:04:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A57B1D5ED; Tue, 7 Jul 2020 10:04:05 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78]) by dpdk.org (Postfix) with ESMTP id 8B9EC1D5E6 for ; Tue, 7 Jul 2020 10:04:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JeZibxlK6Tp/s1PfY+7DoZDKRuSIfc4S5IqVk+vAaPKwuzxIF59Mu9d8jzmozJNhvyi3AaU3ohs9XsTLKeGg5oXQcjmxOZHSFqJMeBxUPrm5jeZfX6H7dk/ANpzB1u8q4cLJcU9G7QfHpxUECxsUY5K/x54hDUGHtmW5MSiSxqYAkRrq8ycIllQdwkphxw8Co928nIGzi1F9TgH+M2hF/XbNhh1VZyD4A5dUV8Y49b8rzH4xMKHhRTiM3xcjR9lfUNgpa5B8bAXloo9zmAoav6LT+LfisGKvB9a6ajQqUyp/l75uxbq0kCBsXKewgjJEZfgXl7ehtXegRNhbiX8Epg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JbaNYYVxOXtv1zfs8yiA5ECEZFUHCTwslr72na52DI=; b=mObn0DP1O5pa+YAzo9Vid6QKoEA1B5LybVYnINcvyC3EXXpnv9zAVSKivl0KE0B8lzxdOQoNvQDWYRuaixX8l7SBylgd21B/YzPSGyC6YL4wGmHZsf+DVmvmeMMggNO8+0I7VP/fmwfj2yZDetTqQlfEXVyfJspJGo7wOOdHwedpJQ2M0f/vq3MzvhP+h+hKxUCXjBazdLvFNlSMVo/AMGwYMjFzL3OjATT+Np/HAcxUJDBRDcmxRyRCVdVUlWdjj3uaesobNa5yUSxeKzXbtrg8LyX2cg3L3RRxJJQJ5AbHBqRtrj/kICyiap58buQ+qE4Deuk4dDUZyQWP4ljbuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JbaNYYVxOXtv1zfs8yiA5ECEZFUHCTwslr72na52DI=; b=KCSuZ1SVO/nafIa+HsKqvDSDvrHs169t3gpSuaUPIN5JtEzO/9JiXXpbIMGP4qVqPegwXlTFS7dTeVVAWJjJVWCiJxKKEGKWVBf4XTgi21s7+GT2Z6qe7W97WR8XYhRT6FJ/lhRgL41ERrt2wQ2bAQH2uLoMwopWFjNHJ1rzugU= Received: from DB7PR05MB5324.eurprd05.prod.outlook.com (2603:10a6:10:69::12) by DB7PR05MB5817.eurprd05.prod.outlook.com (2603:10a6:10:8d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Tue, 7 Jul 2020 08:04:00 +0000 Received: from DB7PR05MB5324.eurprd05.prod.outlook.com ([fe80::dd3c:2995:30e9:fb04]) by DB7PR05MB5324.eurprd05.prod.outlook.com ([fe80::dd3c:2995:30e9:fb04%6]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 08:04:00 +0000 From: Tal Shnaiderman To: Narcisa Ana Maria Vasile , "dmitry.kozliuk@gmail.com" CC: "dev@dpdk.org" , Thomas Monjalon , "pallavi.kadam@intel.com" , "david.marchand@redhat.com" , "grive@u256.net" , "ranjit.menon@intel.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anatoly.burakov@intel.com" Thread-Topic: [PATCH 1/2] eal/windows: Add needed calls to detect vdev PMD Thread-Index: AQHWSjfkDxXGPMAqyku7SIrgTl6qWqj7Ws6AgABoeAA= Date: Tue, 7 Jul 2020 08:04:00 +0000 Message-ID: References: <20200624145621.26604-1-talshn@mellanox.com> <20200624145621.26604-2-talshn@mellanox.com> <20200707004325.GA71561@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20200707004325.GA71561@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [37.142.1.17] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 888c8fc5-6f94-433f-34cd-08d8224c4ec6 x-ms-traffictypediagnostic: DB7PR05MB5817: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0457F11EAF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FgV8zJbi3BkSdbU/zRXFlKBsEMF7nV7hQyT9DbLCVWf3pjNNEmFCM/ldyw7to7BWQE93qqhTl1X10zXdsemTLOO3eKVqJ9t3l1mAp3/TsBfNRCYgbqjre58zFCpNOP2gGrFG5kQAM439JKF7e4l3l2wpZnlO6QffVs4tApUqVVBO+zVDLGHY+LfYpEZVTlU8mFZs94c9tXaT3oSXBw7+ifBFC07GeW0AQyvuih11L4DOgMBu63qoMWvnGPgIXYs+yOMJQkqB0JtSjuqHoSdAIh2RuUIIELmde8KRoLwNmGyvKDkoDkbLwrvy8SdB2UNpzY7w1A8EQ12LXXY3Y9c2kvihj3ZJGeamD0AcJxOUza4O9ZV6jBim9Ves2bfMwcOvftMNIPdK24A5B+nBSD11eA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR05MB5324.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(376002)(366004)(346002)(136003)(186003)(8936002)(478600001)(52230400001)(66446008)(64756008)(66556008)(66476007)(45080400002)(66946007)(110136005)(54906003)(5660300002)(76116006)(83380400001)(316002)(6506007)(52536014)(4326008)(71200400001)(9686003)(7416002)(55016002)(33656002)(26005)(966005)(2906002)(8676002)(7696005)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Ghk7ZJjaHShk459SoJ77iqkhmmGsX/PE5+iH5Mud1O+ArTnciuDfXv85U2xlY0cJEQFDungiB4WuVYFDVQpp8Hv8EakZtQafEThcMm/nJtPaMDD/EXsiX90S3q3ypBB8PX/02Ki/Lo8vAvRCEncd7HHBjpb3L2xFxQTrleT15Yg/MoSwowbjtXH1SFvTGhCcJIOuHGcI8gGIAJxlfGrse+syoGeZERDRjPNxodkHXpW5PPBLA2VflN/1h5Hfk2wtTtQPMMzWJGXlJz/TlLt0o64Gh7o1vpRKhVYc+BDRL814KE2RaNsjFMvT+yP6ht9GYsUESSBgUMj7ZXecOOHXDclLCCSkwX4Q34K3F1ucEB0mBwpshFVC1GaFujHH4TaUSF7MEiPtlc0KIXaFW0Lfcw2FQEsYvZA0v6hLIl/2ha9Nj90gNj21hbky028V7ogLv91hZo8UGrGx1Qjd5oPmQ4BDKRVNrCbSv5qjw3KVGgA= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB7PR05MB5324.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 888c8fc5-6f94-433f-34cd-08d8224c4ec6 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 08:04:00.6007 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7u1rDcY+QoVBKEz9pS32pWfae9b9nnId3uVCdaoZ11J6PQfuCiLxnrFhlQBTU8m/tO51hHV5orQotOaI6fWfGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5817 Subject: Re: [dpdk-dev] [PATCH 1/2] eal/windows: Add needed calls to detect vdev PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thank you for the comments, you're right, either master has changed since I= sent those patches or I missed out on some exports/includes, anyhow I'll f= ix and resend v2. The rte_panic you're seeing is unrelated to the new code (BTW, you should b= uild a debug version if you want to see rte_panic's backtrace), it is a res= ult of your setup not being configured with the memory management requireme= nt of "Lock pages" (see [1]). Dmitry, It looks like we got to this stage since hugepage_claim_privilege()= cannot actually detect that "Lock pages" isn't granted to the current user= , as a result we fail on the first usage of a memory management call [in th= is case rte_calloc()] without indication to the reason. Is it possible to add an actual check that the current user is in the list = of grantees? Alternatively, It would be great to have this privilege added programmatica= lly, I tried the MSDN example in [2] but it didn't work for me while testin= g, maybe Microsoft team can check if there is a way to do it? [1] https://doc.dpdk.org/guides/windows_gsg/run_apps.html [2] https://docs.microsoft.com/en-us/windows/win32/memory/creating-a-file-m= apping-using-large-pages?redirectedfrom=3DMSDN > -----Original Message----- > From: Narcisa Ana Maria Vasile > Subject: Re: [PATCH 1/2] eal/windows: Add needed calls to detect vdev PMD >=20 > On Wed, Jun 24, 2020 at 05:56:20PM +0300, talshn@mellanox.com wrote: > > From: Tal Shnaiderman > > > > Add needed function calls in rte_eal_init to detect vdev PMD. > > > > eal_option_device_parse() > > rte_service_init() > > rte_bus_probe() > > > > Signed-off-by: Tal Shnaiderman > > --- > > lib/librte_eal/common/meson.build | 1 + > > lib/librte_eal/windows/eal.c | 19 +++++++++++++++++++ > > 2 files changed, 20 insertions(+) > > > > diff --git a/lib/librte_eal/common/meson.build > > b/lib/librte_eal/common/meson.build >=20 > Implicit declaration warning: > ../lib/librte_eal/windows/eal.c:371:6: warning: implicit declaration of f= unction > 'rte_service_init' is invalid in C99 [-Wimplicit-function-declaration] > if (rte_service_init()) { > ^ > 1 warning generated. >=20 > Adding "#include " in windows/eal.c should > solve it. >=20 > Getting some linker error: > Creating library drivers\librte_bus_vdev.dll.a and object > drivers\librte_bus_vdev.dll.exp bus_vdev_vdev.c.obj : error LNK2019: > unresolved external symbol rte_log_register_type_and_pick_level > referenced in function __vdev_logtype_bus drivers\librte_bus_vdev- > 0.200.3.dll : fatal error LNK1120: 1 unresolved externals >=20 > Probably just a missing export for "rte_log_register_type_and_pick_level"= in > rte_eal_exports.def? >=20 > After adding the missing include and export, compilation and linking are > successful. > I see some errors when running the app though: >=20 > EAL: error allocating rte services array > EAL: FATAL: rte_service_init() failed > EAL: rte_service_init() failed > PANIC in main(): > Cannot init EAL > 6: [ (RtlUserThreadStart+0x21)[0x7FFACF283460]] > 5: [ (BaseThreadInitThunk+0x14)[0x7FFACE7A6DF0]] > 4: [] > 3: [] > 2: [] > 1: []