From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29E35A04AF; Sun, 3 May 2020 13:53:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFDA71D53C; Sun, 3 May 2020 13:53:23 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by dpdk.org (Postfix) with ESMTP id A5B371D531 for ; Sun, 3 May 2020 13:53:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7Xkqo1Ry7+f5b+3DvOEXmP6NS8Vr7xqBHcZyXAddZQWOdQuovy6aUpgHMYQSGeTjzFiEDHBfXoH1MBUDzhd+k31cnx447bMm4/XgIarRKk4o7BgOWW6hL8kpwSqvOP0iCDFTajrenR2rQ4BTqdFNPVHrGzBd4sK8ZLObf9Lp11d6clHC/q2wmre6ham8PIuJ/T59/d8Dt1ysyFFATYAFFa5D+JnBhQ/jnA/sr9RwELDjwR48Yd3C+x7XMMhwc7bdnWCSSVUr0XQC9s1bz/IImDziTNe4QP9Wl6H//bBbsphBRjyehYwwK45U7jWW1F1CYvbHiGVKxh6WF4XveF6yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7RpXIio9sQSCD8stbGkcoy1GrMad6VjoPmWhgyqJ+k=; b=EKb1Le9LfbMRl/2YQRqE4QfGQDJ2qz5ngtNOOcllAD+aQv9u7A3b2G1Xxmxgcf5H8RHDwRXYWL6HHCVbamd8E0gBXbWSN3w3PNzvKPMGTllBD5q6lHWGJregul5/hZK0R//np8ENcGKKjmhZUQ5vRN3xWGJ9E8JOOHaBMlyECjSSf+AlPUwU/14U1TotSUW6yAArdsKnuwcDuYhGWjkg0NdizKOB6d0WtjV0dfHrATJePnPvevMkHoRk/GJJFvBPF45+9tBd5GH+jYSjf4a9UOp6X/llM1D5Ng2UmbS/ieBAsMoFj871enDzfraOWR4wxZRjZrw+hSycSM3vFVvjIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7RpXIio9sQSCD8stbGkcoy1GrMad6VjoPmWhgyqJ+k=; b=A3cN2O0PBJvCUnKEnr9/uqtOrosl0jzShUkjvmux2enZDX1zSz1r1b6gL0iF714Ai96jFOLtslkP4ER8F+x1OpxoOpXs5m9i/RNZkzh9SD6HUI567AJdolbF/1wGDVFeGUBqdfl+/RGU2QqWaxHH5xJ597rEbgtcyTmfWL3WJeI= Received: from DB7PR05MB5324.eurprd05.prod.outlook.com (2603:10a6:10:69::12) by DB7PR05MB5770.eurprd05.prod.outlook.com (2603:10a6:10:87::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Sun, 3 May 2020 11:53:20 +0000 Received: from DB7PR05MB5324.eurprd05.prod.outlook.com ([fe80::31c9:5bf4:d399:abe6]) by DB7PR05MB5324.eurprd05.prod.outlook.com ([fe80::31c9:5bf4:d399:abe6%7]) with mapi id 15.20.2958.029; Sun, 3 May 2020 11:53:20 +0000 From: Tal Shnaiderman To: Dmitry Kozlyuk CC: "dev@dpdk.org" , Thomas Monjalon , "pallavi.kadam@intel.com" , "david.marchand@redhat.com" , "grive@u256.net" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" Thread-Topic: [PATCH v2 7/7] bus/pci: support Windows with bifurcated drivers Thread-Index: AQHWHT19lzRhmm0SBkSRQFi5NBITxqiPOEoAgAcJKxA= Date: Sun, 3 May 2020 11:53:20 +0000 Message-ID: References: <20200428091111.13416-1-talshn@mellanox.com> <20200428091111.13416-8-talshn@mellanox.com> <20200429030152.0ebaae32@Sovereign> In-Reply-To: <20200429030152.0ebaae32@Sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [37.142.1.17] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8682e1ae-aac2-4ba5-b6b7-08d7ef589373 x-ms-traffictypediagnostic: DB7PR05MB5770: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0392679D18 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IBtOugOZEHcyB2ldQpXJYxjPEJm7T5ST72UApdjqthk2dlPrLl8R3yJogFgczHBvPwoU3ZMiBbJK756vdO8kzL1/YMpY1CVN3MI6NPElJzteI/rsEvRnjkhNjyzwV+ALrSBt+9FQ0kN4ZbwaHvR/4pVBaPTQmu7yoRUYZqXkMcAOI3FYY95klDXAbq3Li6cwjuJKGycIWekg5XbbFOFnziYzSmc2LVnhqZ83k0QAUwA0CLSQoQ6J9RSCZsxeXjJ5jnKESbDot+iGPOoYqSTVjVKuq2ewFGnANngQfbRaGLndSi75kudYxqShG6WGzZpNiOdLKsIBPIM+r0igWYOxp1Dup2SUBSeGtIJq2doYBAb9jOIlJpFr5lYsUPLWoX6vjv/HO6yG6qCBEyKbxBdtArFnnkk35YKLpJxmP410bsA3yyNbBSdnHsnPGi5HJO49 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR05MB5324.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(2906002)(186003)(86362001)(478600001)(6506007)(53546011)(5660300002)(8676002)(55016002)(8936002)(33656002)(7696005)(4744005)(26005)(71200400001)(4326008)(66556008)(64756008)(66446008)(66476007)(66946007)(52536014)(54906003)(316002)(9686003)(6916009)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RfMHDbSrF8zuSdf5RnxruVAd0q3+b7yF57vcXDVFqQnL2E1exQvw/zw5PvPPSNVx9r+F19O+IH7GNMtVt2Tjpztd7HRv45+NPMJILxik0y+hfITvA5uXosYsW1h4/Bvw6K7Kr4+GB10xg4hQjZphD/TWK3JjU97t9FC1ZHtwV6Sh1DRu0mCD0jH9nbyGJIR4U7CCV5GFpHBBaT0aJfnq+C0pRA3YjmjeJ8L9AePPwv+7knssLR7wID77Xj4Eotz41DtVr/xGuSYm9zV47oVNGE4TCn37etzayzslhiV0BfimWfYy8/onNNdL8tvCI8hqI+tfzRYBVbRx3715Odh0uwhyvhAdKETk3p8rNFTnOoz5UFZ27pq1McbWHKi5mayZE+unDcGOshq58h9jD7Wys2RQRziL7QXrtpon7cdLkxF15Y6YjavKerjoi2PTcTijyelQ0sTFtr7Id4XzuKW347UqPQhdcxf73XgU5up2WJkH2oUrevjfx/zgSjzMppoCj/HfvPNBfebM1llMpm+P1GAsjWPFgs/ENRHl3knw464sKHLqOmpFqUOkpUfzsntoiQvYhXboj9568nayyuCCS2527VYxj5GEv1Sy7KBHq7OUqSa2SBYRL022V8ugIL4myDI9lU9pNhPnoGI4KHYP6MI1bIsWYyDcSre0hKktFJfBFVlBhBxvk9dZ+KVjAX/zQuWhR2KiLFErxvsxg4YnbxcDtE+Zndbw+1pjXNPjGHfy3N/YOwzqrpcAMBWDtoOM9TZJIoTckjx9snicl5vTHMvPSnQcpzG+G3UwYzSsXbM= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8682e1ae-aac2-4ba5-b6b7-08d7ef589373 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2020 11:53:20.3470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FhNQtfCgLpZBAIIWKh1o41llUn+xtvqOR09viENpNsgrVMgCofFc6gmbvi1lwC4ppdjn3bx1j4+aqIjXG+hIuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5770 Subject: Re: [dpdk-dev] [PATCH v2 7/7] bus/pci: support Windows with bifurcated drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [PATCH v2 7/7] bus/pci: support Windows with bifurcated > drivers >=20 > On 2020-04-28 12:11 GMT+0300 talshn@mellanox.com wrote: > [snip] > > + switch (dev->kdrv) { > > + case RTE_KDRV_NONE: > > + /* Get NUMA node using DEVPKEY_Device_Numa_Node */ > > + bResult =3D SetupDiGetDevicePropertyW(hDevInfo, > pDeviceInfoData, > > + &DEVPKEY_Device_Numa_Node, &uPropertyType, > > + (BYTE *)&uNumaNode, sizeof(uNumaNode), NULL, > 0); > > + if (!bResult) { > > + ret =3D GetLastError(); > > + goto end; > > + } > > + dev->device.numa_node =3D uNumaNode; >=20 > Note: NUMA node !=3D socket ID, but this field is used as socket ID by PM= Ds. > I suggest adding Windows-only EAL API to do the translation. Thank you for the review and notes Dmitry, will apply in v3. Regarding numa node and socket id, AFAIK in x86 processors numa node =3D=3D= socket id In other processors that is not the case but of the current Windows support= of DPDK the Implementation above should be sufficient. > [snip]