From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Gavin.Hu@arm.com>
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50087.outbound.protection.outlook.com [40.107.5.87])
 by dpdk.org (Postfix) with ESMTP id 467672BA3
 for <dev@dpdk.org>; Thu, 17 Jan 2019 09:49:05 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector1-arm-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9doOUfa8EbERT9M1SFoZy3UWzy010A6yZYu4LJT1Lao=;
 b=jDTB1m+Zf1Cp7MKwOfYYmeSsEBjWL68LAKozOAe02crIWZT7oRcdIU723rlqJUrLnoZj0+xIGsB+Q3X9BYhlSOFt1+rrZo0remhJ+9bk93Boeh5mZMnzIo3GANjxYFgnp+/czjfQ8zo4uKiG52n8tPUc3HieZqXrXqioXcots2E=
Received: from DB7PR08MB3163.eurprd08.prod.outlook.com (52.134.110.149) by
 DB7PR08MB3228.eurprd08.prod.outlook.com (52.134.111.14) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1516.19; Thu, 17 Jan 2019 08:49:04 +0000
Received: from DB7PR08MB3163.eurprd08.prod.outlook.com
 ([fe80::d119:44d1:4793:5724]) by DB7PR08MB3163.eurprd08.prod.outlook.com
 ([fe80::d119:44d1:4793:5724%5]) with mapi id 15.20.1516.019; Thu, 17 Jan 2019
 08:49:04 +0000
From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
To: Gage Eads <gage.eads@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, Honnappa
 Nagarahalli <Honnappa.Nagarahalli@arm.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/2] eal: add 128-bit cmpset (x86-64 only)
Thread-Index: AQHUrSJoKFD1BchWBki9OtDxKYLlAqWzIv3Q
Date: Thu, 17 Jan 2019 08:49:03 +0000
Message-ID: <DB7PR08MB31638829AF1C054864DD169A8F830@DB7PR08MB3163.eurprd08.prod.outlook.com>
References: <20190110205538.24435-1-gage.eads@intel.com>
 <20190115223232.31866-1-gage.eads@intel.com>
 <20190115223232.31866-2-gage.eads@intel.com>
In-Reply-To: <20190115223232.31866-2-gage.eads@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Gavin.Hu@arm.com; 
x-originating-ip: [113.29.88.7]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB7PR08MB3228;
 6:PfzYv3haKPCnNmZLD1J6jyjf1TROt74So7Nm3H+GZVgAy2C99uFROp9dQWpBvS6nOD8x53AjT82pByTizT5MyTmEanj0U3nSZfKUA/OOSQ2OswofFZ7sdcskc89/WK7bZy2JLAZzjKTMbUnrnCv62BaboRKjHGTIjJ2k02HQ0WWL6QMqherrfHX962fNUaA1JoDcQWUP64v/l5+nAKrsRdvklmGqPIKfClCtaZ6WSoiI59jAqwv3PimaTIie3RJx/+UvhFbovkkOsJuHDDxnub1JdN3sT7p05k5RuOuWfa6yiT3uBf91RFgIPo/gqY1Cbbky5Ul7Rw+XzgISmS4JcAOX3PNIidyelxOkIVch9MzGjZMll9usJyLCxo528qnchQfAgKZckC0uleNdu8tgeK3x8Mj4xgHD3sa4LLJU1Qr5Cig0ksWOszfMpJvpPeGLVreFD6/+dRnk094ATBwQwQ==;
 5:fQ7+KmfvrM8nU+KJoIqnmRcPxOh+6Q8rE4T987SzyI59sMzJEPpVztAutrFsQHWpt666cHvrX2jd5+Pvbi/3UfUBUTZY057nI0sLca8ahVEA1yV+5Cl3JUApm6RQxyGSpikGwOYPOyCzjLyOQvLEye0lTdf9Vb7cQQT+KAIvrj4FZmxWFkEOz2cxfQNyqM8DVPfLv5BlKUPI3nH4ygMEUA==;
 7:amAFbop3xp10yRvekSbMKePYP1H/SrQ/EZ2dErrp0o8hFOhrmTcaGqlGm6fK5YizQ4KNTXgSSLhx5legOyFxt5X9dV9Uo++n1v2wnP43f/CoA8AgUEaslBpVA1JrIN2RvX554TB4jqzsOQlnnAFFFg==
x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR;
x-ms-office365-filtering-correlation-id: 6f59c952-dcff-446b-514a-08d67c58a238
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(5600109)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);
 SRVR:DB7PR08MB3228; 
x-ms-traffictypediagnostic: DB7PR08MB3228:
x-microsoft-antispam-prvs: <DB7PR08MB3228B4099F4741E02153285D8F830@DB7PR08MB3228.eurprd08.prod.outlook.com>
x-forefront-prvs: 0920602B08
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(366004)(396003)(376002)(136003)(346002)(39860400002)(13464003)(40434004)(189003)(199004)(256004)(99286004)(81166006)(14444005)(5024004)(54906003)(71200400001)(71190400001)(81156014)(76176011)(229853002)(26005)(446003)(74316002)(2501003)(11346002)(7696005)(186003)(102836004)(53546011)(6506007)(2906002)(110136005)(86362001)(8936002)(97736004)(7736002)(33656002)(8676002)(55236004)(105586002)(5660300001)(316002)(106356001)(486006)(55016002)(305945005)(66066001)(6246003)(476003)(72206003)(478600001)(14454004)(4326008)(6436002)(3846002)(6116002)(68736007)(9686003)(25786009)(53936002);
 DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3228;
 H:DB7PR08MB3163.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: bgVndzipdj84qdYOEGBlVtyTz9uC8MHTX3AM5dSHAOELb6tkzZPbl180zFryJJbRlgsfBMjLFyLfT7om1l7BRwmlBVCB0UOBmVUAc/Nw6wxxgZkPmj7OEvLAIoE0lQgbBEAdGldzOA6ocjZWBhGvYs726JGAdls8V93+RPrWz6eW5uWwXazghgj7pnDFaujwrDvB1r57BzdaRJRv08+Oms3CtDI1x5qq4iy5PcGtpIy9G0w9Wpzte9ju4I9xLQba0K7FHURf+E6E9tNAc68AetgQ9VjLm4dLUlhaCxDuf2bshEkX5W0nnFf56jwN5vXiaC6lO1HW8C1mWF/7VrkK8gZ0oSA3qqVH5jUtD0NyvH9VB2o0Q9KzkgQpfNiz66fBqFHdNjjXaQC2pEUfMCDpuCNWEN07pS6iWaAejCQZEgI=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f59c952-dcff-446b-514a-08d67c58a238
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2019 08:49:03.9549 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3228
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: add 128-bit cmpset (x86-64 only)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2019 08:49:05 -0000



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Gage Eads
> Sent: Wednesday, January 16, 2019 6:33 AM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; arybchenko@solarflare.com;
> bruce.richardson@intel.com; konstantin.ananyev@intel.com
> Subject: [dpdk-dev] [PATCH v2 1/2] eal: add 128-bit cmpset (x86-64 only)
>
> This operation can be used for non-blocking algorithms, such as a
> non-blocking stack or ring.
>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
>  .../common/include/arch/x86/rte_atomic_64.h        | 22
> ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
> b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
> index fd2ec9c53..34c2addf8 100644
> --- a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
> +++ b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h
> @@ -34,6 +34,7 @@
>  /*
>   * Inspired from FreeBSD src/sys/amd64/include/atomic.h
>   * Copyright (c) 1998 Doug Rabson
> + * Copyright (c) 2019 Intel Corporation
>   * All rights reserved.
>   */
>
> @@ -208,4 +209,25 @@ static inline void
> rte_atomic64_clear(rte_atomic64_t *v)
>  }
>  #endif
>
> +static inline int
> +rte_atomic128_cmpset(volatile uint64_t *dst, uint64_t *exp, uint64_t
> *src)
> +{
> +uint8_t res;
> +
> +asm volatile (
> +      MPLOCKED
> +      "cmpxchg16b %[dst];"
> +      " sete %[res]"
> +      : [dst] "=3Dm" (*dst),
> +[res] "=3Dr" (res)
> +      : "c" (src[1]),
> +"b" (src[0]),
> +"m" (*dst),
> +"d" (exp[1]),
> +"a" (exp[0])
> +      : "memory");
> +
> +return res;
> +}
> +

CONFIG_RTE_DRIVER_MEMPOOL_NB_STACK=3Dy can't coexist with RTE_FORCE_INTRINS=
ICS=3Dy, this should be explicitly described somewhere in the configuration=
 and documentations.

>  #endif /* _RTE_ATOMIC_X86_64_H_ */
> --
> 2.13.6

IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.