From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id E41FF2BC9 for ; Mon, 8 Apr 2019 06:04:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QLQi/6gz+uMqLj3AKbB+9kH12s7xkvZ9GEetbAXvcWo=; b=W22ipGBc2QagGDZwrsD/58V6qjmoDh96VEAc030hWm+2SZTksgRB7iYc7XNrco1Zn7ypC4roz/4kChmKOccdZxgPjh/2XE85ozTc6i671lAhkTikJChIU2IFbKjJd/9n6qlO1Fhd08XzxtZQ3nK3zOgEsmg8yu9t+m+GUT4c/Qs= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3196.eurprd08.prod.outlook.com (52.134.110.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.21; Mon, 8 Apr 2019 04:04:14 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe%5]) with mapi id 15.20.1771.021; Mon, 8 Apr 2019 04:04:14 +0000 From: "Phil Yang (Arm Technology China)" To: "thomas@monjalon.net" CC: "dev@dpdk.org" , "david.hunt@intel.com" , "reshma.pattan@intel.com" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread Thread-Index: AQHU6etByz4Vgfhr70ysKKie+377zKYsp14AgAUACUA= Date: Mon, 8 Apr 2019 04:04:14 +0000 Message-ID: References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1554274796-23258-1-git-send-email-phil.yang@arm.com> <1554274796-23258-2-git-send-email-phil.yang@arm.com> <28787746.rR50tbZ9jN@xps> In-Reply-To: <28787746.rR50tbZ9jN@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6c61c11-0099-4394-0cc3-08d6bbd743aa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB7PR08MB3196; x-ms-traffictypediagnostic: DB7PR08MB3196: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(346002)(366004)(376002)(136003)(199004)(189003)(13464003)(316002)(71200400001)(71190400001)(66066001)(81156014)(105586002)(25786009)(256004)(81166006)(1730700003)(5660300002)(106356001)(4326008)(9686003)(5640700003)(6116002)(8676002)(8936002)(55016002)(14454004)(97736004)(86362001)(2351001)(3846002)(2906002)(93886005)(6916009)(6506007)(53546011)(7736002)(186003)(478600001)(55236004)(68736007)(99286004)(33656002)(476003)(72206003)(53936002)(26005)(6246003)(6436002)(305945005)(76176011)(486006)(74316002)(52536014)(102836004)(2501003)(7696005)(446003)(54906003)(229853002)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3196; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NlQfpjQjhCl28NQhILlmtDqEIouhsdu89RxPITanG+qPsM0sn5fXWWUcEmeXNy09jVxce4C4xSs6ggSWGZL7pGvBx1Q3E27hjB/xP3iEGn4LbvgQoVMp3rjYgXw8DzZz91yGhByyIwAeq4vU+yk074V51fYULWWbj73nKKQKELh7dYy4Es5sZCq9wObn03Smgp5wNVQebrqJ517uFUQYDGtzfl9zdWlOuOODHVwrzukkY+Q4s5sAoM6DypAHrMd0x9GOjjNPn6ZrFqeGNe7ObcD5z6doAW8v1cJud3EDoeoFwC6lvlV0G5Ws/83SF4qdDIWJ95i4h2LMqeuXvni23Woba0iC0TQvPcDAUbn5RKjcS/S//Ye+OsmRM7ZnJCvo1LS3bDR/2YiTI0E3+H9qWORHrJSwtrUMBZ3dOnTAxpU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6c61c11-0099-4394-0cc3-08d6bbd743aa X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 04:04:14.5493 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3196 Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 04:04:16 -0000 > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, April 5, 2019 7:25 AM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; david.hunt@intel.com; reshma.pattan@intel.com; Gavin > Hu (Arm Technology China) ; Honnappa Nagarahalli > ; nd > Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics fo= r > each worker thread >=20 > Hi, >=20 > 03/04/2019 08:59, Phil Yang: > > The current implementation using the '__sync' built-ins to synchronize > > statistics within worker threads. The '__sync' built-ins functions are > > full barriers which will affect the performance, so add a per worker > > packets statistics to remove the synchronisation between worker threads= . > > > > Since the maximum core number can get to 256, so disable the per core > > stats print in default and add the --insight-worker option to enable it= . > [...] > > Suggested-by: Honnappa Nagarahalli > > Signed-off-by: Phil Yang > > Reviewed-by: Gavin Hu >=20 > There is an error with clang: >=20 > examples/packet_ordering/main.c:82:57: error: > suggest braces around initialization of subobject static struct > wkr_stats_per wkr_stats[RTE_MAX_LCORE] =3D {0}; Thanks, Thomas. It is my bad. I should test with the devtools/test-meson-builds.sh script i= nstead of build with default meson compiler before sending it out. I have addressed this defect in the new version. Please review it. Thanks, Phil >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B2432A0096 for ; Mon, 8 Apr 2019 06:04:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E57942BD8; Mon, 8 Apr 2019 06:04:16 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id E41FF2BC9 for ; Mon, 8 Apr 2019 06:04:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QLQi/6gz+uMqLj3AKbB+9kH12s7xkvZ9GEetbAXvcWo=; b=W22ipGBc2QagGDZwrsD/58V6qjmoDh96VEAc030hWm+2SZTksgRB7iYc7XNrco1Zn7ypC4roz/4kChmKOccdZxgPjh/2XE85ozTc6i671lAhkTikJChIU2IFbKjJd/9n6qlO1Fhd08XzxtZQ3nK3zOgEsmg8yu9t+m+GUT4c/Qs= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3196.eurprd08.prod.outlook.com (52.134.110.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.21; Mon, 8 Apr 2019 04:04:14 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe%5]) with mapi id 15.20.1771.021; Mon, 8 Apr 2019 04:04:14 +0000 From: "Phil Yang (Arm Technology China)" To: "thomas@monjalon.net" CC: "dev@dpdk.org" , "david.hunt@intel.com" , "reshma.pattan@intel.com" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread Thread-Index: AQHU6etByz4Vgfhr70ysKKie+377zKYsp14AgAUACUA= Date: Mon, 8 Apr 2019 04:04:14 +0000 Message-ID: References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1554274796-23258-1-git-send-email-phil.yang@arm.com> <1554274796-23258-2-git-send-email-phil.yang@arm.com> <28787746.rR50tbZ9jN@xps> In-Reply-To: <28787746.rR50tbZ9jN@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6c61c11-0099-4394-0cc3-08d6bbd743aa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB7PR08MB3196; x-ms-traffictypediagnostic: DB7PR08MB3196: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(346002)(366004)(376002)(136003)(199004)(189003)(13464003)(316002)(71200400001)(71190400001)(66066001)(81156014)(105586002)(25786009)(256004)(81166006)(1730700003)(5660300002)(106356001)(4326008)(9686003)(5640700003)(6116002)(8676002)(8936002)(55016002)(14454004)(97736004)(86362001)(2351001)(3846002)(2906002)(93886005)(6916009)(6506007)(53546011)(7736002)(186003)(478600001)(55236004)(68736007)(99286004)(33656002)(476003)(72206003)(53936002)(26005)(6246003)(6436002)(305945005)(76176011)(486006)(74316002)(52536014)(102836004)(2501003)(7696005)(446003)(54906003)(229853002)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3196; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NlQfpjQjhCl28NQhILlmtDqEIouhsdu89RxPITanG+qPsM0sn5fXWWUcEmeXNy09jVxce4C4xSs6ggSWGZL7pGvBx1Q3E27hjB/xP3iEGn4LbvgQoVMp3rjYgXw8DzZz91yGhByyIwAeq4vU+yk074V51fYULWWbj73nKKQKELh7dYy4Es5sZCq9wObn03Smgp5wNVQebrqJ517uFUQYDGtzfl9zdWlOuOODHVwrzukkY+Q4s5sAoM6DypAHrMd0x9GOjjNPn6ZrFqeGNe7ObcD5z6doAW8v1cJud3EDoeoFwC6lvlV0G5Ws/83SF4qdDIWJ95i4h2LMqeuXvni23Woba0iC0TQvPcDAUbn5RKjcS/S//Ye+OsmRM7ZnJCvo1LS3bDR/2YiTI0E3+H9qWORHrJSwtrUMBZ3dOnTAxpU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6c61c11-0099-4394-0cc3-08d6bbd743aa X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 04:04:14.5493 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3196 Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408040414.VIHFTsnuhCAowRH-ot6b6eeTfKcP7YXBMhfSAzuHtXc@z> > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, April 5, 2019 7:25 AM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; david.hunt@intel.com; reshma.pattan@intel.com; Gavin > Hu (Arm Technology China) ; Honnappa Nagarahalli > ; nd > Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics fo= r > each worker thread >=20 > Hi, >=20 > 03/04/2019 08:59, Phil Yang: > > The current implementation using the '__sync' built-ins to synchronize > > statistics within worker threads. The '__sync' built-ins functions are > > full barriers which will affect the performance, so add a per worker > > packets statistics to remove the synchronisation between worker threads= . > > > > Since the maximum core number can get to 256, so disable the per core > > stats print in default and add the --insight-worker option to enable it= . > [...] > > Suggested-by: Honnappa Nagarahalli > > Signed-off-by: Phil Yang > > Reviewed-by: Gavin Hu >=20 > There is an error with clang: >=20 > examples/packet_ordering/main.c:82:57: error: > suggest braces around initialization of subobject static struct > wkr_stats_per wkr_stats[RTE_MAX_LCORE] =3D {0}; Thanks, Thomas. It is my bad. I should test with the devtools/test-meson-builds.sh script i= nstead of build with default meson compiler before sending it out. I have addressed this defect in the new version. Please review it. Thanks, Phil >=20 >=20